Http\Client\Plugin\PluginClient

Complexity

Total Complexity

5

Size/Duplication

Total Lines	46
Duplicated Lines	34.78 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

83.33%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	sendRequest()	8	8	2
A	sendAsyncRequest()	8	8	2

<?php

namespace Http\Client\Plugin;

@trigger_error('The '.__NAMESPACE__.'\PluginClient class is deprecated since version 1.1 and will be removed in 2.0. Use Http\Client\Common\PluginClient instead.', E_USER_DEPRECATED);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

use Http\Client\HttpAsyncClient;
use Http\Client\HttpClient;
use Http\Client\Plugin\Exception\LoopException;
use Psr\Http\Message\RequestInterface;

/**
 * The client managing plugins and providing a decorator around HTTP Clients.
 *
 * @author Joel Wurtz <joel.wurtz@gmail.com>
 *
 * @deprecated since since version 1.1, and will be removed in 2.0. Use {@link \Http\Client\Common\PluginClient} instead.
 */
final class PluginClient implements HttpClient, HttpAsyncClient
{
    /**
     * @var \Http\Client\Common\PluginClient
     */
    private $pluginClient;

    /**
     * @param HttpClient|HttpAsyncClient $client
     * @param Plugin[]                   $plugins
     * @param array                      $options {
     *
     *     @var int $max_restarts Number of times plugins may initiate a restart of the plugin chain. Defaults to 10.
     * }
     *
     * @throws \RuntimeException if client is not an instance of HttpClient or HttpAsyncClient
     */
    public function __construct($client, array $plugins = [], array $options = [])
    {
        $this->pluginClient = new \Http\Client\Common\PluginClient($client, $plugins, $options);
    }

    /**
     * {@inheritdoc}
     */
    public function sendRequest(RequestInterface $request)

This method seems to be duplicated in your project.

    {
        try {
            return $this->pluginClient->sendRequest($request);
        } catch (\Http\Client\Common\Exception\LoopException $e) {
            throw new LoopException($e->getMessage(), $e->getRequest(), $e);

The class Http\Client\Plugin\Exception\LoopException has been deprecated with message: since since version 1.1, and will be removed in 2.0. Use {@link \Http\Client\Common\Exception\LoopException} instead.

        }
    }

    /**
     * {@inheritdoc}
     */
    public function sendAsyncRequest(RequestInterface $request)

This method seems to be duplicated in your project.

    {
        try {
            return $this->pluginClient->sendAsyncRequest($request);
        } catch (\Http\Client\Common\Exception\LoopException $e) {
            throw new LoopException($e->getMessage(), $e->getRequest(), $e);

The class Http\Client\Plugin\Exception\LoopException has been deprecated with message: since since version 1.1, and will be removed in 2.0. Use {@link \Http\Client\Common\Exception\LoopException} instead.

        }
    }
}