Client - Code Metrics - Inspection of "Add conditional responses to mock client" - php-http/mock-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#27)

by Adam

created 2019-02-15 17:08 UTC

Client A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	183
Duplicated Lines	7.65 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	22
lcom	1
cbo	5
dl	14
loc	183
ccs	16
cts	16
cp	1
rs	10
c	0
b	0
f	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	2
B	doSendRequest()	0	36	7
A	on()	0	29	4
A	addException()	7	7	2
A	setDefaultException()	7	7	2
A	addResponse()	0	4	1
A	setDefaultResponse()	0	4	1
A	getRequests()	0	4	1
A	getLastRequest()	0	4	1
A	reset()	0	8	1

How to fix Duplicated Code

<?php

namespace Http\Mock;

use Http\Client\Common\HttpAsyncClientEmulator;
use Http\Client\Common\VersionBridgeClient;
use Http\Client\Exception;
use Http\Client\HttpAsyncClient;
use Http\Client\HttpClient;
use Http\Discovery\MessageFactoryDiscovery;
use Http\Message\RequestMatcher;
use Http\Message\ResponseFactory;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;

/**
 * An implementation of the HTTP client that is useful for automated tests.
 *
 * This mock does not send requests but stores them for later retrieval.
 * You can configure the mock with responses to return and/or exceptions to throw.
 *
 * @author David de Boer <[email protected]>
 */
class Client implements HttpClient, HttpAsyncClient
{
    use HttpAsyncClientEmulator;
    use VersionBridgeClient;

    /**
     * @var ResponseFactory
     */
    private $responseFactory;

    /**
     * @var array
     */
    private $conditionalResults = [];

    /**
     * @var RequestInterface[]
     */
    private $requests = [];

    /**
     * @var ResponseInterface[]
     */
    private $responses = [];

    /**
     * @var ResponseInterface|null
     */
    private $defaultResponse;

    /**
     * @var Exception[]
     */
    private $exceptions = [];

    /**
     * @var Exception|null
     */
    private $defaultException;

    public function __construct(ResponseFactory $responseFactory = null)
    {
        $this->responseFactory = $responseFactory ?: MessageFactoryDiscovery::find();
    }

    /**
     * {@inheritdoc}
     */
    public function doSendRequest(RequestInterface $request)
    {
        $this->requests[] = $request;

        /**
         * @var $matcher RequestMatcher
         * @var ResponseInterface|Exception $result
         */
        foreach ($this->conditionalResults as $result) {
            $matcher = $result['matcher'];
            $callable = $result['callable'];

            if ($matcher->matches($request)) {
                return $callable($request);
            }
        }

        if (count($this->exceptions) > 0) {
            throw array_shift($this->exceptions);
        }

        if (count($this->responses) > 0) {
            return array_shift($this->responses);
        }

        if ($this->defaultException) {
            throw $this->defaultException;
        }

        if ($this->defaultResponse) {
            return $this->defaultResponse;
        }

        // Return success response by default
        return $this->responseFactory->createResponse();
    }

    /**
     * @param RequestMatcher                        $requestMatcher
     * @param ResponseInterface|\Exception|callable $result
     */
    public function on(RequestMatcher $requestMatcher, $result)
    {
        $callable = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        switch (true) {
            case is_callable($result):
                $callable = $result;

                break;
            case $result instanceof ResponseInterface:
                $callable = function () use ($result) {
                    return $result;
                };

                break;
            case $result instanceof \Exception:
                $callable = function () use ($result) {
                    throw $result;
                };

                break;
            default:
                throw new \InvalidArgumentException('Result must be either a response, an exception, or a callable');
        }
        $this->conditionalResults[] = [
            'matcher' => $requestMatcher,
            'callable' => $callable,
        ];
    }

    /**
     * Adds an exception that will be thrown.
     */
    public function addException(\Exception $exception)

    {
        if (!$exception instanceof Exception) {
            @trigger_error('Clients may only throw exceptions of type '.Exception::class.'. Setting an exception of class '.get_class($exception).' will not be possible anymore in the future', E_USER_DEPRECATED);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        }
        $this->exceptions[] = $exception;
    }

    /**
     * Sets the default exception to throw when the list of added exceptions and responses is exhausted.
     *
     * If both a default exception and a default response are set, the exception will be thrown.
     */
    public function setDefaultException(\Exception $defaultException = null)

    {
        if (!$defaultException instanceof Exception) {
            @trigger_error('Clients may only throw exceptions of type '.Exception::class.'. Setting an exception of class '.get_class($defaultException).' will not be possible anymore in the future', E_USER_DEPRECATED);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        }
        $this->defaultException = $defaultException;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }

    /**
     * Adds a response that will be returned in first in first out order.
     */
    public function addResponse(ResponseInterface $response)
    {
        $this->responses[] = $response;
    }

    /**
     * Sets the default response to be returned when the list of added exceptions and responses is exhausted.
     */
    public function setDefaultResponse(ResponseInterface $defaultResponse = null)
    {
        $this->defaultResponse = $defaultResponse;
    }

    /**
     * Returns requests that were sent.
     *
     * @return RequestInterface[]
     */
    public function getRequests()
    {
        return $this->requests;
    }

    public function getLastRequest()
    {
        return end($this->requests);
    }

    public function reset()
    {
        $this->responses = [];
        $this->exceptions = [];
        $this->requests = [];
        $this->setDefaultException();
        $this->setDefaultResponse();
    }
}


1			<?php
2
3			namespace Http\Mock;
4
5			use Http\Client\Common\HttpAsyncClientEmulator;
6			use Http\Client\Common\VersionBridgeClient;
7			use Http\Client\Exception;
8			use Http\Client\HttpAsyncClient;
9			use Http\Client\HttpClient;
10			use Http\Discovery\MessageFactoryDiscovery;
11			use Http\Message\RequestMatcher;
12			use Http\Message\ResponseFactory;
13			use Psr\Http\Message\RequestInterface;
14			use Psr\Http\Message\ResponseInterface;
15
16			/**
17			* An implementation of the HTTP client that is useful for automated tests.
18			*
19			* This mock does not send requests but stores them for later retrieval.
20			* You can configure the mock with responses to return and/or exceptions to throw.
21			*
22			* @author David de Boer <[email protected]>
23			*/
24			class Client implements HttpClient, HttpAsyncClient
25			{
26			use HttpAsyncClientEmulator;
27			use VersionBridgeClient;
28
29			/**
30			* @var ResponseFactory
31			*/
32			private $responseFactory;
33
34			/**
35			* @var array
36			*/
37			private $conditionalResults = [];
38
39			/**
40			* @var RequestInterface[]
41			*/
42			private $requests = [];
43
44			/**
45			* @var ResponseInterface[]
46			*/
47			private $responses = [];
48
49			/**
50			* @var ResponseInterface\|null
51			*/
52			private $defaultResponse;
53
54			/**
55			* @var Exception[]
56			*/
57			private $exceptions = [];
58	11
59			/**
60	11		* @var Exception\|null
61	11		*/
62			private $defaultException;
63
64			public function __construct(ResponseFactory $responseFactory = null)
65			{
66	7		$this->responseFactory = $responseFactory ?: MessageFactoryDiscovery::find();
67			}
68	7
69			/**
70	7		* {@inheritdoc}
71	1		*/
72			public function doSendRequest(RequestInterface $request)
73			{
74	6		$this->requests[] = $request;
75	2
76			/**
77			* @var $matcher RequestMatcher
78	4		* @var ResponseInterface\|Exception $result
79	1		*/
80			foreach ($this->conditionalResults as $result) {
81			$matcher = $result['matcher'];
82	3		$callable = $result['callable'];
83	1
84			if ($matcher->matches($request)) {
85			return $callable($request);
86			}
87	2		}
88
89			if (count($this->exceptions) > 0) {
90			throw array_shift($this->exceptions);
91			}
92
93	2		if (count($this->responses) > 0) {
94			return array_shift($this->responses);
95	2		}
96
97			if ($this->defaultException) {
98			throw $this->defaultException;
99			}
100
101			if ($this->defaultResponse) {
102			return $this->defaultResponse;
103			}
104
105			// Return success response by default
106			return $this->responseFactory->createResponse();
107			}
108
109			/**
110			* @param RequestMatcher $requestMatcher
111			* @param ResponseInterface\|\Exception\|callable $result
112			*/
113			public function on(RequestMatcher $requestMatcher, $result)
114			{
115			$callable = null;
			0 ignored issues – show Unused Code introduced 2019-01-29 19:07 UTC by Report Bug Copy Issue Report `$callable` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
116
117			switch (true) {
118			case is_callable($result):
119			$callable = $result;
120
121			break;
122			case $result instanceof ResponseInterface:
123			$callable = function () use ($result) {
124			return $result;
125			};
126
127			break;
128			case $result instanceof \Exception:
129			$callable = function () use ($result) {
130			throw $result;
131			};
132
133			break;
134			default:
135			throw new \InvalidArgumentException('Result must be either a response, an exception, or a callable');
136			}
137			$this->conditionalResults[] = [
138			'matcher' => $requestMatcher,
139			'callable' => $callable,
140			];
141			}
142
143			/**
144			* Adds an exception that will be thrown.
145			*/
146		View Code Duplication	public function addException(\Exception $exception)
			0 ignored issues – show Duplication introduced 2019-01-02 09:09 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
147			{
148			if (!$exception instanceof Exception) {
149			@trigger_error('Clients may only throw exceptions of type '.Exception::class.'. Setting an exception of class '.get_class($exception).' will not be possible anymore in the future', E_USER_DEPRECATED);
			0 ignored issues – show Security Best Practice introduced 2019-01-02 09:09 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
150			}
151			$this->exceptions[] = $exception;
152			}
153
154			/**
155			* Sets the default exception to throw when the list of added exceptions and responses is exhausted.
156			*
157			* If both a default exception and a default response are set, the exception will be thrown.
158			*/
159		View Code Duplication	public function setDefaultException(\Exception $defaultException = null)
			0 ignored issues – show Duplication introduced 2019-01-02 09:09 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
160			{
161			if (!$defaultException instanceof Exception) {
162			@trigger_error('Clients may only throw exceptions of type '.Exception::class.'. Setting an exception of class '.get_class($defaultException).' will not be possible anymore in the future', E_USER_DEPRECATED);
			0 ignored issues – show Security Best Practice introduced 2019-01-02 09:09 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
163			}
164			$this->defaultException = $defaultException;
			0 ignored issues – show Documentation Bug introduced 2017-11-07 23:58 UTC by Report Bug Copy Issue Report It seems like `$defaultException` can also be of type `object<Exception>`. However, the property `$defaultException` is declared as type `object<Http\Client\Exception>\|null`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
165			}
166
167			/**
168			* Adds a response that will be returned in first in first out order.
169			*/
170			public function addResponse(ResponseInterface $response)
171			{
172			$this->responses[] = $response;
173			}
174
175			/**
176			* Sets the default response to be returned when the list of added exceptions and responses is exhausted.
177			*/
178			public function setDefaultResponse(ResponseInterface $defaultResponse = null)
179			{
180			$this->defaultResponse = $defaultResponse;
181			}
182
183			/**
184			* Returns requests that were sent.
185			*
186			* @return RequestInterface[]
187			*/
188			public function getRequests()
189			{
190			return $this->requests;
191			}
192
193			public function getLastRequest()
194			{
195			return end($this->requests);
196			}
197
198			public function reset()
199			{
200			$this->responses = [];
201			$this->exceptions = [];
202			$this->requests = [];
203			$this->setDefaultException();
204			$this->setDefaultResponse();
205			}
206			}
207

php-http / mock-client

Pull Request — master (#27)

Client A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

10 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like