Completed
Pull Request — master (#38)
by Márk
03:54
created

RegexRequestMatcher::matches()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 4
Code Lines 2

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 0
CRAP Score 2

Importance

Changes 1
Bugs 0 Features 1
Metric Value
c 1
b 0
f 1
dl 0
loc 4
rs 10
cc 1
eloc 2
nc 1
nop 1
ccs 0
cts 0
cp 0
crap 2
1
<?php
0 ignored issues
show
Coding Style Compatibility introduced by
For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 17 and the first side effect is on line 8.

The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.

The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.

To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.

Loading history...
2
3
namespace Http\Message\RequestMatcher;
4
5
use Http\Message\RequestMatcher;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, Http\Message\RequestMatcher\RequestMatcher.

Let’s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let’s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
6
use Psr\Http\Message\RequestInterface;
7
8
@trigger_error('The '.__NAMESPACE__.'\RegexRequestMatcher class is deprecated since version 1.2 and will be removed in 2.0. Use Http\Message\RequestMatcher\RequestMatcher instead.', E_USER_DEPRECATED);
0 ignored issues
show
Security Best Practice introduced by
It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

If you suppress an error, we recommend checking for the error condition explicitly:

// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
Loading history...
9
10
/**
11
 * Match a request with a regex on the uri.
12
 *
13
 * @author Joel Wurtz <[email protected]>
14
 *
15
 * @deprecated since version 1.2 and will be removed in 2.0. Use {@link RequestMatcher} instead.
16
 */
17
final class RegexRequestMatcher implements RequestMatcher
18
{
19
    /**
20
     * Matching regex.
21
     *
22 4
     * @var string
23
     */
24 4
    private $regex;
25 4
26
    /**
27
     * @param string $regex
28
     */
29
    public function __construct($regex)
30 2
    {
31
        $this->regex = $regex;
32 2
    }
33
34
    /**
35
     * {@inheritdoc}
36
     */
37
    public function matches(RequestInterface $request)
38
    {
39
        return (bool) preg_match($this->regex, (string) $request->getUri());
40
    }
41
}
42