Complex classes like Cookie often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Cookie, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
12 | final class Cookie |
||
13 | { |
||
14 | /** |
||
15 | * @var string |
||
16 | */ |
||
17 | private $name; |
||
18 | |||
19 | /** |
||
20 | * @var string|null |
||
21 | */ |
||
22 | private $value; |
||
23 | |||
24 | /** |
||
25 | * @var int|null |
||
26 | */ |
||
27 | private $maxAge; |
||
28 | |||
29 | /** |
||
30 | * @var string|null |
||
31 | */ |
||
32 | private $domain; |
||
33 | |||
34 | /** |
||
35 | * @var string |
||
36 | */ |
||
37 | private $path; |
||
38 | |||
39 | /** |
||
40 | * @var bool |
||
41 | */ |
||
42 | private $secure; |
||
43 | |||
44 | /** |
||
45 | * @var bool |
||
46 | */ |
||
47 | private $httpOnly; |
||
48 | |||
49 | /** |
||
50 | * Expires attribute is HTTP 1.0 only and should be avoided. |
||
51 | * |
||
52 | * @var \DateTime|null |
||
53 | */ |
||
54 | private $expires; |
||
55 | |||
56 | /** |
||
57 | * @param string $name |
||
58 | * @param string|null $value |
||
59 | * @param int $maxAge |
||
60 | * @param string|null $domain |
||
61 | * @param string|null $path |
||
62 | * @param bool $secure |
||
63 | * @param bool $httpOnly |
||
64 | * @param \DateTime|null $expires Expires attribute is HTTP 1.0 only and should be avoided. |
||
65 | * |
||
66 | * @throws \InvalidArgumentException If name, value or max age is not valid. |
||
67 | */ |
||
68 | 57 | public function __construct( |
|
69 | $name, |
||
70 | $value = null, |
||
71 | $maxAge = null, |
||
72 | $domain = null, |
||
73 | $path = null, |
||
74 | $secure = false, |
||
75 | $httpOnly = false, |
||
76 | \DateTime $expires = null |
||
77 | ) { |
||
78 | 57 | $this->validateName($name); |
|
79 | 53 | $this->validateValue($value); |
|
80 | 50 | $this->validateMaxAge($maxAge); |
|
81 | |||
82 | 50 | $this->name = $name; |
|
83 | 50 | $this->value = $value; |
|
84 | 50 | $this->maxAge = $maxAge; |
|
85 | 50 | $this->expires = $expires; |
|
86 | 50 | $this->domain = $this->normalizeDomain($domain); |
|
87 | 50 | $this->path = $this->normalizePath($path); |
|
88 | 50 | $this->secure = (bool) $secure; |
|
89 | 50 | $this->httpOnly = (bool) $httpOnly; |
|
90 | 50 | } |
|
91 | |||
92 | /** |
||
93 | * Returns the name. |
||
94 | * |
||
95 | * @return string |
||
96 | */ |
||
97 | 2 | public function getName() |
|
101 | |||
102 | /** |
||
103 | * Returns the value. |
||
104 | * |
||
105 | * @return string|null |
||
106 | */ |
||
107 | 5 | public function getValue() |
|
111 | |||
112 | /** |
||
113 | * Checks if there is a value. |
||
114 | * |
||
115 | * @return bool |
||
116 | */ |
||
117 | 13 | public function hasValue() |
|
121 | |||
122 | /** |
||
123 | * Sets the value. |
||
124 | * |
||
125 | * @param string|null $value |
||
126 | * |
||
127 | * @return Cookie |
||
128 | */ |
||
129 | 8 | public function withValue($value) |
|
138 | |||
139 | /** |
||
140 | * Returns the max age. |
||
141 | * |
||
142 | * @return int|null |
||
143 | */ |
||
144 | 3 | public function getMaxAge() |
|
148 | |||
149 | /** |
||
150 | * Checks if there is a max age. |
||
151 | * |
||
152 | * @return bool |
||
153 | */ |
||
154 | 1 | public function hasMaxAge() |
|
158 | |||
159 | /** |
||
160 | * Sets the max age. |
||
161 | * |
||
162 | * @param int|null $maxAge |
||
163 | * |
||
164 | * @return Cookie |
||
165 | */ |
||
166 | 2 | public function withMaxAge($maxAge) |
|
167 | { |
||
168 | 2 | $this->validateMaxAge($maxAge); |
|
169 | |||
170 | 1 | $new = clone $this; |
|
171 | 1 | $new->maxAge = $maxAge; |
|
172 | |||
173 | 1 | return $new; |
|
174 | } |
||
175 | |||
176 | /** |
||
177 | * Returns the expiration time. |
||
178 | * |
||
179 | * @return \DateTime|null |
||
180 | */ |
||
181 | 3 | public function getExpires() |
|
185 | |||
186 | /** |
||
187 | * Checks if there is an expiration time. |
||
188 | * |
||
189 | * @return bool |
||
190 | */ |
||
191 | 2 | public function hasExpires() |
|
195 | |||
196 | /** |
||
197 | * Sets the expires. |
||
198 | * |
||
199 | * @param \DateTime|null $expires |
||
200 | * |
||
201 | * @return Cookie |
||
202 | */ |
||
203 | 1 | public function withExpires(\DateTime $expires = null) |
|
210 | |||
211 | /** |
||
212 | * Checks if the cookie is expired. |
||
213 | * |
||
214 | * @return bool |
||
215 | */ |
||
216 | 2 | public function isExpired() |
|
220 | |||
221 | /** |
||
222 | * Returns the domain. |
||
223 | * |
||
224 | * @return string|null |
||
225 | */ |
||
226 | 3 | public function getDomain() |
|
230 | |||
231 | /** |
||
232 | * Checks if there is a domain. |
||
233 | * |
||
234 | * @return bool |
||
235 | */ |
||
236 | 4 | public function hasDomain() |
|
240 | |||
241 | /** |
||
242 | * Sets the domain. |
||
243 | * |
||
244 | * @param string|null $domain |
||
245 | * |
||
246 | * @return Cookie |
||
247 | */ |
||
248 | 1 | public function withDomain($domain) |
|
255 | |||
256 | /** |
||
257 | * Checks whether this cookie is meant for this domain. |
||
258 | * |
||
259 | * @see http://tools.ietf.org/html/rfc6265#section-5.1.3 |
||
260 | * |
||
261 | * @param string $domain |
||
262 | * |
||
263 | * @return bool |
||
264 | */ |
||
265 | 2 | public function matchDomain($domain) |
|
279 | |||
280 | /** |
||
281 | * Returns the path. |
||
282 | * |
||
283 | * @return string |
||
284 | */ |
||
285 | 2 | public function getPath() |
|
289 | |||
290 | /** |
||
291 | * Sets the path. |
||
292 | * |
||
293 | * @param string|null $path |
||
294 | * |
||
295 | * @return Cookie |
||
296 | */ |
||
297 | 1 | public function withPath($path) |
|
304 | |||
305 | /** |
||
306 | * Checks whether this cookie is meant for this path. |
||
307 | * |
||
308 | * @see http://tools.ietf.org/html/rfc6265#section-5.1.4 |
||
309 | * |
||
310 | * @param string $path |
||
311 | * |
||
312 | * @return bool |
||
313 | */ |
||
314 | 3 | public function matchPath($path) |
|
318 | |||
319 | /** |
||
320 | * Checks whether this cookie may only be sent over HTTPS. |
||
321 | * |
||
322 | * @return bool |
||
323 | */ |
||
324 | 2 | public function isSecure() |
|
328 | |||
329 | /** |
||
330 | * Sets whether this cookie should only be sent over HTTPS. |
||
331 | * |
||
332 | * @param bool $secure |
||
333 | * |
||
334 | * @return Cookie |
||
335 | */ |
||
336 | 1 | public function withSecure($secure) |
|
343 | |||
344 | /** |
||
345 | * Check whether this cookie may not be accessed through Javascript. |
||
346 | * |
||
347 | * @return bool |
||
348 | */ |
||
349 | 2 | public function isHttpOnly() |
|
353 | |||
354 | /** |
||
355 | * Sets whether this cookie may not be accessed through Javascript. |
||
356 | * |
||
357 | * @param bool $httpOnly |
||
358 | * |
||
359 | * @return Cookie |
||
360 | */ |
||
361 | 1 | public function withHttpOnly($httpOnly) |
|
368 | |||
369 | /** |
||
370 | * Checks if this cookie represents the same cookie as $cookie. |
||
371 | * |
||
372 | * This does not compare the values, only name, domain and path. |
||
373 | * |
||
374 | * @param Cookie $cookie |
||
375 | * |
||
376 | * @return bool |
||
377 | */ |
||
378 | 10 | public function match(Cookie $cookie) |
|
382 | |||
383 | /** |
||
384 | * Validates the name attribute. |
||
385 | * |
||
386 | * @see http://tools.ietf.org/search/rfc2616#section-2.2 |
||
387 | * |
||
388 | * @param string $name |
||
389 | * |
||
390 | * @throws \InvalidArgumentException If the name is empty or contains invalid characters. |
||
391 | */ |
||
392 | 57 | private function validateName($name) |
|
403 | |||
404 | /** |
||
405 | * Validates a value. |
||
406 | * |
||
407 | * @see http://tools.ietf.org/html/rfc6265#section-4.1.1 |
||
408 | * |
||
409 | * @param string|null $value |
||
410 | * |
||
411 | * @throws \InvalidArgumentException If the value contains invalid characters. |
||
412 | */ |
||
413 | 53 | private function validateValue($value) |
|
421 | |||
422 | /** |
||
423 | * Validates a Max-Age attribute. |
||
424 | * |
||
425 | * @param int|null $maxAge |
||
426 | * |
||
427 | * @throws \InvalidArgumentException If the Max-Age is not an empty or integer value. |
||
428 | */ |
||
429 | 50 | private function validateMaxAge($maxAge) |
|
430 | { |
||
431 | 50 | if (isset($maxAge)) { |
|
432 | 7 | if (!is_int($maxAge)) { |
|
433 | 1 | throw new \InvalidArgumentException('Max-Age must be integer'); |
|
434 | } |
||
435 | 6 | } |
|
436 | 50 | } |
|
437 | |||
438 | /** |
||
439 | * Remove the leading '.' and lowercase the domain as per spec in RFC 6265. |
||
440 | * |
||
441 | * @see http://tools.ietf.org/html/rfc6265#section-4.1.2.3 |
||
442 | * @see http://tools.ietf.org/html/rfc6265#section-5.1.3 |
||
443 | * @see http://tools.ietf.org/html/rfc6265#section-5.2.3 |
||
444 | * |
||
445 | * @param string|null $domain |
||
446 | * |
||
447 | * @return string |
||
448 | */ |
||
449 | 50 | private function normalizeDomain($domain) |
|
450 | { |
||
451 | 50 | if (isset($domain)) { |
|
452 | 6 | $domain = ltrim(strtolower($domain), '.'); |
|
453 | 6 | } |
|
454 | |||
455 | 50 | return $domain; |
|
456 | } |
||
457 | |||
458 | /** |
||
459 | * Processes path as per spec in RFC 6265. |
||
460 | * |
||
461 | * @see http://tools.ietf.org/html/rfc6265#section-5.1.4 |
||
462 | * @see http://tools.ietf.org/html/rfc6265#section-5.2.4 |
||
463 | * |
||
464 | * @param string|null $path |
||
465 | * |
||
466 | * @return string |
||
467 | */ |
||
468 | 50 | private function normalizePath($path) |
|
478 | } |
||
479 |
PHP has two types of connecting operators (logical operators, and boolean operators):
and
&&
or
||
The difference between these is the order in which they are executed. In most cases, you would want to use a boolean operator like
&&
, or||
.Let’s take a look at a few examples:
Logical Operators are used for Control-Flow
One case where you explicitly want to use logical operators is for control-flow such as this:
Since
die
introduces problems of its own, f.e. it makes our code hardly testable, and prevents any kind of more sophisticated error handling; you probably do not want to use this in real-world code. Unfortunately, logical operators cannot be combined withthrow
at this point:These limitations lead to logical operators rarely being of use in current PHP code.