RegexRequestMatcher::matches() - Code Metrics - Inspection of "adjust request matcher to the symfony model" - php-http/message - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#36)

by David

created 2016-03-02 09:37 UTC

RegexRequestMatcher::matches() B

↳ Parent: RegexRequestMatcher

Complexity

Conditions	9
Paths	5

Size

Total Lines	20
Code Lines	10

Duplication

Lines	7
Ratio	35 %

Code Coverage

Tests	10
CRAP Score	9

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	7
loc	20
ccs	10
cts	10
cp	1
rs	7.756
cc	9
eloc	10
nc	5
nop	1
crap	9

<?php

namespace Http\Message\RequestMatcher;

use Http\Message\RequestMatcher;
use Psr\Http\Message\RequestInterface;

/**
 * A port of the Symfony RequestMatcher for PSR-7.
 *
 * @author Fabien Potencier <[email protected]>
 * @author Joel Wurtz <[email protected]>
 */
final class RegexRequestMatcher implements RequestMatcher
{
    /**
     * @var string
     */
    private $path;

    /**
     * @var string
     */
    private $host;

    /**
     * @var array
     */
    private $methods = [];

    /**
     * @var string
     */
    private $ips = [];


    /**
     * @var array
     */
    private $attributes = [];


    /**
     * @var string[]
     */
    private $schemes = [];

    /**
     * The regular expressions used for path or host must be specified without delimiter.
     * You do not need to escape the forward slash / to match it.
     *
     * @param string|null          $path    Regular expression for the path
     * @param string|null          $host    Regular expression for the hostname
     * @param string|string[]|null $methods Method or list of methods to match
     * @param string|string[]|null $schemes Scheme or list of schemes to match (e.g. http or https)
     */
    public function __construct($path = null, $host = null, $methods = [], $schemes = [])
    {
        $this->path = $path;
        $this->host = $host;
        $this->methods = array_map('strtoupper', (array) $methods);
        $this->schemes = array_map('strtolower', (array) $schemes);
    }

    /**
     * {@inheritdoc}
     *
     * @api
     */
    public function matches(RequestInterface $request)
    {
        if ($this->schemes && !in_array($request->getUri()->getScheme(), $this->schemes)) {

            return false;
        }

        if ($this->methods && !in_array($request->getMethod(), $this->methods)) {

            return false;
        }

        if (null !== $this->path && !preg_match('{'.$this->path.'}', rawurldecode($request->getUri()->getPath()))) {

            return false;
        }

        if (null !== $this->host && !preg_match('{'.$this->host.'}i', $request->getUri()->getHost())) {

            return false;
        }

        return true;
    }
}


1			<?php
2
3			namespace Http\Message\RequestMatcher;
4
5			use Http\Message\RequestMatcher;
6			use Psr\Http\Message\RequestInterface;
7
8			/**
9			* A port of the Symfony RequestMatcher for PSR-7.
10			*
11			* @author Fabien Potencier <[email protected]>
12			* @author Joel Wurtz <[email protected]>
13			*/
14			final class RegexRequestMatcher implements RequestMatcher
15			{
16			/**
17			* @var string
18			*/
19			private $path;
20
21			/**
22			* @var string
23			*/
24			private $host;
25
26			/**
27			* @var array
28			*/
29			private $methods = [];
30
31			/**
32			* @var string
33			*/
34			private $ips = [];
			0 ignored issues – show Unused Code introduced 2016-03-02 09:39 UTC by Report Bug Copy Issue Report The property `$ips` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
35
36			/**
37			* @var array
38			*/
39			private $attributes = [];
			0 ignored issues – show Unused Code introduced 2016-03-02 09:39 UTC by Report Bug Copy Issue Report The property `$attributes` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
40
41			/**
42			* @var string[]
43			*/
44			private $schemes = [];
45
46			/**
47			* The regular expressions used for path or host must be specified without delimiter.
48			* You do not need to escape the forward slash / to match it.
49			*
50			* @param string\|null $path Regular expression for the path
51			* @param string\|null $host Regular expression for the hostname
52			* @param string\|string[]\|null $methods Method or list of methods to match
53			* @param string\|string[]\|null $schemes Scheme or list of schemes to match (e.g. http or https)
54			*/
55	10		public function __construct($path = null, $host = null, $methods = [], $schemes = [])
56			{
57	10		$this->path = $path;
58	10		$this->host = $host;
59	10		$this->methods = array_map('strtoupper', (array) $methods);
60	10		$this->schemes = array_map('strtolower', (array) $schemes);
61	10		}
62
63			/**
64			* {@inheritdoc}
65			*
66			* @api
67			*/
68	8		public function matches(RequestInterface $request)
69			{
70	8		if ($this->schemes && !in_array($request->getUri()->getScheme(), $this->schemes)) {
			0 ignored issues – show Bug Best Practice introduced 2016-03-02 09:39 UTC by Report Bug Copy Issue Report The expression `$this->schemes` of type `string[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
71	1		return false;
72			}
73
74	7		if ($this->methods && !in_array($request->getMethod(), $this->methods)) {
			0 ignored issues – show Bug Best Practice introduced 2016-03-02 09:39 UTC by Report Bug Copy Issue Report The expression `$this->methods` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
75	1		return false;
76			}
77
78	6	View Code Duplication	if (null !== $this->path && !preg_match('{'.$this->path.'}', rawurldecode($request->getUri()->getPath()))) {
			0 ignored issues – show Duplication introduced 2016-03-02 09:39 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
79	1		return false;
80			}
81
82	5	View Code Duplication	if (null !== $this->host && !preg_match('{'.$this->host.'}i', $request->getUri()->getHost())) {
			0 ignored issues – show Duplication introduced 2016-03-02 09:39 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
83	1		return false;
84			}
85
86	4		return true;
87			}
88			}
89

php-http / message

Pull Request — master (#36)

RegexRequestMatcher::matches() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like