Completed
Push — master ( fe9938...a97bd2 )
by Márk
8s
created

RequestMatcher   A

Complexity

Total Complexity 10

Size/Duplication

Total Lines 65
Duplicated Lines 9.23 %

Coupling/Cohesion

Components 1
Dependencies 2

Test Coverage

Coverage 100%

Importance

Changes 1
Bugs 0 Features 1
Metric Value
wmc 10
c 1
b 0
f 1
lcom 1
cbo 2
dl 6
loc 65
ccs 16
cts 16
cp 1
rs 10

2 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 7 1
B matches() 6 20 9

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace Http\Message\RequestMatcher;
4
5
use Http\Message\RequestMatcher as RequestMatcherInterface;
6
use Psr\Http\Message\RequestInterface;
7
8
/**
9
 * A port of the Symfony RequestMatcher for PSR-7.
10
 *
11
 * @author Fabien Potencier <[email protected]>
12
 * @author Joel Wurtz <[email protected]>
13
 */
14
final class RequestMatcher implements RequestMatcherInterface
15
{
16
    /**
17
     * @var string
18
     */
19
    private $path;
20
21
    /**
22
     * @var string
23
     */
24
    private $host;
25
26
    /**
27
     * @var array
28
     */
29
    private $methods = [];
30
31
    /**
32
     * @var string[]
33
     */
34
    private $schemes = [];
35
36
    /**
37
     * The regular expressions used for path or host must be specified without delimiter.
38
     * You do not need to escape the forward slash / to match it.
39
     *
40
     * @param string|null          $path    Regular expression for the path
41
     * @param string|null          $host    Regular expression for the hostname
42
     * @param string|string[]|null $methods Method or list of methods to match
43
     * @param string|string[]|null $schemes Scheme or list of schemes to match (e.g. http or https)
44
     */
45 10
    public function __construct($path = null, $host = null, $methods = [], $schemes = [])
46
    {
47 10
        $this->path = $path;
48 10
        $this->host = $host;
49 10
        $this->methods = array_map('strtoupper', (array) $methods);
50 10
        $this->schemes = array_map('strtolower', (array) $schemes);
51 10
    }
52
53
    /**
54
     * {@inheritdoc}
55
     *
56
     * @api
57
     */
58 8
    public function matches(RequestInterface $request)
59
    {
60 8
        if ($this->schemes && !in_array($request->getUri()->getScheme(), $this->schemes)) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $this->schemes of type string[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
61 1
            return false;
62
        }
63
64 7
        if ($this->methods && !in_array($request->getMethod(), $this->methods)) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $this->methods of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
65 1
            return false;
66
        }
67
68 6 View Code Duplication
        if (null !== $this->path && !preg_match('{'.$this->path.'}', rawurldecode($request->getUri()->getPath()))) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
69 1
            return false;
70
        }
71
72 5 View Code Duplication
        if (null !== $this->host && !preg_match('{'.$this->host.'}i', $request->getUri()->getHost())) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
73 1
            return false;
74
        }
75
76 4
        return true;
77
    }
78
}
79