Http\Message\RequestMatcher\RegexRequestMatcher

Complexity

Total Complexity

10

Size/Duplication

Total Lines	76
Duplicated Lines	9.21 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
B	matches()	7	21	9

<?php

namespace Http\Message\RequestMatcher;

use Http\Message\RequestMatcher;
use Psr\Http\Message\RequestInterface;

/**
 * A port of the Symfony RequestMatcher for PSR-7.
 *
 * @author Fabien Potencier <fabien@symfony.com>
 * @author Joel Wurtz <joel.wurtz@gmail.com>
 */
final class RegexRequestMatcher implements RequestMatcher
{
    /**
     * @var string
     */
    private $path;

    /**
     * @var string
     */
    private $host;

    /**
     * @var array
     */
    private $methods = array();

    /**
     * @var string
     */
    private $ips = array();

The property $ips is not used and could be removed.

    /**
     * @var array
     */
    private $attributes = array();

The property $attributes is not used and could be removed.

    /**
     * @var string[]
     */
    private $schemes = array();

    /**
     * The regular expressions used for path or host must be specified without delimiter.
     * You do not need to escape the forward slash / to match it.
     *
     * @param string|null          $path       Regular expression for the path
     * @param string|null          $host       Regular expression for the hostname
     * @param string|string[]|null $methods    Method or list of methods to match
     * @param string|string[]|null $schemes    Scheme or list of schemes to match (e.g. http or https)
     */
    public function __construct($path = null, $host = null, $methods = [], $schemes = [])
    {
        $this->path = $path;
        $this->host = $host;
        $this->methods = array_map('strtoupper', (array) $methods);
        $this->schemes = array_map('strtolower', (array) $schemes);
    }

    /**
     * {@inheritdoc}
     *
     * @api
     */
    public function matches(RequestInterface $request)
    {
        if ($this->schemes && !in_array($request->getUri()->getScheme(), $this->schemes)) {

The expression $this->schemes of type string[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return false;
        }

        if ($this->methods && !in_array($request->getMethod(), $this->methods)) {

The expression $this->methods of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return false;
        }

        if (null !== $this->path && !preg_match('{'.$this->path.'}', rawurldecode($request->getUri()->getPath()))) {

This code seems to be duplicated across your project.

            return false;
        }

        if (null !== $this->host && !preg_match('{'.$this->host.'}i', $request->getUri()->getHost())) {

This code seems to be duplicated across your project.

            return false;
        }

        return true;
    }
}