HttpFulfilledPromise::wait() - Code Metrics - Inspection of "Add specific http promise" - php-http/httplug - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#116)

by Joel

created 2016-08-01 09:47 UTC

HttpFulfilledPromise::wait() A

↳ Parent: HttpFulfilledPromise

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	3

Duplication

Lines	6
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	6
loc	6
ccs	0
cts	6
cp	0
rs	9.4285
cc	2
eloc	3
nc	2
nop	1
crap	6

<?php

namespace Http\Client\Promise;

use Http\Client\Exception;
use Http\Promise\Promise;
use Psr\Http\Message\ResponseInterface;

final class HttpFulfilledPromise implements Promise

{
    /**
     * @var ResponseInterface
     */
    private $response;

    /**
     * @param ResponseInterface $response
     */
    public function __construct(ResponseInterface $response)
    {
        $this->response = $response;
    }

    /**
     * {@inheritdoc}
     */
    public function then(callable $onFulfilled = null, callable $onRejected = null)
    {
        if (null === $onFulfilled) {
            return $this;
        }

        try {
            return new self($onFulfilled($this->response));
        } catch (Exception $e) {
            return new HttpRejectedPromise($e);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
    }

    /**
     * {@inheritdoc}
     */
    public function getState()
    {
        return Promise::FULFILLED;
    }

    /**
     * {@inheritdoc}
     */
    public function wait($unwrap = true)
    {
        if ($unwrap) {
            return $this->response;
        }
    }
}


1		<?php
2
3		namespace Http\Client\Promise;
4
5		use Http\Client\Exception;
6		use Http\Promise\Promise;
7		use Psr\Http\Message\ResponseInterface;
8
9	View Code Duplication	final class HttpFulfilledPromise implements Promise
		0 ignored issues – show Duplication introduced 2016-08-01 09:52 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
10		{
11		/**
12		* @var ResponseInterface
13		*/
14		private $response;
15
16		/**
17		* @param ResponseInterface $response
18		*/
19		public function __construct(ResponseInterface $response)
20		{
21		$this->response = $response;
22		}
23
24		/**
25		* {@inheritdoc}
26		*/
27		public function then(callable $onFulfilled = null, callable $onRejected = null)
28		{
29		if (null === $onFulfilled) {
30		return $this;
31		}
32
33		try {
34		return new self($onFulfilled($this->response));
35		} catch (Exception $e) {
36		return new HttpRejectedPromise($e);
		0 ignored issues – show Documentation introduced 2016-08-01 09:52 UTC by Report Bug Copy Issue Report `$e` is of type `object<Http\Client\Exception>`, but the function expects a `object<Exception>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
37		}
38		}
39
40		/**
41		* {@inheritdoc}
42		*/
43		public function getState()
44		{
45		return Promise::FULFILLED;
46		}
47
48		/**
49		* {@inheritdoc}
50		*/
51		public function wait($unwrap = true)
52		{
53		if ($unwrap) {
54		return $this->response;
55		}
56		}
57		}
58

php-http / httplug

Pull Request — master (#116)

HttpFulfilledPromise::wait() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like