Client::buildClient() - Code Metrics - Inspection of "Merge pull request #31 from php-http/adapter-creat..." - php-http/guzzle6-adapter - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a6b3ef...8b330d )

by Márk

created 2016-05-09 21:39 UTC

Client::buildClient() A

↳ Parent: Client

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	8
ccs	0
cts	5
cp	0
rs	9.4285
cc	1
eloc	5
nc	1
nop	1
crap	2

<?php

namespace Http\Adapter\Guzzle6;

use GuzzleHttp\Client as GuzzleClient;
use GuzzleHttp\ClientInterface;
use GuzzleHttp\HandlerStack;
use GuzzleHttp\Middleware;
use Http\Client\HttpAsyncClient;
use Http\Client\HttpClient;
use Psr\Http\Message\RequestInterface;

/**
 * HTTP Adapter for Guzzle 6.
 *
 * @author David de Boer <[email protected]>
 */
class Client implements HttpClient, HttpAsyncClient
{
    /**
     * @var ClientInterface
     */
    private $client;

    /**
     * @param ClientInterface|null $client
     */
    public function __construct(ClientInterface $client = null)
    {
        if (!$client) {
            $client = static::buildClient();
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
        }

        $this->client = $client;
    }

    /**
     * Factory method to create the guzzle 6 adapter with custom configuration for guzzle.
     *
     * @param array $config Configuration to create guzzle with.
     *
     * @return Client
     */
    public static function createWithConfig(array $config)
    {
        return new self(static::buildClient($config));
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
    }

    /**
     * {@inheritdoc}
     */
    public function sendRequest(RequestInterface $request)
    {
        $promise = $this->sendAsyncRequest($request);

        return $promise->wait();
    }

    /**
     * {@inheritdoc}
     */
    public function sendAsyncRequest(RequestInterface $request)
    {
        $promise = $this->client->sendAsync($request);

        return new Promise($promise, $request);
    }

    /**
     * Build the guzzle client instance.
     *
     * @param array $config Additional configuration
     *
     * @return GuzzleClient
     */
    private static function buildClient(array $config)
    {
        $handlerStack = new HandlerStack(\GuzzleHttp\choose_handler());
        $handlerStack->push(Middleware::prepareBody(), 'prepare_body');
        $config = array_merge(['handler' => $handlerStack], $config);

        return new GuzzleClient($config);
    }
}


1		<?php
2
3		namespace Http\Adapter\Guzzle6;
4
5		use GuzzleHttp\Client as GuzzleClient;
6		use GuzzleHttp\ClientInterface;
7		use GuzzleHttp\HandlerStack;
8		use GuzzleHttp\Middleware;
9		use Http\Client\HttpAsyncClient;
10		use Http\Client\HttpClient;
11		use Psr\Http\Message\RequestInterface;
12
13		/**
14		* HTTP Adapter for Guzzle 6.
15		*
16		* @author David de Boer <[email protected]>
17		*/
18		class Client implements HttpClient, HttpAsyncClient
19		{
20		/**
21		* @var ClientInterface
22		*/
23		private $client;
24
25		/**
26		* @param ClientInterface\|null $client
27		*/
28	324	public function __construct(ClientInterface $client = null)
29		{
30	324	if (!$client) {
31		$client = static::buildClient();
		0 ignored issues – show Bug introduced 2016-05-09 15:40 UTC by Report Bug Copy Issue Report Since `buildClient()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `buildClient()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history... Bug introduced 2016-05-09 15:40 UTC by Report Bug Copy Issue Report The call to `buildClient()` misses a required argument `$config`. This check looks for function calls that miss required arguments. Loading history...
32		}
33
34	324	$this->client = $client;
35	324	}
36
37		/**
38		* Factory method to create the guzzle 6 adapter with custom configuration for guzzle.
39		*
40		* @param array $config Configuration to create guzzle with.
41		*
42		* @return Client
43		*/
44		public static function createWithConfig(array $config)
45		{
46		return new self(static::buildClient($config));
		0 ignored issues – show Bug introduced 2016-05-09 15:40 UTC by Report Bug Copy Issue Report Since `buildClient()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `buildClient()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
47		}
48
49		/**
50		* {@inheritdoc}
51		*/
52	159	public function sendRequest(RequestInterface $request)
53		{
54	159	$promise = $this->sendAsyncRequest($request);
55
56	159	return $promise->wait();
57		}
58
59		/**
60		* {@inheritdoc}
61		*/
62	324	public function sendAsyncRequest(RequestInterface $request)
63		{
64	324	$promise = $this->client->sendAsync($request);
65
66	324	return new Promise($promise, $request);
67		}
68
69		/**
70		* Build the guzzle client instance.
71		*
72		* @param array $config Additional configuration
73		*
74		* @return GuzzleClient
75		*/
76		private static function buildClient(array $config)
77		{
78		$handlerStack = new HandlerStack(\GuzzleHttp\choose_handler());
79		$handlerStack->push(Middleware::prepareBody(), 'prepare_body');
80		$config = array_merge(['handler' => $handlerStack], $config);
81
82		return new GuzzleClient($config);
83		}
84		}
85

php-http / guzzle6-adapter

Push — master ( a6b3ef...8b330d )

Client::buildClient() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like