Puli - Code Metrics - Inspection of "Flexible discovery" - php-http/discovery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#59)

by Tobias

created 2016-06-12 16:18 UTC

Puli A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	94
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	13
c	2
b	0
f	0
lcom	1
cbo	3
dl	0
loc	94
rs	10

5 Methods

Rating	Name	Size	Complexity
A	getPuliFactory()	18	4
A	setPuliFactory()	9	3
A	resetPuliFactory()	5	1
A	getPuliDiscovery()	11	2
A	find()	15	3

<?php

namespace Http\Discovery\Strategy;

use Http\Discovery\Exception\PuliUnavailableException;
use Puli\Discovery\Api\Discovery;

/**
 * @author David de Boer <[email protected]>
 * @author Márk Sági-Kazár <[email protected]>
 */
class Puli implements DiscoveryStrategy
{
    /**
     * @var GeneratedPuliFactory
     */
    private static $puliFactory;

    /**
     * @var Discovery
     */
    private static $puliDiscovery;

    /**
     * @return GeneratedPuliFactory
     */
    public static function getPuliFactory()
    {
        if (null === self::$puliFactory) {
            if (!defined('PULI_FACTORY_CLASS')) {
                throw new PuliUnavailableException('Puli Factory is not available');
            }

            $puliFactoryClass = PULI_FACTORY_CLASS;

            if (!class_exists($puliFactoryClass)) {
                throw new PuliUnavailableException('Puli Factory class does not exist');
            }

            self::$puliFactory = new $puliFactoryClass();
        }

        return self::$puliFactory;
    }

    /**
     * Sets the Puli factory.
     *
     * @param object $puliFactory
     */
    public static function setPuliFactory($puliFactory)
    {
        if (!is_callable([$puliFactory, 'createRepository']) || !is_callable([$puliFactory, 'createDiscovery'])) {
            throw new \InvalidArgumentException('The Puli Factory must expose a repository and a discovery');
        }

        self::$puliFactory = $puliFactory;
        self::$puliDiscovery = null;
    }

    /**
     * Resets the factory.
     */
    public static function resetPuliFactory()
    {
        self::$puliFactory = null;
        self::$puliDiscovery = null;
    }

    /**
     * Returns the Puli discovery layer.
     *
     * @return Discovery
     */
    public static function getPuliDiscovery()
    {
        if (!isset(self::$puliDiscovery)) {
            $factory = self::getPuliFactory();
            $repository = $factory->createRepository();

            self::$puliDiscovery = $factory->createDiscovery($repository);
        }

        return self::$puliDiscovery;
    }

    /**
     * {@inheritdoc}
     */
    public static function find($type)
    {
        $returnData = [];
        $bindings = self::getPuliDiscovery()->findBindings($type);

        foreach ($bindings as $binding) {
            $condition = true;
            if ($binding->hasParameterValue('depends')) {
                $condition = $binding->getParameterValue('depends');
            }
            $returnData[] = ['class' => $binding->getClassName(), 'condition' => $condition];
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        }

        return $returnData;
    }
}


1			<?php
2
3			namespace Http\Discovery\Strategy;
4
5			use Http\Discovery\Exception\PuliUnavailableException;
6			use Puli\Discovery\Api\Discovery;
7
8			/**
9			* @author David de Boer <[email protected]>
10			* @author Márk Sági-Kazár <[email protected]>
11			*/
12			class Puli implements DiscoveryStrategy
13			{
14			/**
15			* @var GeneratedPuliFactory
16			*/
17			private static $puliFactory;
18
19			/**
20			* @var Discovery
21			*/
22			private static $puliDiscovery;
23
24			/**
25			* @return GeneratedPuliFactory
26			*/
27			public static function getPuliFactory()
28			{
29			if (null === self::$puliFactory) {
30			if (!defined('PULI_FACTORY_CLASS')) {
31			throw new PuliUnavailableException('Puli Factory is not available');
32			}
33
34			$puliFactoryClass = PULI_FACTORY_CLASS;
35
36			if (!class_exists($puliFactoryClass)) {
37			throw new PuliUnavailableException('Puli Factory class does not exist');
38			}
39
40			self::$puliFactory = new $puliFactoryClass();
41			}
42
43			return self::$puliFactory;
44			}
45
46			/**
47			* Sets the Puli factory.
48			*
49			* @param object $puliFactory
50			*/
51			public static function setPuliFactory($puliFactory)
52			{
53			if (!is_callable([$puliFactory, 'createRepository']) \|\| !is_callable([$puliFactory, 'createDiscovery'])) {
54			throw new \InvalidArgumentException('The Puli Factory must expose a repository and a discovery');
55			}
56
57			self::$puliFactory = $puliFactory;
58			self::$puliDiscovery = null;
59			}
60
61			/**
62			* Resets the factory.
63			*/
64			public static function resetPuliFactory()
65			{
66			self::$puliFactory = null;
67			self::$puliDiscovery = null;
68			}
69
70			/**
71			* Returns the Puli discovery layer.
72			*
73			* @return Discovery
74			*/
75			public static function getPuliDiscovery()
76			{
77			if (!isset(self::$puliDiscovery)) {
78			$factory = self::getPuliFactory();
79			$repository = $factory->createRepository();
80
81			self::$puliDiscovery = $factory->createDiscovery($repository);
82			}
83
84			return self::$puliDiscovery;
85			}
86
87			/**
88			* {@inheritdoc}
89			*/
90			public static function find($type)
91			{
92			$returnData = [];
93			$bindings = self::getPuliDiscovery()->findBindings($type);
94
95			foreach ($bindings as $binding) {
96			$condition = true;
97			if ($binding->hasParameterValue('depends')) {
98			$condition = $binding->getParameterValue('depends');
99			}
100			$returnData[] = ['class' => $binding->getClassName(), 'condition' => $condition];
			0 ignored issues – show Bug introduced 2016-06-12 16:20 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Puli\Discovery\Api\Binding\Binding` as the method `getClassName()` does only exist in the following implementations of said interface: `Puli\Discovery\Binding\ClassBinding`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
101			}
102
103			return $returnData;
104			}
105			}
106

php-http / discovery

Pull Request — master (#59)

Puli A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like