php-http / client-common

src/FlexibleHttpClient.php

<?php

namespace Http\Client\Common;

use Http\Client\HttpAsyncClient;
use Http\Client\HttpClient;

/**
 * A flexible http client, which implements both interface and will emulate
 * one contract, the other, or none at all depending on the injected client contract.
 *
 * @author Joel Wurtz <joel.wurtz@gmail.com>
 */
final class FlexibleHttpClient implements HttpClient, HttpAsyncClient
{
    use HttpClientDecorator;
    use HttpAsyncClientDecorator;

    /**
     * @param HttpClient|HttpAsyncClient $client
     */
    public function __construct($client)
    {
        if (!($client instanceof HttpClient) && !($client instanceof HttpAsyncClient)) {
            throw new \LogicException('Client must be an instance of Http\\Client\\HttpClient or Http\\Client\\HttpAsyncClient');
        }

        $this->httpClient = $client;

It seems like $client can also be of type object<Http\Client\HttpAsyncClient>. However, the property $httpClient is declared as type object<Http\Client\HttpClient>. Maybe add an additional type check?

        $this->httpAsyncClient = $client;

It seems like $client can also be of type object<Http\Client\HttpClient>. However, the property $httpAsyncClient is declared as type object<Http\Client\HttpAsyncClient>. Maybe add an additional type check?

        if (!($this->httpClient instanceof HttpClient)) {
            $this->httpClient = new EmulatedHttpClient($this->httpClient);
        }

        if (!($this->httpAsyncClient instanceof HttpAsyncClient)) {
            $this->httpAsyncClient = new EmulatedHttpAsyncClient($this->httpAsyncClient);
        }
    }
}