HttpClientRouter::addClient() - Code Metrics - Inspection of "[WIP] Add http client router feature" - php-http/client-common - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#13)

by Márk

created 2016-03-30 13:00 UTC

HttpClientRouter::addClient() A

↳ Parent: HttpClientRouter

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	7
ccs	6
cts	6
cp	1
rs	9.4285
cc	1
eloc	4
nc	1
nop	2
crap	1

<?php

namespace Http\Client\Common;

use Http\Client\Exception\RequestException;
use Http\Client\HttpAsyncClient;
use Http\Client\HttpClient;
use Http\Message\RequestMatcher;
use Psr\Http\Message\RequestInterface;

/**
 * Route a request to a specific client in the stack based using a RequestMatcher.
 *
 * @author Joel Wurtz <[email protected]>
 */
class HttpClientRouter implements HttpClient, HttpAsyncClient
{
    /**
     * @var array
     */
    private $clients = [];

    /**
     * {@inheritdoc}
     */
    public function sendAsyncRequest(RequestInterface $request)
    {
        $client = $this->chooseHttpClient($request);

        return $client->sendAsyncRequest($request);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * {@inheritdoc}
     */
    public function sendRequest(RequestInterface $request)
    {
        $client = $this->chooseHttpClient($request);

        return $client->sendRequest($request);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Add a client to the router.
     *
     * @param HttpClient|HttpAsyncClient $client
     * @param RequestMatcher             $requestMatcher
     */
    public function addClient($client, RequestMatcher $requestMatcher)
    {
        $this->clients[] = [
            'matcher' => $requestMatcher,
            'client'  => new FlexibleHttpClient($client)
        ];
    }

    /**
     * Choose an HTTP client given a specific request.
     *
     * @param RequestInterface $request
     *
     * @return HttpClient|HttpAsyncClient
     */
    protected function chooseHttpClient(RequestInterface $request)
    {
        foreach ($this->clients as $client) {
            if ($client['matcher']->matches($request)) {
                return $client['client'];
            }
        }

        throw new RequestException('No client found for the specified request', $request);
    }
}


1		<?php
2
3		namespace Http\Client\Common;
4
5		use Http\Client\Exception\RequestException;
6		use Http\Client\HttpAsyncClient;
7		use Http\Client\HttpClient;
8		use Http\Message\RequestMatcher;
9		use Psr\Http\Message\RequestInterface;
10
11		/**
12		* Route a request to a specific client in the stack based using a RequestMatcher.
13		*
14		* @author Joel Wurtz <[email protected]>
15		*/
16		class HttpClientRouter implements HttpClient, HttpAsyncClient
17		{
18		/**
19		* @var array
20		*/
21		private $clients = [];
22
23		/**
24		* {@inheritdoc}
25		*/
26	2	public function sendAsyncRequest(RequestInterface $request)
27		{
28	2	$client = $this->chooseHttpClient($request);
29
30	1	return $client->sendAsyncRequest($request);
		0 ignored issues – show Bug introduced 2016-01-31 21:37 UTC by Report Bug Copy Issue Report The method `sendAsyncRequest` does only exist in `Http\Client\HttpAsyncClient`, but not in `Http\Client\HttpClient`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
31		}
32
33		/**
34		* {@inheritdoc}
35		*/
36	2	public function sendRequest(RequestInterface $request)
37		{
38	2	$client = $this->chooseHttpClient($request);
39
40	1	return $client->sendRequest($request);
		0 ignored issues – show Bug introduced 2016-01-31 21:37 UTC by Report Bug Copy Issue Report The method `sendRequest` does only exist in `Http\Client\HttpClient`, but not in `Http\Client\HttpAsyncClient`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
41		}
42
43		/**
44		* Add a client to the router.
45		*
46		* @param HttpClient\|HttpAsyncClient $client
47		* @param RequestMatcher $requestMatcher
48		*/
49	4	public function addClient($client, RequestMatcher $requestMatcher)
50		{
51	4	$this->clients[] = [
52	4	'matcher' => $requestMatcher,
53	4	'client' => new FlexibleHttpClient($client)
54	4	];
55	4	}
56
57		/**
58		* Choose an HTTP client given a specific request.
59		*
60		* @param RequestInterface $request
61		*
62		* @return HttpClient\|HttpAsyncClient
63		*/
64	4	protected function chooseHttpClient(RequestInterface $request)
65		{
66	4	foreach ($this->clients as $client) {
67	4	if ($client['matcher']->matches($request)) {
68	2	return $client['client'];
69		}
70	2	}
71
72	2	throw new RequestException('No client found for the specified request', $request);
73		}
74		}
75

php-http / client-common

Pull Request — master (#13)

HttpClientRouter::addClient() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like