Complex classes like CachePlugin often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use CachePlugin, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
19 | final class CachePlugin implements Plugin |
||
20 | { |
||
21 | /** |
||
22 | * @var CacheItemPoolInterface |
||
23 | */ |
||
24 | private $pool; |
||
25 | |||
26 | /** |
||
27 | * @var StreamFactory |
||
28 | */ |
||
29 | private $streamFactory; |
||
30 | |||
31 | /** |
||
32 | * @var array |
||
33 | */ |
||
34 | private $config; |
||
35 | |||
36 | /** |
||
37 | * @param CacheItemPoolInterface $pool |
||
38 | * @param StreamFactory $streamFactory |
||
39 | * @param array $config { |
||
40 | * |
||
41 | * @var bool $respect_cache_headers Whether to look at the cache directives or ignore them |
||
42 | * @var int $default_ttl (seconds) If we do not respect cache headers or can't calculate a good ttl, use this |
||
43 | * value |
||
44 | * @var string $hash_algo The hashing algorithm to use when generating cache keys |
||
45 | * @var int $cache_lifetime (seconds) To support serving a previous stale response when the server answers 304 |
||
46 | * we have to store the cache for a longer time than the server originally says it is valid for. |
||
47 | * We store a cache item for $cache_lifetime + max age of the response. |
||
48 | * } |
||
49 | */ |
||
50 | 10 | public function __construct(CacheItemPoolInterface $pool, StreamFactory $streamFactory, array $config = []) |
|
59 | |||
60 | /** |
||
61 | * {@inheritdoc} |
||
62 | */ |
||
63 | 8 | public function handleRequest(RequestInterface $request, callable $next, callable $first) |
|
138 | |||
139 | /** |
||
140 | * @param int|null $maxAge |
||
141 | * |
||
142 | * @return int|null |
||
143 | */ |
||
144 | 4 | private function calculateCacheItemExpiresAfter($maxAge) |
|
152 | |||
153 | /** |
||
154 | * @param int|null $maxAge |
||
155 | * |
||
156 | * @return int|null |
||
157 | */ |
||
158 | 4 | private function getResponseExpiresAt($maxAge) |
|
166 | |||
167 | /** |
||
168 | * Verify that we can cache this response. |
||
169 | * |
||
170 | * @param ResponseInterface $response |
||
171 | * |
||
172 | * @return bool |
||
173 | */ |
||
174 | 4 | protected function isCacheable(ResponseInterface $response) |
|
188 | |||
189 | /** |
||
190 | * Get the value of a parameter in the cache control header. |
||
191 | * |
||
192 | * @param ResponseInterface $response |
||
193 | * @param string $name The field of Cache-Control to fetch |
||
194 | * |
||
195 | * @return bool|string The value of the directive, true if directive without value, false if directive not present |
||
196 | */ |
||
197 | 4 | private function getCacheControlDirective(ResponseInterface $response, $name) |
|
214 | |||
215 | /** |
||
216 | * @param RequestInterface $request |
||
217 | * |
||
218 | * @return string |
||
219 | */ |
||
220 | 7 | private function createCacheKey(RequestInterface $request) |
|
224 | |||
225 | /** |
||
226 | * Get a ttl in seconds. It could return null if we do not respect cache headers and got no defaultTtl. |
||
227 | * |
||
228 | * @param ResponseInterface $response |
||
229 | * |
||
230 | * @return int|null |
||
231 | */ |
||
232 | 4 | private function getMaxAge(ResponseInterface $response) |
|
257 | |||
258 | /** |
||
259 | * Configure an options resolver. |
||
260 | * |
||
261 | * @param OptionsResolver $resolver |
||
262 | */ |
||
263 | 10 | private function configureOptions(OptionsResolver $resolver) |
|
277 | |||
278 | /** |
||
279 | * @param CacheItemInterface $cacheItem |
||
280 | * |
||
281 | * @return ResponseInterface |
||
282 | */ |
||
283 | 2 | private function createResponseFromCacheItem(CacheItemInterface $cacheItem) |
|
293 | |||
294 | /** |
||
295 | * Get the value of the "If-Modified-Since" header. |
||
296 | * |
||
297 | * @param CacheItemInterface $cacheItem |
||
298 | * |
||
299 | * @return string|null |
||
300 | */ |
||
301 | 2 | private function getModifiedSinceHeaderValue(CacheItemInterface $cacheItem) |
|
314 | |||
315 | /** |
||
316 | * Get the ETag from the cached response. |
||
317 | * |
||
318 | * @param CacheItemInterface $cacheItem |
||
319 | * |
||
320 | * @return string|null |
||
321 | */ |
||
322 | 2 | private function getETag(CacheItemInterface $cacheItem) |
|
340 | } |
||
341 |