Issues in DiscoveredClientsTest.php (master) - Issues in master - php-http/HttplugBundle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (171)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/Functional/DiscoveredClientsTest.php (7 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

namespace Http\HttplugBundle\Tests\Functional;

use Http\Adapter\Guzzle7\Client;
use Http\Client\HttpAsyncClient;
use Http\Client\HttpClient;
use Http\Discovery\HttpAsyncClientDiscovery;
use Http\Discovery\HttpClientDiscovery;
use Http\Discovery\Strategy\CommonClassesStrategy;
use Http\HttplugBundle\Collector\ProfileClient;
use Http\HttplugBundle\Discovery\ConfiguredClientsStrategyListener;
use Nyholm\NSA;
use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;

class DiscoveredClientsTest extends WebTestCase
{
    public function testDiscoveredClient(): void

    {
        $container = $this->getContainer(false);

        $this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_client'));

        $service = $container->get('httplug.auto_discovery.auto_discovered_client');

        $this->assertInstanceOf(HttpClient::class, $service);
    }

    public function testDiscoveredAsyncClient(): void

    {
        $container = $this->getContainer(false);

        $this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_async'));

        $service = $container->get('httplug.auto_discovery.auto_discovered_async');

        $this->assertInstanceOf(HttpAsyncClient::class, $service);
    }

    public function testDiscoveredClientWithProfilingEnabled(): void

    {
        $container = $this->getContainer(true);

        $this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_client'));

        $service = $container->get('httplug.auto_discovery.auto_discovered_client');

        $this->assertInstanceOf(ProfileClient::class, $service);
        $this->assertInstanceOf(HttpClient::class, NSA::getProperty($service, 'client'));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    public function testDiscoveredAsyncClientWithProfilingEnabled(): void

    {
        $container = $this->getContainer(true);

        $this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_async'));

        $service = $container->get('httplug.auto_discovery.auto_discovered_async');

        $this->assertInstanceOf(ProfileClient::class, $service);
        $this->assertInstanceOf(HttpAsyncClient::class, NSA::getProperty($service, 'client'));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     * Test with httplug.discovery.client: "auto".
     */
    public function testDiscovery(): void
    {
        $container = $this->getContainer(true);

        $this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_client'));
        $this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_async'));
        $this->assertTrue($container->has('httplug.strategy'));

        $container->get('httplug.strategy');

        $httpClient = $container->get('httplug.auto_discovery.auto_discovered_client');
        $httpAsyncClient = $container->get('httplug.auto_discovery.auto_discovered_async');

        $this->assertInstanceOf(ProfileClient::class, $httpClient);
        $this->assertSame(HttpClientDiscovery::find(), $httpClient);
        $this->assertInstanceOf(ProfileClient::class, $httpAsyncClient);
        $this->assertSame(HttpAsyncClientDiscovery::find(), $httpAsyncClient);
    }

    /**
     * Test with httplug.discovery.client: null.
     */
    public function testDisabledDiscovery(): void
    {
        $container = $this->getContainer(true, 'discovery_disabled');

        $this->assertFalse($container->has('httplug.auto_discovery.auto_discovered_client'));
        $this->assertFalse($container->has('httplug.auto_discovery.auto_discovered_async'));
        $this->assertFalse($container->has('httplug.strategy'));
    }

    /**
     * Test with httplug.discovery.client: "httplug.client.acme".
     */
    public function testForcedDiscovery(): void
    {
        if (!class_exists(Client::class)) {
            $this->markTestSkipped('Guzzle7 adapter is not installed');
        }

        $container = $this->getContainer(true, 'discovery_forced');

        $this->assertFalse($container->has('httplug.auto_discovery.auto_discovered_client'));
        $this->assertFalse($container->has('httplug.auto_discovery.auto_discovered_async'));
        $this->assertTrue($container->has('httplug.strategy'));

        $container->get('httplug.strategy');

        $this->assertEquals($container->get('httplug.client.acme'), HttpClientDiscovery::find());
        $this->assertEquals($container->get('httplug.client.acme'), HttpAsyncClientDiscovery::find());
    }

    private function getContainer($debug, $environment = 'test')
    {
        static::bootKernel(['debug' => $debug, 'environment' => $environment]);

        return static::$kernel->getContainer();
    }

    protected function setUp(): void
    {
        parent::setUp();

        // Reset values
        $strategy = new ConfiguredClientsStrategyListener(null, null);

        HttpClientDiscovery::setStrategies([CommonClassesStrategy::class]);
        $strategy->onEvent();
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Http\HttplugBundle\Tests\Functional;
6
7		use Http\Adapter\Guzzle7\Client;
8		use Http\Client\HttpAsyncClient;
9		use Http\Client\HttpClient;
10		use Http\Discovery\HttpAsyncClientDiscovery;
11		use Http\Discovery\HttpClientDiscovery;
12		use Http\Discovery\Strategy\CommonClassesStrategy;
13		use Http\HttplugBundle\Collector\ProfileClient;
14		use Http\HttplugBundle\Discovery\ConfiguredClientsStrategyListener;
15		use Nyholm\NSA;
16		use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
17
18		class DiscoveredClientsTest extends WebTestCase
19		{
20	View Code Duplication	public function testDiscoveredClient(): void
		0 ignored issues – show Duplication introduced 2019-03-05 12:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
21		{
22		$container = $this->getContainer(false);
23
24		$this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_client'));
25
26		$service = $container->get('httplug.auto_discovery.auto_discovered_client');
27
28		$this->assertInstanceOf(HttpClient::class, $service);
29		}
30
31	View Code Duplication	public function testDiscoveredAsyncClient(): void
		0 ignored issues – show Duplication introduced 2020-12-23 13:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
32		{
33		$container = $this->getContainer(false);
34
35		$this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_async'));
36
37		$service = $container->get('httplug.auto_discovery.auto_discovered_async');
38
39		$this->assertInstanceOf(HttpAsyncClient::class, $service);
40		}
41
42	View Code Duplication	public function testDiscoveredClientWithProfilingEnabled(): void
		0 ignored issues – show Duplication introduced 2019-03-05 12:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
43		{
44		$container = $this->getContainer(true);
45
46		$this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_client'));
47
48		$service = $container->get('httplug.auto_discovery.auto_discovered_client');
49
50		$this->assertInstanceOf(ProfileClient::class, $service);
51		$this->assertInstanceOf(HttpClient::class, NSA::getProperty($service, 'client'));
		0 ignored issues – show Bug introduced 2019-11-20 07:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$service` defined by `$container->get('httplug...uto_discovered_client')` on line `48` can also be of type `null`; however, `Nyholm\NSA::getProperty()` does only seem to accept `object\|string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
52		}
53
54	View Code Duplication	public function testDiscoveredAsyncClientWithProfilingEnabled(): void
		0 ignored issues – show Duplication introduced 2019-03-05 12:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
55		{
56		$container = $this->getContainer(true);
57
58		$this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_async'));
59
60		$service = $container->get('httplug.auto_discovery.auto_discovered_async');
61
62		$this->assertInstanceOf(ProfileClient::class, $service);
63		$this->assertInstanceOf(HttpAsyncClient::class, NSA::getProperty($service, 'client'));
		0 ignored issues – show Bug introduced 2019-11-20 07:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$service` defined by `$container->get('httplug...auto_discovered_async')` on line `60` can also be of type `null`; however, `Nyholm\NSA::getProperty()` does only seem to accept `object\|string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
64		}
65
66		/**
67		* Test with httplug.discovery.client: "auto".
68		*/
69		public function testDiscovery(): void
70		{
71		$container = $this->getContainer(true);
72
73		$this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_client'));
74		$this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_async'));
75		$this->assertTrue($container->has('httplug.strategy'));
76
77		$container->get('httplug.strategy');
78
79		$httpClient = $container->get('httplug.auto_discovery.auto_discovered_client');
80		$httpAsyncClient = $container->get('httplug.auto_discovery.auto_discovered_async');
81
82		$this->assertInstanceOf(ProfileClient::class, $httpClient);
83		$this->assertSame(HttpClientDiscovery::find(), $httpClient);
84		$this->assertInstanceOf(ProfileClient::class, $httpAsyncClient);
85		$this->assertSame(HttpAsyncClientDiscovery::find(), $httpAsyncClient);
86		}
87
88		/**
89		* Test with httplug.discovery.client: null.
90		*/
91		public function testDisabledDiscovery(): void
92		{
93		$container = $this->getContainer(true, 'discovery_disabled');
94
95		$this->assertFalse($container->has('httplug.auto_discovery.auto_discovered_client'));
96		$this->assertFalse($container->has('httplug.auto_discovery.auto_discovered_async'));
97		$this->assertFalse($container->has('httplug.strategy'));
98		}
99
100		/**
101		* Test with httplug.discovery.client: "httplug.client.acme".
102		*/
103		public function testForcedDiscovery(): void
104		{
105		if (!class_exists(Client::class)) {
106		$this->markTestSkipped('Guzzle7 adapter is not installed');
107		}
108
109		$container = $this->getContainer(true, 'discovery_forced');
110
111		$this->assertFalse($container->has('httplug.auto_discovery.auto_discovered_client'));
112		$this->assertFalse($container->has('httplug.auto_discovery.auto_discovered_async'));
113		$this->assertTrue($container->has('httplug.strategy'));
114
115		$container->get('httplug.strategy');
116
117		$this->assertEquals($container->get('httplug.client.acme'), HttpClientDiscovery::find());
118		$this->assertEquals($container->get('httplug.client.acme'), HttpAsyncClientDiscovery::find());
119		}
120
121		private function getContainer($debug, $environment = 'test')
122		{
123		static::bootKernel(['debug' => $debug, 'environment' => $environment]);
124
125		return static::$kernel->getContainer();
126		}
127
128		protected function setUp(): void
129		{
130		parent::setUp();
131
132		// Reset values
133		$strategy = new ConfiguredClientsStrategyListener(null, null);
		0 ignored issues – show Unused Code introduced 2020-10-21 06:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to `ConfiguredClientsStrategyListener::__construct()` has too many arguments starting with `null`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
134		HttpClientDiscovery::setStrategies([CommonClassesStrategy::class]);
135		$strategy->onEvent();
136		}
137		}
138

php-http / HttplugBundle

Issues (171)

Security Analysis not enabled

tests/Functional/DiscoveredClientsTest.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like