ConfiguredClientsStrategy - Code Metrics - Inspection of "Add a discovery strategy" - php-http/HttplugBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#85)

by Tobias

created 2016-07-13 16:28 UTC

ConfiguredClientsStrategy A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
wmc	6
c	1
b	0
f	1
lcom	1
cbo	0
dl	0
loc	49
rs	10

4 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	getCandidates()	8	3
A	onEvent()	4	1
A	getSubscribedEvents()	7	1

<?php

namespace Http\HttplugBundle\Discovery;

use Http\Client\HttpClient;
use Http\Discovery\Exception\StrategyUnavailableException;
use Http\Discovery\HttpClientDiscovery;
use Http\Discovery\Strategy\DiscoveryStrategy;
use Symfony\Component\Console\ConsoleEvents;
use Symfony\Component\EventDispatcher\Event;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;
use Symfony\Component\HttpKernel\KernelEvents;

/**
 * A strategy that provide clients configured with HTTPlug bundle. With help from this strategy
 * we can use the web debug toolbar for clients found with the discovery.
 *
 * @author Tobias Nyholm <[email protected]>
 */
class ConfiguredClientsStrategy implements DiscoveryStrategy, EventSubscriberInterface
{
    /**
     * @var HttpClient
     */
    private static $client;

    /**
     * @param HttpClient $httpClient
     */
    public function __construct(HttpClient $httpClient)
    {
        static::$client = $httpClient;
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
    }

    /**
     * {@inheritdoc}
     */
    public static function getCandidates($type)
    {
        if (static::$client !== null && $type == HttpClient::class) {
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
            return [['class' => function() { return static::$client; }]];
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
        }

        return [];
    }

    /**
     * Make sure to use our custom strategy
     * @param Event $e
     */
    public function onEvent(Event $e)

    {
        HttpClientDiscovery::prependStrategy(self::class);

    }

    /**
     * Whenever these events occur we make sure to add our strategy to the discovery.
     *
     * {@inheritdoc}
     */
    public static function getSubscribedEvents()
    {
        return [
            KernelEvents::REQUEST => ['onEvent', 1024],
            ConsoleEvents::COMMAND => ['onEvent', 1024],
        ];
    }
}


1			<?php
2
3			namespace Http\HttplugBundle\Discovery;
4
5			use Http\Client\HttpClient;
6			use Http\Discovery\Exception\StrategyUnavailableException;
7			use Http\Discovery\HttpClientDiscovery;
8			use Http\Discovery\Strategy\DiscoveryStrategy;
9			use Symfony\Component\Console\ConsoleEvents;
10			use Symfony\Component\EventDispatcher\Event;
11			use Symfony\Component\EventDispatcher\EventSubscriberInterface;
12			use Symfony\Component\HttpKernel\KernelEvents;
13
14			/**
15			* A strategy that provide clients configured with HTTPlug bundle. With help from this strategy
16			* we can use the web debug toolbar for clients found with the discovery.
17			*
18			* @author Tobias Nyholm <[email protected]>
19			*/
20			class ConfiguredClientsStrategy implements DiscoveryStrategy, EventSubscriberInterface
21			{
22			/**
23			* @var HttpClient
24			*/
25			private static $client;
26
27			/**
28			* @param HttpClient $httpClient
29			*/
30			public function __construct(HttpClient $httpClient)
31			{
32			static::$client = $httpClient;
			0 ignored issues – show Bug introduced 2016-07-13 16:35 UTC by Report Bug Copy Issue Report Since `$client` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$client` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
33			}
34
35			/**
36			* {@inheritdoc}
37			*/
38			public static function getCandidates($type)
39			{
40			if (static::$client !== null && $type == HttpClient::class) {
			0 ignored issues – show Bug introduced 2016-07-13 16:35 UTC by Report Bug Copy Issue Report Since `$client` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$client` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
41			return [['class' => function() { return static::$client; }]];
			0 ignored issues – show Bug introduced 2016-07-13 16:35 UTC by Report Bug Copy Issue Report Since `$client` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$client` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
42			}
43
44			return [];
45			}
46
47			/**
48			* Make sure to use our custom strategy
49			* @param Event $e
50			*/
51			public function onEvent(Event $e)
			1 ignored issue – show Unused Code introduced 2016-07-13 16:35 UTC by Report Bug Copy Issue Report The parameter `$e` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
52			{
53			HttpClientDiscovery::prependStrategy(self::class);
			0 ignored issues – show Bug introduced 2016-07-13 16:35 UTC by Report Bug Copy Issue Report The method `prependStrategy()` does not seem to exist on `object<Http\Discovery\HttpClientDiscovery>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
54			}
55
56			/**
57			* Whenever these events occur we make sure to add our strategy to the discovery.
58			*
59			* {@inheritdoc}
60			*/
61			public static function getSubscribedEvents()
62			{
63			return [
64			KernelEvents::REQUEST => ['onEvent', 1024],
65			ConsoleEvents::COMMAND => ['onEvent', 1024],
66			];
67			}
68			}
69

php-http / HttplugBundle

Pull Request — master (#85)

ConfiguredClientsStrategy A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like