ProfileClient::sendRequest() - Code Metrics - Inspection of "add profile client" - php-http/HttplugBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#136)

by Fabien

created 2017-04-02 14:45 UTC

ProfileClient::sendRequest() A

↳ Parent: ProfileClient

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	1

<?php

namespace Http\HttplugBundle\Collector;

use Http\Client\Common\FlexibleHttpClient;
use Http\Client\HttpAsyncClient;
use Http\Client\HttpClient;
use Psr\Http\Message\RequestInterface;

/**
 * The ProfileClient decorates any HttpClient (or HttpAsyncClient) to gather target url and response status code.
 *
 * @author Fabien Bourigault <[email protected]>
 *
 * @internal
 */
class ProfileClient implements HttpClient, HttpAsyncClient
{
    /**
     * @var HttpClient|HttpAsyncClient
     */
    private $client;

    /**
     * @var Collector
     */
    private $collector;

    /**
     * @param HttpClient|HttpAsyncClient $client
     * @param Collector                  $collector
     */
    public function __construct($client, Collector $collector)
    {
        if (!$client instanceof HttpClient || !$client instanceof HttpAsyncClient) {
            throw new \RuntimeException(sprintf(
                '%s first argument must implement %s and %s. Consider using %s.',
                    __METHOD__,
                    HttpClient::class,
                    HttpAsyncClient::class,
                    FlexibleHttpClient::class
            ));
        }
        $this->client = $client;
        $this->collector = $collector;
    }

    /**
     * {@inheritdoc}
     */
    public function sendAsyncRequest(RequestInterface $request)
    {
        $this->collectRequestInformations($request);

        return $this->client->sendAsyncRequest($request);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * {@inheritdoc}
     */
    public function sendRequest(RequestInterface $request)
    {
        $this->collectRequestInformations($request);

        return $this->client->sendRequest($request);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * @param RequestInterface $request
     */
    private function collectRequestInformations(RequestInterface $request)
    {
        if (!$stack = $this->collector->getCurrentStack()) {
            return;
        }

        $stack = $this->collector->getCurrentStack();
        $stack->setRequestTarget($request->getRequestTarget());
        $stack->setRequestMethod($request->getMethod());
    }
}


1			<?php
2
3			namespace Http\HttplugBundle\Collector;
4
5			use Http\Client\Common\FlexibleHttpClient;
6			use Http\Client\HttpAsyncClient;
7			use Http\Client\HttpClient;
8			use Psr\Http\Message\RequestInterface;
9
10			/**
11			* The ProfileClient decorates any HttpClient (or HttpAsyncClient) to gather target url and response status code.
12			*
13			* @author Fabien Bourigault <[email protected]>
14			*
15			* @internal
16			*/
17			class ProfileClient implements HttpClient, HttpAsyncClient
18			{
19			/**
20			* @var HttpClient\|HttpAsyncClient
21			*/
22			private $client;
23
24			/**
25			* @var Collector
26			*/
27			private $collector;
28
29			/**
30			* @param HttpClient\|HttpAsyncClient $client
31			* @param Collector $collector
32			*/
33			public function __construct($client, Collector $collector)
34			{
35			if (!$client instanceof HttpClient \|\| !$client instanceof HttpAsyncClient) {
36			throw new \RuntimeException(sprintf(
37			'%s first argument must implement %s and %s. Consider using %s.',
38			__METHOD__,
39			HttpClient::class,
40			HttpAsyncClient::class,
41			FlexibleHttpClient::class
42			));
43			}
44			$this->client = $client;
45			$this->collector = $collector;
46			}
47
48			/**
49			* {@inheritdoc}
50			*/
51			public function sendAsyncRequest(RequestInterface $request)
52			{
53			$this->collectRequestInformations($request);
54
55			return $this->client->sendAsyncRequest($request);
			0 ignored issues – show Bug introduced 2017-04-01 22:03 UTC by Report Bug Copy Issue Report The method `sendAsyncRequest` does only exist in `Http\Client\HttpAsyncClient`, but not in `Http\Client\HttpClient`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
56			}
57
58			/**
59			* {@inheritdoc}
60			*/
61			public function sendRequest(RequestInterface $request)
62			{
63			$this->collectRequestInformations($request);
64
65			return $this->client->sendRequest($request);
			0 ignored issues – show Bug introduced 2017-04-01 22:03 UTC by Report Bug Copy Issue Report The method `sendRequest` does only exist in `Http\Client\HttpClient`, but not in `Http\Client\HttpAsyncClient`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
66			}
67
68			/**
69			* @param RequestInterface $request
70			*/
71			private function collectRequestInformations(RequestInterface $request)
72			{
73			if (!$stack = $this->collector->getCurrentStack()) {
74			return;
75			}
76
77			$stack = $this->collector->getCurrentStack();
78			$stack->setRequestTarget($request->getRequestTarget());
79			$stack->setRequestMethod($request->getMethod());
80			}
81			}
82

php-http / HttplugBundle

Pull Request — master (#136)

ProfileClient::sendRequest() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like