Http\HttplugBundle\DependencyInjection\Compiler\DiscoveryPass

Complexity

Total Complexity

6

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	process()	0	27	4
A	registerFactory()	0	15	2

<?php

namespace Http\HttplugBundle\DependencyInjection\Compiler;

use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Exception\RuntimeException;
use Symfony\Component\DependencyInjection\Reference;

/**
 * Adds fallback and discovery services.
 *
 * @author Márk Sági-Kazár <mark.sagikazar@gmail.com>
 */
final class DiscoveryPass implements CompilerPassInterface
{
    /**
     * Fallback services and classes.
     *
     * @var array
     */
    private $services = [
        'client' => 'Http\Client\HttpClient',
        'message_factory' => 'Http\Message\MessageFactory',
        'uri_factory' => 'Http\Message\UriFactory',
        'stream_factory' => 'Http\Message\StreamFactory',
    ];

    /**
     * {@inheritdoc}
     */
    public function process(ContainerBuilder $container)
    {
        $useDiscovery = false;

        foreach ($this->services as $service => $class) {
            $serviceId = sprintf('httplug.%s.default', $service);

            if (false === $container->has($serviceId)) {
                // Register and create factory for the first time
                if (false === $useDiscovery) {
                    $this->registerFactory($container);

                    $factory = [
                        new Reference('httplug.factory'),
                        'find',
                    ];

                    $useDiscovery = true;
                }

                $definition = $container->register($serviceId, $class);

                $definition->setFactory($factory);

The variable $factory does not seem to be defined for all execution paths leading up to this point.

                $definition->addArgument($class);
            }
        }
    }

    /**
     * @param ContainerBuilder $container
     *
     * @throws RuntimeException
     */
    private function registerFactory(ContainerBuilder $container)
    {
        if (false === $container->has('puli.discovery')) {
            throw new RuntimeException(
                'You need to install puli/symfony-bundle or add configuration at httplug.classes in order to use this bundle. Refer to http://some.doc'
            );
        }

        $definition = $container->register('httplug.factory', 'Http\HttplugBundle\Util\HttplugFactory');

        $definition
            ->addArgument(new Reference('puli.discovery'))
            ->setPublic(false)
        ;
    }
}