Formatter::formatException() - Code Metrics - Inspection of "[WIP]Fix profiler for plugins like redirect" - php-http/HttplugBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#128)

by Fabien

created 2017-02-08 22:36 UTC

Formatter::formatException() A

↳ Parent: Formatter

Complexity

Conditions	3
Paths	3

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	6
nc	3
nop	1

<?php

namespace Http\HttplugBundle\Collector;

use Exception;
use Http\Client\Exception\HttpException;
use Http\Client\Exception\TransferException;
use Http\Message\Formatter as FormatterInterface;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;

class Formatter implements FormatterInterface
{
    /**
     * @var Formatter
     */
    private $formatter;

    /**
     * @param FormatterInterface $formatter
     */
    public function __construct(FormatterInterface $formatter)
    {
        $this->formatter = $formatter;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
    }

    /**
     * Formats an exception.
     *
     * @param Exception $exception
     *
     * @return string
     */
    public function formatException(Exception $exception)
    {
        if ($exception instanceof HttpException) {
            return $this->formatter->formatResponse($exception->getResponse());
        }

        if ($exception instanceof TransferException) {
            return $exception->getMessage();
        }

        return sprintf('Unexpected exception of type "%s"', get_class($exception));
    }


    /**
     * {@inheritdoc}
     */
    public function formatRequest(RequestInterface $request)
    {
        return $this->formatter->formatRequest($request);
    }

    /**
     * {@inheritdoc}
     */
    public function formatResponse(ResponseInterface $response)
    {
        return $this->formatter->formatResponse($response);
    }
}


1			<?php
2
3			namespace Http\HttplugBundle\Collector;
4
5			use Exception;
6			use Http\Client\Exception\HttpException;
7			use Http\Client\Exception\TransferException;
8			use Http\Message\Formatter as FormatterInterface;
9			use Psr\Http\Message\RequestInterface;
10			use Psr\Http\Message\ResponseInterface;
11
12			class Formatter implements FormatterInterface
13			{
14			/**
15			* @var Formatter
16			*/
17			private $formatter;
18
19			/**
20			* @param FormatterInterface $formatter
21			*/
22			public function __construct(FormatterInterface $formatter)
23			{
24			$this->formatter = $formatter;
			0 ignored issues – show Documentation Bug introduced 2017-02-08 22:46 UTC by Report Bug Copy Issue Report `$formatter` is of type `object<Http\Message\Formatter>`, but the property `$formatter` was declared to be of type `object<Http\HttplugBundle\Collector\Formatter>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
25			}
26
27			/**
28			* Formats an exception.
29			*
30			* @param Exception $exception
31			*
32			* @return string
33			*/
34			public function formatException(Exception $exception)
35			{
36			if ($exception instanceof HttpException) {
37			return $this->formatter->formatResponse($exception->getResponse());
38			}
39
40			if ($exception instanceof TransferException) {
41			return $exception->getMessage();
42			}
43
44			return sprintf('Unexpected exception of type "%s"', get_class($exception));
45			}
46
47
48			/**
49			* {@inheritdoc}
50			*/
51			public function formatRequest(RequestInterface $request)
52			{
53			return $this->formatter->formatRequest($request);
54			}
55
56			/**
57			* {@inheritdoc}
58			*/
59			public function formatResponse(ResponseInterface $response)
60			{
61			return $this->formatter->formatResponse($response);
62			}
63			}
64

php-http / HttplugBundle

Pull Request — master (#128)

Formatter::formatException() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like