These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
1 | <?php |
||
2 | |||
3 | namespace Http\HttplugBundle\Collector; |
||
4 | |||
5 | use Http\Client\Common\PluginClientFactory; |
||
0 ignored issues
–
show
|
|||
6 | use Http\HttplugBundle\Collector\PluginClientFactory as CollectorPluginClientFactory; |
||
7 | use Symfony\Component\EventDispatcher\Event; |
||
8 | use Symfony\Component\EventDispatcher\EventSubscriberInterface; |
||
9 | |||
10 | /** |
||
11 | * This subscriber ensures that every PluginClient created when using Http\Client\Common\PluginClientFactory without |
||
12 | * using the Symfony dependency injection container uses the Http\HttplugBundle\Collector\PluginClientFactory factory |
||
13 | * when profiling is enabled. This allows 0 config profiling of third party libraries which use HTTPlug. |
||
14 | * |
||
15 | * @author Fabien Bourigault <[email protected]> |
||
16 | * |
||
17 | * @internal |
||
18 | */ |
||
19 | final class PluginClientFactoryListener implements EventSubscriberInterface |
||
20 | { |
||
21 | /** |
||
22 | * @var CollectorPluginClientFactory |
||
23 | */ |
||
24 | private $factory; |
||
25 | |||
26 | /** |
||
27 | * @param CollectorPluginClientFactory $factory |
||
28 | */ |
||
29 | 5 | public function __construct(CollectorPluginClientFactory $factory) |
|
30 | { |
||
31 | 5 | $this->factory = $factory; |
|
32 | 5 | } |
|
33 | |||
34 | /** |
||
35 | * Make sure to profile clients created using PluginClientFactory. |
||
36 | * |
||
37 | * @param Event $e |
||
38 | */ |
||
39 | 5 | public function onEvent(Event $e) |
|
0 ignored issues
–
show
|
|||
40 | { |
||
41 | 5 | PluginClientFactory::setFactory([$this->factory, 'createClient']); |
|
42 | 5 | } |
|
43 | |||
44 | /** |
||
45 | * {@inheritdoc} |
||
46 | */ |
||
47 | 5 | View Code Duplication | public static function getSubscribedEvents() |
0 ignored issues
–
show
This method seems to be duplicated in your project.
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository.
Loading history...
|
|||
48 | { |
||
49 | return [ |
||
50 | 5 | 'kernel.request' => ['onEvent', 1024], |
|
51 | 5 | 'console.command' => ['onEvent', 1024], |
|
52 | 5 | ]; |
|
53 | } |
||
54 | } |
||
55 |
Let’s assume that you have a directory layout like this:
and let’s assume the following content of
Bar.php
:If both files
OtherDir/Foo.php
andSomeDir/Foo.php
are loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php
However, as
OtherDir/Foo.php
does not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php
, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: