Configuration::configureClientPlugins() - Code Metrics - Inspection of "[WIP] Allow to configure plugins specifically for..." - php-http/HttplugBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#112)

by David

created 2016-08-12 12:42 UTC

Configuration::configureClientPlugins() B

↳ Parent: Configuration

Complexity

Conditions	6
Paths	1

Size

Total Lines	118
Code Lines	102

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	102
CRAP Score	6

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	118
ccs	102
cts	102
cp	1
rs	8.1463
cc	6
eloc	102
nc	1
nop	1
crap	6

How to fix Long Method

<?php

namespace Http\HttplugBundle\DependencyInjection;

use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
use Symfony\Component\Config\Definition\Builder\NodeDefinition;
use Symfony\Component\Config\Definition\Builder\TreeBuilder;
use Symfony\Component\Config\Definition\ConfigurationInterface;
use Symfony\Component\Config\Definition\Exception\InvalidConfigurationException;

/**
 * This class contains the configuration information for the bundle.
 *
 * This information is solely responsible for how the different configuration
 * sections are normalized, and merged.
 *
 * @author David Buchmann <[email protected]>
 * @author Tobias Nyholm <[email protected]>
 */
class Configuration implements ConfigurationInterface
{
    /**
     * Whether to use the debug mode.
     *
     * @see https://github.com/doctrine/DoctrineBundle/blob/v1.5.2/DependencyInjection/Configuration.php#L31-L41
     *
     * @var bool
     */
    private $debug;

    /**
     * @param bool $debug
     */
    public function __construct($debug)
    {
        $this->debug = (bool) $debug;
    }

    /**
     * {@inheritdoc}
     */
    public function getConfigTreeBuilder()
    {
        $treeBuilder = new TreeBuilder();
        $rootNode = $treeBuilder->root('httplug');

        $this->configureClients($rootNode);
        $this->configureSharedPlugins($rootNode);

        $rootNode
            ->validate()
                ->ifTrue(function ($v) {
                    return !empty($v['classes']['client'])
                        || !empty($v['classes']['message_factory'])
                        || !empty($v['classes']['uri_factory'])
                        || !empty($v['classes']['stream_factory']);
                })
                ->then(function ($v) {
                    foreach ($v['classes'] as $key => $class) {
                        if (null !== $class && !class_exists($class)) {
                            throw new InvalidConfigurationException(sprintf(
                                'Class %s specified for httplug.classes.%s does not exist.',
                                $class,
                                $key
                            ));
                        }
                    }

                    return $v;
                })
            ->end()
            ->beforeNormalization()
                ->ifTrue(function ($v) {
                    return is_array($v) && array_key_exists('toolbar', $v) && is_array($v['toolbar']);
                })
                ->then(function ($v) {
                    if (array_key_exists('profiling', $v)) {
                        throw new InvalidConfigurationException('Can\'t configure both "toolbar" and "profiling" section. The "toolbar" config is deprecated as of version 1.3.0, please only use "profiling".');
                    }

                    @trigger_error('"httplug.toolbar" config is deprecated since version 1.3 and will be removed in 2.0. Use "httplug.profiling" instead.', E_USER_DEPRECATED);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

                    if (array_key_exists('enabled', $v['toolbar']) && 'auto' === $v['toolbar']['enabled']) {
                        @trigger_error('"auto" value in "httplug.toolbar" config is deprecated since version 1.3 and will be removed in 2.0. Use a boolean value instead.', E_USER_DEPRECATED);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
                        $v['toolbar']['enabled'] = $this->debug;
                    }

                    $v['profiling'] = $v['toolbar'];

                    unset($v['toolbar']);

                    return $v;
                })
            ->end()
            ->fixXmlConfig('client')
            ->children()
                ->arrayNode('main_alias')
                    ->addDefaultsIfNotSet()
                    ->info('Configure which service the main alias point to.')
                    ->children()
                        ->scalarNode('client')->defaultValue('httplug.client.default')->end()
                        ->scalarNode('message_factory')->defaultValue('httplug.message_factory.default')->end()
                        ->scalarNode('uri_factory')->defaultValue('httplug.uri_factory.default')->end()
                        ->scalarNode('stream_factory')->defaultValue('httplug.stream_factory.default')->end()
                    ->end()
                ->end()
                ->arrayNode('classes')
                    ->addDefaultsIfNotSet()
                    ->info('Overwrite a service class instead of using the discovery mechanism.')
                    ->children()
                        ->scalarNode('client')->defaultNull()->end()
                        ->scalarNode('message_factory')->defaultNull()->end()
                        ->scalarNode('uri_factory')->defaultNull()->end()
                        ->scalarNode('stream_factory')->defaultNull()->end()
                    ->end()
                ->end()
                ->arrayNode('profiling')
                    ->addDefaultsIfNotSet()
                    ->treatFalseLike(['enabled' => false])
                    ->treatTrueLike(['enabled' => true])
                    ->treatNullLike(['enabled' => $this->debug])
                    ->info('Extend the debug profiler with information about requests.')
                    ->children()
                        ->booleanNode('enabled')
                            ->info('Turn the toolbar on or off. Defaults to kernel debug mode.')
                            ->defaultValue($this->debug)
                        ->end()
                        ->scalarNode('formatter')->defaultNull()->end()
                        ->integerNode('captured_body_length')
                            ->defaultValue(0)
                            ->info('Limit long HTTP message bodies to x characters. If set to 0 we do not read the message body. Only available with the default formatter (FullHttpMessageFormatter).')
                        ->end()
                    ->end()
                ->end()
                ->arrayNode('discovery')
                    ->addDefaultsIfNotSet()
                    ->info('Control what clients should be found by the discovery.')
                    ->children()
                        ->scalarNode('client')
                            ->defaultValue('auto')
                            ->info('Set to "auto" to see auto discovered client in the web profiler. If provided a service id for a client then this client will be found by auto discovery.')
                        ->end()
                        ->scalarNode('async_client')
                            ->defaultNull()
                            ->info('Set to "auto" to see auto discovered client in the web profiler. If provided a service id for a client then this client will be found by auto discovery.')
                        ->end()
                    ->end()
                ->end()
            ->end();

        return $treeBuilder;
    }

    private function configureClients(ArrayNodeDefinition $root)
    {
        $pluginNode = $root->children()
            ->arrayNode('clients')
                ->validate()
                    ->ifTrue(function ($clients) {
                        foreach ($clients as $name => $config) {
                            // Make sure we only allow one of these to be true
                            return (bool) $config['flexible_client'] + (bool) $config['http_methods_client'] + (bool) $config['batch_client'] >= 2;
                        }

                        return false;
                    })
                    ->thenInvalid('A http client can\'t be decorated with both FlexibleHttpClient and HttpMethodsClient. Only one of the following options can be true. ("flexible_client", "http_methods_client")')->end()
                ->useAttributeAsKey('name')
                ->prototype('array')
                ->fixXmlConfig('plugin')
                ->children()
                    ->scalarNode('factory')
                        ->isRequired()
                        ->cannotBeEmpty()
                        ->info('The service id of a factory to use when creating the adapter.')
                    ->end()
                    ->booleanNode('flexible_client')
                        ->defaultFalse()
                        ->info('Set to true to get the client wrapped in a FlexibleHttpClient which emulates async or sync behavior.')
                    ->end()
                    ->booleanNode('http_methods_client')
                        ->defaultFalse()
                        ->info('Set to true to get the client wrapped in a HttpMethodsClient which emulates provides functions for HTTP verbs.')
                    ->end()
                    ->booleanNode('batch_client')
                        ->defaultFalse()
                        ->info('Set to true to get the client wrapped in a BatchClient which allows you to send multiple request at the same time.')
                    ->end()
                    ->variableNode('config')->defaultValue([])->end()
                    ->arrayNode('plugins')
                        ->info('A list of plugin service ids and client specific plugin definitions. The order is important.')
                        ->prototype('array')
        ;

        $this->configureClientPlugins($pluginNode);
    }

    /**
     * @param ArrayNodeDefinition $root
     */
    private function configureSharedPlugins(ArrayNodeDefinition $root)
    {
        $pluginsNode = $root
            ->children()
                ->arrayNode('plugins')
                ->addDefaultsIfNotSet()
        ;
        $this->addSharedPluginNodes($pluginsNode);
    }

    /**
     * Configure plugins node of a client.
     *
     * @param ArrayNodeDefinition $pluginNode The node to add plugin definitions to.
     */
    private function configureClientPlugins(ArrayNodeDefinition $pluginNode)
    {
        $pluginNode
            // support having just a service id in the list
            ->beforeNormalization()
                ->always(function ($plugin) {
                    if (is_string($plugin)) {
                        return [
                            'reference' => [
                                'enabled' => true,
                                'id' => $plugin,
                            ],
                        ];
                    }

                    return $plugin;
                })
            ->end()

            ->validate()
                ->always(function ($plugins) {
                    if (isset($plugins['authentication']) && !count($plugins['authentication'])) {
                        unset($plugins['authentication']);
                    }
                    foreach ($plugins as $name => $definition) {
                        if (!$definition['enabled']) {
                            unset($plugins[$name]);
                        }
                    }

                    return $plugins;
                })
            ->end()
        ;
        $this->addSharedPluginNodes($pluginNode, true);

        $pluginNode
            ->children()
                ->arrayNode('reference')
                    ->canBeEnabled()
                    ->info('Reference to a plugin service')
                    ->children()
                        ->scalarNode('id')
                            ->info('Service id of a plugin')
                            ->isRequired()
                            ->cannotBeEmpty()
                        ->end()
                    ->end()
                ->end()
                ->arrayNode('add_host')
                    ->canBeEnabled()
                    ->addDefaultsIfNotSet()
                    ->info('Configure the AddHostPlugin for this client.')
                    ->children()
                        ->scalarNode('host')
                            ->info('Host name including protocol and optionally the port number, e.g. https://api.local:8000')
                            ->isRequired()
                            ->cannotBeEmpty()
                        ->end()
                        ->scalarNode('replace')
                            ->info('Whether to replace the host if request already specifies it')
                            ->defaultValue(false)
                        ->end()
                    ->end()
                ->end()
                ->arrayNode('header_append')
                    ->canBeEnabled()
                    ->info('Append headers to the request. If the header already exists the value will be appended to the current value.')
                    ->fixXmlConfig('header')
                    ->children()
                        ->arrayNode('headers')
                            ->info('Keys are the header names, values the header values')
                            ->normalizeKeys(false)
                            ->useAttributeAsKey('name')
                            ->prototype('scalar')->end()
                        ->end()
                    ->end()
                ->end()
                ->arrayNode('header_defaults')
                    ->canBeEnabled()
                    ->info('Set header to default value if it does not exist.')
                    ->fixXmlConfig('header')
                    ->children()
                        ->arrayNode('headers')
                            ->info('Keys are the header names, values the header values')
                            ->normalizeKeys(false)
                            ->useAttributeAsKey('name')
                            ->prototype('scalar')->end()
                        ->end()
                    ->end()
                ->end()
                ->arrayNode('header_set')
                    ->canBeEnabled()
                    ->info('Set headers to requests. If the header does not exist it wil be set, if the header already exists it will be replaced.')
                    ->fixXmlConfig('header')
                    ->children()
                        ->arrayNode('headers')
                            ->info('Keys are the header names, values the header values')
                            ->normalizeKeys(false)
                            ->useAttributeAsKey('name')
                            ->prototype('scalar')->end()
                        ->end()
                    ->end()
                ->end()
                ->arrayNode('header_remove')
                    ->canBeEnabled()
                    ->info('Remove headers from requests.')
                    ->fixXmlConfig('header')
                    ->children()
                        ->arrayNode('headers')
                            ->info('List of header names to remove')
                            ->prototype('scalar')->end()
                        ->end()
                    ->end()
                ->end()
            ->end()
        ->end();
    }

    /**
     * Add the definitions for shared plugin configurations.
     *
     * @param ArrayNodeDefinition $pluginNode The node to add to.
     * @param bool                $disableAll Some shared plugins are enabled by default. On the client, all are disabled by default.
     */
    private function addSharedPluginNodes(ArrayNodeDefinition $pluginNode, $disableAll = false)
    {
        $children = $pluginNode->children();

        $children->append($this->createAuthenticationPluginNode());

        $children->arrayNode('cache')
            ->canBeEnabled()
            ->addDefaultsIfNotSet()
                ->children()
                    ->scalarNode('cache_pool')
                        ->info('This must be a service id to a service implementing Psr\Cache\CacheItemPoolInterface')
                        ->isRequired()
                        ->cannotBeEmpty()
                    ->end()
                    ->scalarNode('stream_factory')
                        ->info('This must be a service id to a service implementing Http\Message\StreamFactory')
                        ->defaultValue('httplug.stream_factory')
                        ->cannotBeEmpty()
                    ->end()
                    ->arrayNode('config')
                        ->addDefaultsIfNotSet()
                        ->children()
                            ->scalarNode('default_ttl')->defaultNull()->end()
                            ->scalarNode('respect_cache_headers')->defaultTrue()->end()
                        ->end()
                    ->end()
                ->end()
            ->end();
        // End cache plugin

        $children->arrayNode('cookie')
            ->canBeEnabled()
                ->children()
                    ->scalarNode('cookie_jar')
                        ->info('This must be a service id to a service implementing Http\Message\CookieJar')
                        ->isRequired()
                        ->cannotBeEmpty()
                    ->end()
                ->end()
            ->end();
        // End cookie plugin

        $decoder = $children->arrayNode('decoder');
        $disableAll ? $decoder->canBeEnabled() : $decoder->canBeDisabled();
        $decoder->addDefaultsIfNotSet()
            ->children()
                ->scalarNode('use_content_encoding')->defaultTrue()->end()
            ->end()
        ->end();
        // End decoder plugin

        $children->arrayNode('history')
            ->canBeEnabled()
                ->children()
                    ->scalarNode('journal')
                        ->info('This must be a service id to a service implementing Http\Client\Plugin\Journal')
                        ->isRequired()
                        ->cannotBeEmpty()
                    ->end()
                ->end()
            ->end();
        // End history plugin

        $logger = $children->arrayNode('logger');
        $disableAll ? $logger->canBeEnabled() : $logger->canBeDisabled();
        $logger->addDefaultsIfNotSet()
            ->children()
                ->scalarNode('logger')
                    ->info('This must be a service id to a service implementing Psr\Log\LoggerInterface')
                    ->defaultValue('logger')
                    ->cannotBeEmpty()
                ->end()
                ->scalarNode('formatter')
                    ->info('This must be a service id to a service implementing Http\Message\Formatter')
                    ->defaultNull()
                ->end()
            ->end()
        ->end();
        // End logger plugin

        $redirect = $children->arrayNode('redirect');
        $disableAll ? $redirect->canBeEnabled() : $redirect->canBeDisabled();
        $redirect->addDefaultsIfNotSet()
            ->children()
                ->scalarNode('preserve_header')->defaultTrue()->end()
                ->scalarNode('use_default_for_multiple')->defaultTrue()->end()
            ->end()
        ->end();
        // End redirect plugin

        $retry = $children->arrayNode('retry');
        $disableAll ? $retry->canBeEnabled() : $retry->canBeDisabled();
        $retry->addDefaultsIfNotSet()
            ->children()
                ->scalarNode('retry')->defaultValue(1)->end() // TODO: should be called retries for consistency with the class
            ->end()
        ->end();
        // End retry plugin

        $stopwatch = $children->arrayNode('stopwatch');
        $disableAll ? $stopwatch->canBeEnabled() : $stopwatch->canBeDisabled();
        $stopwatch->addDefaultsIfNotSet()
            ->children()
                ->scalarNode('stopwatch')
                    ->info('This must be a service id to a service extending Symfony\Component\Stopwatch\Stopwatch')
                    ->defaultValue('debug.stopwatch')
                    ->cannotBeEmpty()
                ->end()
            ->end()
        ->end();
        // End stopwatch plugin
    }

    /**
     * Create configuration for authentication plugin.
     *
     * @return NodeDefinition Definition for the authentication node in the plugins list.
     */
    private function createAuthenticationPluginNode()
    {
        $builder = new TreeBuilder();
        $node = $builder->root('authentication');
        $node
            ->useAttributeAsKey('name')
            ->prototype('array')
                ->validate()
                    ->always()
                    ->then(function ($config) {
                        switch ($config['type']) {
                            case 'basic':
                                $this->validateAuthenticationType(['username', 'password'], $config, 'basic');
                                break;
                            case 'bearer':
                                $this->validateAuthenticationType(['token'], $config, 'bearer');
                                break;
                            case 'service':
                                $this->validateAuthenticationType(['service'], $config, 'service');
                                break;
                            case 'wsse':
                                $this->validateAuthenticationType(['username', 'password'], $config, 'wsse');
                                break;
                        }

                        return $config;
                    })
                ->end()
                ->children()
                    ->enumNode('type')
                        ->values(['basic', 'bearer', 'wsse', 'service'])
                        ->isRequired()
                        ->cannotBeEmpty()
                    ->end()
                    ->scalarNode('username')->end()
                    ->scalarNode('password')->end()
                    ->scalarNode('token')->end()
                    ->scalarNode('service')->end()
                    ->end()
                ->end()
            ->end(); // End authentication plugin

        return $node;
    }

    /**
     * Validate that the configuration fragment has the specified keys and none other.
     *
     * @param array  $expected Fields that must exist
     * @param array  $actual   Actual configuration hashmap
     * @param string $authName Name of authentication method for error messages
     *
     * @throws InvalidConfigurationException If $actual does not have exactly the keys specified in $expected (plus 'type')
     */
    private function validateAuthenticationType(array $expected, array $actual, $authName)
    {
        unset($actual['type']);
        $actual = array_keys($actual);
        sort($actual);
        sort($expected);

        if ($expected === $actual) {
            return;
        }

        throw new InvalidConfigurationException(sprintf(
            'Authentication "%s" requires %s but got %s',
            $authName,
            implode(', ', $expected),
            implode(', ', $actual)
        ));
    }
}


1		<?php
2
3		namespace Http\HttplugBundle\DependencyInjection;
4
5		use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
6		use Symfony\Component\Config\Definition\Builder\NodeDefinition;
7		use Symfony\Component\Config\Definition\Builder\TreeBuilder;
8		use Symfony\Component\Config\Definition\ConfigurationInterface;
9		use Symfony\Component\Config\Definition\Exception\InvalidConfigurationException;
10
11		/**
12		* This class contains the configuration information for the bundle.
13		*
14		* This information is solely responsible for how the different configuration
15		* sections are normalized, and merged.
16		*
17		* @author David Buchmann <[email protected]>
18		* @author Tobias Nyholm <[email protected]>
19		*/
20		class Configuration implements ConfigurationInterface
21		{
22		/**
23		* Whether to use the debug mode.
24		*
25		* @see https://github.com/doctrine/DoctrineBundle/blob/v1.5.2/DependencyInjection/Configuration.php#L31-L41
26		*
27		* @var bool
28		*/
29		private $debug;
30
31		/**
32		* @param bool $debug
33		*/
34	14	public function __construct($debug)
35		{
36	14	$this->debug = (bool) $debug;
37	14	}
38
39		/**
40		* {@inheritdoc}
41		*/
42	14	public function getConfigTreeBuilder()
43		{
44	14	$treeBuilder = new TreeBuilder();
45	14	$rootNode = $treeBuilder->root('httplug');
46
47	14	$this->configureClients($rootNode);
48	14	$this->configureSharedPlugins($rootNode);
49
50		$rootNode
51	14	->validate()
52		->ifTrue(function ($v) {
53	12	return !empty($v['classes']['client'])
54	12	\|\| !empty($v['classes']['message_factory'])
55	9	\|\| !empty($v['classes']['uri_factory'])
56	12	\|\| !empty($v['classes']['stream_factory']);
57	14	})
58		->then(function ($v) {
59	3	foreach ($v['classes'] as $key => $class) {
60	3	if (null !== $class && !class_exists($class)) {
61	1	throw new InvalidConfigurationException(sprintf(
62	1	'Class %s specified for httplug.classes.%s does not exist.',
63	1	$class,
64		$key
65	1	));
66		}
67	2	}
68
69	2	return $v;
70	14	})
71	14	->end()
72	14	->beforeNormalization()
73		->ifTrue(function ($v) {
74	14	return is_array($v) && array_key_exists('toolbar', $v) && is_array($v['toolbar']);
75	14	})
76		->then(function ($v) {
77	4	if (array_key_exists('profiling', $v)) {
78	1	throw new InvalidConfigurationException('Can\'t configure both "toolbar" and "profiling" section. The "toolbar" config is deprecated as of version 1.3.0, please only use "profiling".');
79		}
80
81	3	@trigger_error('"httplug.toolbar" config is deprecated since version 1.3 and will be removed in 2.0. Use "httplug.profiling" instead.', E_USER_DEPRECATED);
		0 ignored issues – show Security Best Practice introduced 2016-07-28 13:21 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
82
83	3	if (array_key_exists('enabled', $v['toolbar']) && 'auto' === $v['toolbar']['enabled']) {
84	1	@trigger_error('"auto" value in "httplug.toolbar" config is deprecated since version 1.3 and will be removed in 2.0. Use a boolean value instead.', E_USER_DEPRECATED);
		1 ignored issue – show Security Best Practice introduced 2016-07-28 13:21 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
85	1	$v['toolbar']['enabled'] = $this->debug;
86	1	}
87
88	3	$v['profiling'] = $v['toolbar'];
89
90	3	unset($v['toolbar']);
91
92	3	return $v;
93	14	})
94	14	->end()
95	14	->fixXmlConfig('client')
96	14	->children()
97	14	->arrayNode('main_alias')
98	14	->addDefaultsIfNotSet()
99	14	->info('Configure which service the main alias point to.')
100	14	->children()
101	14	->scalarNode('client')->defaultValue('httplug.client.default')->end()
102	14	->scalarNode('message_factory')->defaultValue('httplug.message_factory.default')->end()
103	14	->scalarNode('uri_factory')->defaultValue('httplug.uri_factory.default')->end()
104	14	->scalarNode('stream_factory')->defaultValue('httplug.stream_factory.default')->end()
105	14	->end()
106	14	->end()
107	14	->arrayNode('classes')
108	14	->addDefaultsIfNotSet()
109	14	->info('Overwrite a service class instead of using the discovery mechanism.')
110	14	->children()
111	14	->scalarNode('client')->defaultNull()->end()
112	14	->scalarNode('message_factory')->defaultNull()->end()
113	14	->scalarNode('uri_factory')->defaultNull()->end()
114	14	->scalarNode('stream_factory')->defaultNull()->end()
115	14	->end()
116	14	->end()
117	14	->arrayNode('profiling')
118	14	->addDefaultsIfNotSet()
119	14	->treatFalseLike(['enabled' => false])
120	14	->treatTrueLike(['enabled' => true])
121	14	->treatNullLike(['enabled' => $this->debug])
122	14	->info('Extend the debug profiler with information about requests.')
123	14	->children()
124	14	->booleanNode('enabled')
125	14	->info('Turn the toolbar on or off. Defaults to kernel debug mode.')
126	14	->defaultValue($this->debug)
127	14	->end()
128	14	->scalarNode('formatter')->defaultNull()->end()
129	14	->integerNode('captured_body_length')
130	14	->defaultValue(0)
131	14	->info('Limit long HTTP message bodies to x characters. If set to 0 we do not read the message body. Only available with the default formatter (FullHttpMessageFormatter).')
132	14	->end()
133	14	->end()
134	14	->end()
135	14	->arrayNode('discovery')
136	14	->addDefaultsIfNotSet()
137	14	->info('Control what clients should be found by the discovery.')
138	14	->children()
139	14	->scalarNode('client')
140	14	->defaultValue('auto')
141	14	->info('Set to "auto" to see auto discovered client in the web profiler. If provided a service id for a client then this client will be found by auto discovery.')
142	14	->end()
143	14	->scalarNode('async_client')
144	14	->defaultNull()
145	14	->info('Set to "auto" to see auto discovered client in the web profiler. If provided a service id for a client then this client will be found by auto discovery.')
146	14	->end()
147	14	->end()
148	14	->end()
149	14	->end();
150
151	14	return $treeBuilder;
152		}
153
154	14	private function configureClients(ArrayNodeDefinition $root)
155		{
156	14	$pluginNode = $root->children()
157	14	->arrayNode('clients')
158	14	->validate()
159		->ifTrue(function ($clients) {
160	5	foreach ($clients as $name => $config) {
161		// Make sure we only allow one of these to be true
162	5	return (bool) $config['flexible_client'] + (bool) $config['http_methods_client'] + (bool) $config['batch_client'] >= 2;
163		}
164
165		return false;
166	14	})
167	14	->thenInvalid('A http client can\'t be decorated with both FlexibleHttpClient and HttpMethodsClient. Only one of the following options can be true. ("flexible_client", "http_methods_client")')->end()
168	14	->useAttributeAsKey('name')
169	14	->prototype('array')
170	14	->fixXmlConfig('plugin')
171	14	->children()
172	14	->scalarNode('factory')
173	14	->isRequired()
174	14	->cannotBeEmpty()
175	14	->info('The service id of a factory to use when creating the adapter.')
176	14	->end()
177	14	->booleanNode('flexible_client')
178	14	->defaultFalse()
179	14	->info('Set to true to get the client wrapped in a FlexibleHttpClient which emulates async or sync behavior.')
180	14	->end()
181	14	->booleanNode('http_methods_client')
182	14	->defaultFalse()
183	14	->info('Set to true to get the client wrapped in a HttpMethodsClient which emulates provides functions for HTTP verbs.')
184	14	->end()
185	14	->booleanNode('batch_client')
186	14	->defaultFalse()
187	14	->info('Set to true to get the client wrapped in a BatchClient which allows you to send multiple request at the same time.')
188	14	->end()
189	14	->variableNode('config')->defaultValue([])->end()
190	14	->arrayNode('plugins')
191	14	->info('A list of plugin service ids and client specific plugin definitions. The order is important.')
192	14	->prototype('array')
193	14	;
194	14
195	14	$this->configureClientPlugins($pluginNode);
196		}
197
198		/**
199		* @param ArrayNodeDefinition $root
200	14	*/
201		private function configureSharedPlugins(ArrayNodeDefinition $root)
202	14	{
203	14	$pluginsNode = $root
204	14	->children()
205	14	->arrayNode('plugins')
206	14	->addDefaultsIfNotSet()
207		;
208	14	$this->addSharedPluginNodes($pluginsNode);
209	14	}
210	14
211	14	/**
212	14	* Configure plugins node of a client.
213	14	*
214	14	* @param ArrayNodeDefinition $pluginNode The node to add plugin definitions to.
215	14	*/
216	14	private function configureClientPlugins(ArrayNodeDefinition $pluginNode)
217	14	{
218	14	$pluginNode
219	14	// support having just a service id in the list
220	14	->beforeNormalization()
221	14	->always(function ($plugin) {
222	14	if (is_string($plugin)) {
223	14	return [
224	14	'reference' => [
225	14	'enabled' => true,
226	14	'id' => $plugin,
227	14	],
228	14	];
229	14	}
230	14
231		return $plugin;
232	14	})
233	14	->end()
234	14
235	14	->validate()
236	14	->always(function ($plugins) {
237	14	if (isset($plugins['authentication']) && !count($plugins['authentication'])) {
238	14	unset($plugins['authentication']);
239	14	}
240	14	foreach ($plugins as $name => $definition) {
241	14	if (!$definition['enabled']) {
242		unset($plugins[$name]);
243	14	}
244	14	}
245	14
246	14	return $plugins;
247	14	})
248	14	->end()
249	14	;
250		$this->addSharedPluginNodes($pluginNode, true);
251	14
252	14	$pluginNode
253	14	->children()
254	14	->arrayNode('reference')
255	14	->canBeEnabled()
256	14	->info('Reference to a plugin service')
257	14	->children()
258	14	->scalarNode('id')
259	14	->info('Service id of a plugin')
260	14	->isRequired()
261		->cannotBeEmpty()
262	14	->end()
263	14	->end()
264	14	->end()
265	14	->arrayNode('add_host')
266	14	->canBeEnabled()
267	14	->addDefaultsIfNotSet()
268	14	->info('Configure the AddHostPlugin for this client.')
269	14	->children()
270	14	->scalarNode('host')
271	14	->info('Host name including protocol and optionally the port number, e.g. https://api.local:8000')
272	14	->isRequired()
273	14	->cannotBeEmpty()
274	14	->end()
275	14	->scalarNode('replace')
276	14	->info('Whether to replace the host if request already specifies it')
277		->defaultValue(false)
278	14	->end()
279	14	->end()
280	14	->end()
281	14	->arrayNode('header_append')
282	14	->canBeEnabled()
283	14	->info('Append headers to the request. If the header already exists the value will be appended to the current value.')
284	14	->fixXmlConfig('header')
285	14	->children()
286		->arrayNode('headers')
287	14	->info('Keys are the header names, values the header values')
288	14	->normalizeKeys(false)
289	14	->useAttributeAsKey('name')
290	14	->prototype('scalar')->end()
291	14	->end()
292	14	->end()
293	14	->end()
294		->arrayNode('header_defaults')
295	14	->canBeEnabled()
296	14	->info('Set header to default value if it does not exist.')
297	14	->fixXmlConfig('header')
298	14	->children()
299	14	->arrayNode('headers')
300	14	->info('Keys are the header names, values the header values')
301	14	->normalizeKeys(false)
302	14	->useAttributeAsKey('name')
303	14	->prototype('scalar')->end()
304	14	->end()
305	14	->end()
306		->end()
307	14	->arrayNode('header_set')
308	14	->canBeEnabled()
309	14	->info('Set headers to requests. If the header does not exist it wil be set, if the header already exists it will be replaced.')
310	14	->fixXmlConfig('header')
311		->children()
312		->arrayNode('headers')
313		->info('Keys are the header names, values the header values')
314		->normalizeKeys(false)
315		->useAttributeAsKey('name')
316		->prototype('scalar')->end()
317	14	->end()
318		->end()
319	14	->end()
320	14	->arrayNode('header_remove')
321		->canBeEnabled()
322	14	->info('Remove headers from requests.')
323	14	->fixXmlConfig('header')
324	14	->children()
325	14	->arrayNode('headers')
326	14	->info('List of header names to remove')
327	2	->prototype('scalar')->end()
328	2	->end()
329	1	->end()
330	1	->end()
331	2	->end()
332	1	->end();
333	1	}
334	2
335	2	/**
336	1	* Add the definitions for shared plugin configurations.
337	1	*
338	1	* @param ArrayNodeDefinition $pluginNode The node to add to.
339	1	* @param bool $disableAll Some shared plugins are enabled by default. On the client, all are disabled by default.
340	1	*/
341		private function addSharedPluginNodes(ArrayNodeDefinition $pluginNode, $disableAll = false)
342	1	{
343	14	$children = $pluginNode->children();
344	14
345	14	$children->append($this->createAuthenticationPluginNode());
346	14
347	14	$children->arrayNode('cache')
348	14	->canBeEnabled()
349	14	->addDefaultsIfNotSet()
350	14	->children()
351	14	->scalarNode('cache_pool')
352	14	->info('This must be a service id to a service implementing Psr\Cache\CacheItemPoolInterface')
353	14	->isRequired()
354	14	->cannotBeEmpty()
355	14	->end()
356	14	->scalarNode('stream_factory')
357	14	->info('This must be a service id to a service implementing Http\Message\StreamFactory')
358		->defaultValue('httplug.stream_factory')
359	14	->cannotBeEmpty()
360		->end()
361		->arrayNode('config')
362		->addDefaultsIfNotSet()
363		->children()
364		->scalarNode('default_ttl')->defaultNull()->end()
365		->scalarNode('respect_cache_headers')->defaultTrue()->end()
366		->end()
367		->end()
368		->end()
369		->end();
370		// End cache plugin
371	2
372		$children->arrayNode('cookie')
373	2	->canBeEnabled()
374	2	->children()
375	2	->scalarNode('cookie_jar')
376	2	->info('This must be a service id to a service implementing Http\Message\CookieJar')
377		->isRequired()
378	2	->cannotBeEmpty()
379	1	->end()
380		->end()
381		->end();
382	1	// End cookie plugin
383	1
384	1	$decoder = $children->arrayNode('decoder');
385	1	$disableAll ? $decoder->canBeEnabled() : $decoder->canBeDisabled();
386	1	$decoder->addDefaultsIfNotSet()
387	1	->children()
388		->scalarNode('use_content_encoding')->defaultTrue()->end()
389		->end()
390		->end();
391		// End decoder plugin
392
393		$children->arrayNode('history')
394		->canBeEnabled()
395		->children()
396		->scalarNode('journal')
397		->info('This must be a service id to a service implementing Http\Client\Plugin\Journal')
398		->isRequired()
399		->cannotBeEmpty()
400		->end()
401		->end()
402		->end();
403		// End history plugin
404
405		$logger = $children->arrayNode('logger');
406		$disableAll ? $logger->canBeEnabled() : $logger->canBeDisabled();
407		$logger->addDefaultsIfNotSet()
408		->children()
409		->scalarNode('logger')
410		->info('This must be a service id to a service implementing Psr\Log\LoggerInterface')
411		->defaultValue('logger')
412		->cannotBeEmpty()
413		->end()
414		->scalarNode('formatter')
415		->info('This must be a service id to a service implementing Http\Message\Formatter')
416		->defaultNull()
417		->end()
418		->end()
419		->end();
420		// End logger plugin
421
422		$redirect = $children->arrayNode('redirect');
423		$disableAll ? $redirect->canBeEnabled() : $redirect->canBeDisabled();
424		$redirect->addDefaultsIfNotSet()
425		->children()
426		->scalarNode('preserve_header')->defaultTrue()->end()
427		->scalarNode('use_default_for_multiple')->defaultTrue()->end()
428		->end()
429		->end();
430		// End redirect plugin
431
432		$retry = $children->arrayNode('retry');
433		$disableAll ? $retry->canBeEnabled() : $retry->canBeDisabled();
434		$retry->addDefaultsIfNotSet()
435		->children()
436		->scalarNode('retry')->defaultValue(1)->end() // TODO: should be called retries for consistency with the class
437		->end()
438		->end();
439		// End retry plugin
440
441		$stopwatch = $children->arrayNode('stopwatch');
442		$disableAll ? $stopwatch->canBeEnabled() : $stopwatch->canBeDisabled();
443		$stopwatch->addDefaultsIfNotSet()
444		->children()
445		->scalarNode('stopwatch')
446		->info('This must be a service id to a service extending Symfony\Component\Stopwatch\Stopwatch')
447		->defaultValue('debug.stopwatch')
448		->cannotBeEmpty()
449		->end()
450		->end()
451		->end();
452		// End stopwatch plugin
453		}
454
455		/**
456		* Create configuration for authentication plugin.
457		*
458		* @return NodeDefinition Definition for the authentication node in the plugins list.
459		*/
460		private function createAuthenticationPluginNode()
461		{
462		$builder = new TreeBuilder();
463		$node = $builder->root('authentication');
464		$node
465		->useAttributeAsKey('name')
466		->prototype('array')
467		->validate()
468		->always()
469		->then(function ($config) {
470		switch ($config['type']) {
471		case 'basic':
472		$this->validateAuthenticationType(['username', 'password'], $config, 'basic');
473		break;
474		case 'bearer':
475		$this->validateAuthenticationType(['token'], $config, 'bearer');
476		break;
477		case 'service':
478		$this->validateAuthenticationType(['service'], $config, 'service');
479		break;
480		case 'wsse':
481		$this->validateAuthenticationType(['username', 'password'], $config, 'wsse');
482		break;
483		}
484
485		return $config;
486		})
487		->end()
488		->children()
489		->enumNode('type')
490		->values(['basic', 'bearer', 'wsse', 'service'])
491		->isRequired()
492		->cannotBeEmpty()
493		->end()
494		->scalarNode('username')->end()
495		->scalarNode('password')->end()
496		->scalarNode('token')->end()
497		->scalarNode('service')->end()
498		->end()
499		->end()
500		->end(); // End authentication plugin
501
502		return $node;
503		}
504
505		/**
506		* Validate that the configuration fragment has the specified keys and none other.
507		*
508		* @param array $expected Fields that must exist
509		* @param array $actual Actual configuration hashmap
510		* @param string $authName Name of authentication method for error messages
511		*
512		* @throws InvalidConfigurationException If $actual does not have exactly the keys specified in $expected (plus 'type')
513		*/
514		private function validateAuthenticationType(array $expected, array $actual, $authName)
515		{
516		unset($actual['type']);
517		$actual = array_keys($actual);
518		sort($actual);
519		sort($expected);
520
521		if ($expected === $actual) {
522		return;
523		}
524
525		throw new InvalidConfigurationException(sprintf(
526		'Authentication "%s" requires %s but got %s',
527		$authName,
528		implode(', ', $expected),
529		implode(', ', $actual)
530		));
531		}
532		}
533

php-http / HttplugBundle

Pull Request — master (#112)

Configuration::configureClientPlugins() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like