Http\HttplugBundle\Collector\Collector

Complexity

Total Complexity

10

Size/Duplication

Total Lines	101
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	collect()	0	4	1
A	getName()	0	4	1
A	addStack()	0	4	1
A	getStacks()	0	4	1
A	getCurrentStack()	0	4	1
A	getSuccessfulStacks()	0	6	1
A	getFailedStacks()	0	6	1
A	getClients()	0	4	1
A	getClientStacks()	0	6	1

<?php

namespace Http\HttplugBundle\Collector;

use Exception;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\DataCollector\DataCollector;

class Collector extends DataCollector
{
    /**
     * @var ProfileStack[]
     */
    private $stacks;

    /**
     * @var array
     */
    private $clients;

    /**
     * @param array $clients
     */
    public function __construct(array $clients)
    {
        $this->stacks = [];
        $this->clients = $clients;
    }

    /**
     * {@inheritdoc}
     */
    public function collect(Request $request, Response $response, Exception $exception = null)
    {
        // We do not need to collect any data from the Symfony Request and Response
    }

    /**
     * {@inheritdoc}
     */
    public function getName()
    {
        return 'httplug';
    }

    /**
     * @param ProfileStack $stack
     */
    public function addStack(ProfileStack $stack)
    {
        $this->stacks[] = $stack;
    }

    /**
     * @return ProfileStack[]
     */
    public function getStacks()
    {
        return $this->stacks;
    }

    /**
     * @return ProfileStack
     */
    public function getCurrentStack()
    {
        return end($this->stacks);

The expression end($this->stacks); of type Http\HttplugBundle\Collector\ProfileStack|false adds false to the return on line 68 which is incompatible with the return type documented by Http\HttplugBundle\Collector\Collector::getCurrentStack of type Http\HttplugBundle\Collector\ProfileStack. It seems like you forgot to handle an error condition.

    }

    /**
     * @return ProfileStack[]
     */
    public function getSuccessfulStacks()
    {
        return array_filter($this->stacks, function (ProfileStack $stack) {
            return $stack->isSuccessful();

The method isSuccessful() does not seem to exist on object<Http\HttplugBundle\Collector\ProfileStack>.

        });
    }

    /**
     * @return ProfileStack[]
     */
    public function getFailedStacks()
    {
        return array_filter($this->stacks, function (ProfileStack $stack) {
            return !$stack->isSuccessful();

The method isSuccessful() does not seem to exist on object<Http\HttplugBundle\Collector\ProfileStack>.

        });
    }

    /**
     * @return array
     */
    public function getClients()
    {
        return $this->clients;
    }

    /**
     * @param $client
     *
     * @return ProfileStack[]
     */
    public function getClientStacks($client)
    {
        return array_filter($this->stacks, function (ProfileStack $stack) use ($client) {
           return $stack->getClient() == $client;
        });
    }
}