Complex classes like HttplugExtension often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use HttplugExtension, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
22 | class HttplugExtension extends Extension |
||
23 | { |
||
24 | /** |
||
25 | * {@inheritdoc} |
||
26 | */ |
||
27 | 3 | public function load(array $configs, ContainerBuilder $container) |
|
28 | { |
||
29 | 3 | $configuration = $this->getConfiguration($configs, $container); |
|
30 | 3 | $config = $this->processConfiguration($configuration, $configs); |
|
|
|||
31 | |||
32 | 3 | $loader = new XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config')); |
|
33 | |||
34 | 3 | $loader->load('services.xml'); |
|
35 | 3 | $loader->load('plugins.xml'); |
|
36 | |||
37 | 3 | $enabled = is_bool($config['toolbar']['enabled']) ? $config['toolbar']['enabled'] : $container->hasParameter('kernel.debug') && $container->getParameter('kernel.debug'); |
|
38 | 3 | if ($enabled) { |
|
39 | $loader->load('data-collector.xml'); |
||
40 | $config['_inject_collector_plugin'] = true; |
||
41 | |||
42 | if (!empty($config['toolbar']['formatter'])) { |
||
43 | $container->getDefinition('httplug.collector.message_journal') |
||
44 | ->replaceArgument(0, new Reference($config['toolbar']['formatter'])); |
||
45 | } |
||
46 | } |
||
47 | |||
48 | 3 | foreach ($config['classes'] as $service => $class) { |
|
49 | 3 | if (!empty($class)) { |
|
50 | 1 | $container->register(sprintf('httplug.%s.default', $service), $class); |
|
51 | 1 | } |
|
52 | 3 | } |
|
53 | |||
54 | 3 | foreach ($config['main_alias'] as $type => $id) { |
|
55 | 3 | $container->setAlias(sprintf('httplug.%s', $type), $id); |
|
56 | 3 | } |
|
57 | |||
58 | 3 | $this->configurePlugins($container, $config['plugins']); |
|
59 | 3 | $this->configureClients($container, $config); |
|
60 | 3 | } |
|
61 | |||
62 | /** |
||
63 | * Configure client services. |
||
64 | * |
||
65 | * @param ContainerBuilder $container |
||
66 | * @param array $config |
||
67 | */ |
||
68 | 3 | private function configureClients(ContainerBuilder $container, array $config) |
|
108 | |||
109 | /** |
||
110 | * @param ContainerBuilder $container |
||
111 | * @param array $config |
||
112 | */ |
||
113 | private function configurePlugins(ContainerBuilder $container, array $config) |
||
135 | |||
136 | /** |
||
137 | * @param string $name |
||
138 | * @param Definition $definition |
||
139 | * @param array $config |
||
140 | */ |
||
141 | private function configurePluginByName($name, Definition $definition, array $config) |
||
178 | |||
179 | /** |
||
180 | * @param ContainerBuilder $container |
||
181 | * @param array $config |
||
182 | */ |
||
183 | private function configureAuthentication(ContainerBuilder $container, array $config) |
||
213 | |||
214 | /** |
||
215 | * Resolve the plugin enabled status if it is 'auto'. |
||
216 | * |
||
217 | * Returns false if plugin has no auto status allowed. |
||
218 | * |
||
219 | * @param string $name |
||
220 | * @param array $pluginConfig |
||
221 | * |
||
222 | * @return bool |
||
223 | */ |
||
224 | private function resolvePluginStatus($name, array $pluginConfig) |
||
234 | } |
||
235 |
It seems like the type of the argument is not accepted by the function/method which you are calling.
In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.
We suggest to add an explicit type cast like in the following example: