ProfileClient::sendAsyncRequest() - Code Metrics - Inspection of "add profile client" - php-http/HttplugBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#136)

by Fabien

created 2017-04-03 09:17 UTC

ProfileClient::sendAsyncRequest() A

↳ Parent: ProfileClient

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	0
cts	0
cp	0
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	1
crap	2

<?php

namespace Http\HttplugBundle\Collector;

use Http\Client\Common\FlexibleHttpClient;
use Http\Client\HttpAsyncClient;
use Http\Client\HttpClient;
use Psr\Http\Message\RequestInterface;

/**
 * The ProfileClient decorates any client that implement both HttpClient and HttpAsyncClient interfaces to gather target
 * url and response status code.
 *
 * @author Fabien Bourigault <[email protected]>
 *
 * @internal
 */
class ProfileClient implements HttpClient, HttpAsyncClient
{
    /**
     * @var HttpClient|HttpAsyncClient
     */
    private $client;

    /**
     * @var Collector
     */
    private $collector;

    /**
     * @param HttpClient|HttpAsyncClient $client    The client to profile. Client must implement both HttpClient and
     *                                              HttpAsyncClient interfaces.
     * @param Collector                  $collector
     */
    public function __construct($client, Collector $collector)
    {
        if (!($client instanceof HttpClient && $client instanceof HttpAsyncClient)) {
            throw new \RuntimeException(sprintf(
                '%s first argument must implement %s and %s. Consider using %s.',
                    __METHOD__,
                    HttpClient::class,
                    HttpAsyncClient::class,
                    FlexibleHttpClient::class
            ));
        }
        $this->client = $client;
        $this->collector = $collector;
    }

    /**
     * {@inheritdoc}
     */
    public function sendAsyncRequest(RequestInterface $request)
    {
        $this->collectRequestInformations($request);

        return $this->client->sendAsyncRequest($request);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * {@inheritdoc}
     */
    public function sendRequest(RequestInterface $request)
    {
        $this->collectRequestInformations($request);

        return $this->client->sendRequest($request);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * @param RequestInterface $request
     */
    private function collectRequestInformations(RequestInterface $request)
    {
        if (!$stack = $this->collector->getCurrentStack()) {
            return;
        }

        $stack = $this->collector->getCurrentStack();
        $stack->setRequestTarget($request->getRequestTarget());
        $stack->setRequestMethod($request->getMethod());
    }
}


1		<?php
2
3		namespace Http\HttplugBundle\Collector;
4
5		use Http\Client\Common\FlexibleHttpClient;
6		use Http\Client\HttpAsyncClient;
7		use Http\Client\HttpClient;
8		use Psr\Http\Message\RequestInterface;
9
10		/**
11		* The ProfileClient decorates any client that implement both HttpClient and HttpAsyncClient interfaces to gather target
12		* url and response status code.
13		*
14		* @author Fabien Bourigault <[email protected]>
15		*
16		* @internal
17		*/
18		class ProfileClient implements HttpClient, HttpAsyncClient
19		{
20		/**
21		* @var HttpClient\|HttpAsyncClient
22		*/
23		private $client;
24
25		/**
26		* @var Collector
27		*/
28		private $collector;
29
30		/**
31		* @param HttpClient\|HttpAsyncClient $client The client to profile. Client must implement both HttpClient and
32		* HttpAsyncClient interfaces.
33		* @param Collector $collector
34		*/
35	4	public function __construct($client, Collector $collector)
36		{
37	4	if (!($client instanceof HttpClient && $client instanceof HttpAsyncClient)) {
38		throw new \RuntimeException(sprintf(
39		'%s first argument must implement %s and %s. Consider using %s.',
40		__METHOD__,
41		HttpClient::class,
42		HttpAsyncClient::class,
43		FlexibleHttpClient::class
44		));
45		}
46		$this->client = $client;
47		$this->collector = $collector;
48		}
49
50		/**
51		* {@inheritdoc}
52		*/
53		public function sendAsyncRequest(RequestInterface $request)
54		{
55		$this->collectRequestInformations($request);
56
57		return $this->client->sendAsyncRequest($request);
		0 ignored issues – show Bug introduced 2017-04-01 22:03 UTC by Report Bug Copy Issue Report The method `sendAsyncRequest` does only exist in `Http\Client\HttpAsyncClient`, but not in `Http\Client\HttpClient`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
58		}
59
60		/**
61		* {@inheritdoc}
62		*/
63		public function sendRequest(RequestInterface $request)
64		{
65		$this->collectRequestInformations($request);
66
67		return $this->client->sendRequest($request);
		0 ignored issues – show Bug introduced 2017-04-01 22:03 UTC by Report Bug Copy Issue Report The method `sendRequest` does only exist in `Http\Client\HttpClient`, but not in `Http\Client\HttpAsyncClient`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
68		}
69
70		/**
71		* @param RequestInterface $request
72		*/
73		private function collectRequestInformations(RequestInterface $request)
74		{
75		if (!$stack = $this->collector->getCurrentStack()) {
76		return;
77		}
78
79		$stack = $this->collector->getCurrentStack();
80		$stack->setRequestTarget($request->getRequestTarget());
81		$stack->setRequestMethod($request->getMethod());
82		}
83		}
84

php-http / HttplugBundle

Pull Request — master (#136)

ProfileClient::sendAsyncRequest() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like