SocketFactory::createClient() - Code Metrics - Inspection of "Merge pull request #65 from php-http/cleanup" - php-http/HttplugBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6a2de0...36e020 )

by Márk

created 2016-03-03 21:10 UTC

SocketFactory::createClient() A

↳ Parent: SocketFactory

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	8
Ratio	100 %

Code Coverage

Tests	3
CRAP Score	2.0625

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	8
loc	8
ccs	3
cts	4
cp	0.75
rs	9.4285
cc	2
eloc	4
nc	2
nop	1
crap	2.0625

<?php

namespace Http\HttplugBundle\ClientFactory;

use Http\Client\Socket\Client;
use Http\Message\MessageFactory;

/**
 * @author Tobias Nyholm <[email protected]>
 */
class SocketFactory implements ClientFactory

{
    /**
     * @var MessageFactory
     */
    private $messageFactory;

    /**
     * @param MessageFactory $messageFactory
     */
    public function __construct(MessageFactory $messageFactory)
    {
        $this->messageFactory = $messageFactory;
    }

    /**
     * {@inheritdoc}
     */
    public function createClient(array $config = [])
    {
        if (!class_exists('Http\Client\Socket\Client')) {
            throw new \LogicException('To use the Socket client you need to install the "php-http/socket-client" package.');
        }

        return new Client($this->messageFactory, $config);
    }
}


1			<?php
2
3			namespace Http\HttplugBundle\ClientFactory;
4
5			use Http\Client\Socket\Client;
6			use Http\Message\MessageFactory;
7
8			/**
9			* @author Tobias Nyholm <[email protected]>
10			*/
11		View Code Duplication	class SocketFactory implements ClientFactory
			1 ignored issue – show Duplication introduced 2016-03-01 17:20 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
12			{
13			/**
14			* @var MessageFactory
15			*/
16			private $messageFactory;
17
18			/**
19			* @param MessageFactory $messageFactory
20			*/
21	1		public function __construct(MessageFactory $messageFactory)
22			{
23	1		$this->messageFactory = $messageFactory;
24	1		}
25
26			/**
27			* {@inheritdoc}
28			*/
29	1		public function createClient(array $config = [])
30			{
31	1		if (!class_exists('Http\Client\Socket\Client')) {
32			throw new \LogicException('To use the Socket client you need to install the "php-http/socket-client" package.');
33			}
34
35	1		return new Client($this->messageFactory, $config);
36			}
37			}
38

php-http / HttplugBundle

Push — master ( 6a2de0...36e020 )

SocketFactory::createClient() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like