ConfiguredClientsStrategy::getSubscribedEvents() - Code Metrics - Inspection of "Updated travis yml to properly test different symf..." - php-http/HttplugBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( baadcd...d3edb4 )

by Tobias

created 2017-11-27 07:45 UTC

ConfiguredClientsStrategy::getSubscribedEvents() A

↳ Parent: ConfiguredClientsStrategy

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	7
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	7
loc	7
ccs	0
cts	0
cp	0
rs	9.4285
c	1
b	0
f	0
cc	1
eloc	4
nc	1
nop	0
crap	2

<?php

namespace Http\HttplugBundle\Discovery;

use Http\Client\HttpClient;
use Http\Client\HttpAsyncClient;
use Http\Discovery\HttpClientDiscovery;
use Http\Discovery\Strategy\DiscoveryStrategy;
use Symfony\Component\EventDispatcher\Event;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;

/**
 * A strategy that provide clients configured with HTTPlug bundle. With help from this strategy
 * we can use the web debug toolbar for clients found with the discovery.
 *
 * @author Tobias Nyholm <[email protected]>
 */
class ConfiguredClientsStrategy implements DiscoveryStrategy, EventSubscriberInterface
{
    /**
     * @var HttpClient
     */
    private static $client;

    /**
     * @var HttpAsyncClient
     */
    private static $asyncClient;

    /**
     * @param HttpClient      $httpClient
     * @param HttpAsyncClient $asyncClient
     */
    public function __construct(HttpClient $httpClient = null, HttpAsyncClient $asyncClient = null)
    {
        self::$client = $httpClient;
        self::$asyncClient = $asyncClient;
        HttpClientDiscovery::clearCache();
    }

    /**
     * {@inheritdoc}
     */
    public static function getCandidates($type)
    {
        if (HttpClient::class === $type && null !== self::$client) {
            return [['class' => function () {
                return self::$client;
            }]];
        }

        if (HttpAsyncClient::class === $type && null !== self::$asyncClient) {
            return [['class' => function () {
                return self::$asyncClient;
            }]];
        }

        return [];
    }

    /**
     * Make sure to use our custom strategy.
     *
     * @param Event $e
     */
    public function onEvent(Event $e)

    {
        HttpClientDiscovery::prependStrategy(self::class);
    }

    /**
     * Whenever these events occur we make sure to add our strategy to the discovery.
     *
     * {@inheritdoc}
     */
    public static function getSubscribedEvents()

    {
        return [
            'kernel.request' => ['onEvent', 1024],
            'console.command' => ['onEvent', 1024],
        ];
    }
}


1			<?php
2
3			namespace Http\HttplugBundle\Discovery;
4
5			use Http\Client\HttpClient;
6			use Http\Client\HttpAsyncClient;
7			use Http\Discovery\HttpClientDiscovery;
8			use Http\Discovery\Strategy\DiscoveryStrategy;
9			use Symfony\Component\EventDispatcher\Event;
10			use Symfony\Component\EventDispatcher\EventSubscriberInterface;
11
12			/**
13			* A strategy that provide clients configured with HTTPlug bundle. With help from this strategy
14			* we can use the web debug toolbar for clients found with the discovery.
15			*
16			* @author Tobias Nyholm <[email protected]>
17			*/
18			class ConfiguredClientsStrategy implements DiscoveryStrategy, EventSubscriberInterface
19			{
20			/**
21			* @var HttpClient
22			*/
23			private static $client;
24
25			/**
26			* @var HttpAsyncClient
27			*/
28			private static $asyncClient;
29
30			/**
31			* @param HttpClient $httpClient
32			* @param HttpAsyncClient $asyncClient
33			*/
34	17		public function __construct(HttpClient $httpClient = null, HttpAsyncClient $asyncClient = null)
35			{
36	17		self::$client = $httpClient;
37	17		self::$asyncClient = $asyncClient;
38	17		HttpClientDiscovery::clearCache();
39	17		}
40
41			/**
42			* {@inheritdoc}
43			*/
44			public static function getCandidates($type)
45			{
46			if (HttpClient::class === $type && null !== self::$client) {
47			return [['class' => function () {
48			return self::$client;
49			}]];
50			}
51
52			if (HttpAsyncClient::class === $type && null !== self::$asyncClient) {
53			return [['class' => function () {
54			return self::$asyncClient;
55			}]];
56			}
57
58	14		return [];
59			}
60
61			/**
62			* Make sure to use our custom strategy.
63			*
64			* @param Event $e
65			*/
66			public function onEvent(Event $e)
			0 ignored issues – show Unused Code introduced 2017-08-04 08:21 UTC by Report Bug Copy Issue Report The parameter `$e` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
67			{
68			HttpClientDiscovery::prependStrategy(self::class);
69			}
70
71			/**
72			* Whenever these events occur we make sure to add our strategy to the discovery.
73			*
74			* {@inheritdoc}
75			*/
76		View Code Duplication	public static function getSubscribedEvents()
			0 ignored issues – show Duplication introduced 2017-09-05 08:19 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
77			{
78			return [
79			'kernel.request' => ['onEvent', 1024],
80			'console.command' => ['onEvent', 1024],
81			];
82			}
83			}
84

php-http / HttplugBundle

Push — master ( baadcd...d3edb4 )

ConfiguredClientsStrategy::getSubscribedEvents() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like