DiscoveredClientsTest::testDiscovery() - Code Metrics - Inspection of "Merge pull request #316 from php-http/content-type..." - php-http/HttplugBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b587fb...d05392 )

by David

created 2019-03-05 12:00 UTC

DiscoveredClientsTest::testDiscovery() A

↳ Parent: DiscoveredClientsTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	18
rs	9.6666
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Http\HttplugBundle\Tests\Functional;

use Http\Client\HttpAsyncClient;
use Http\Client\HttpClient;
use Http\Discovery\HttpAsyncClientDiscovery;
use Http\Discovery\HttpClientDiscovery;
use Http\Discovery\Strategy\CommonClassesStrategy;
use Http\HttplugBundle\Collector\ProfileClient;
use Http\HttplugBundle\Discovery\ConfiguredClientsStrategy;
use Nyholm\NSA;
use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
use Symfony\Component\EventDispatcher\Event;

class DiscoveredClientsTest extends WebTestCase
{
    public function testDiscoveredClient()

    {
        $container = $this->getContainer(false);

        $this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_client'));

        $service = $container->get('httplug.auto_discovery.auto_discovered_client');

        $this->assertInstanceOf(HttpClient::class, $service);
    }

    public function testDiscoveredAsyncClient()

    {
        $container = $this->getContainer(false);

        $this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_async'));

        $service = $container->get('httplug.auto_discovery.auto_discovered_async');

        $this->assertInstanceOf(HttpAsyncClient::class, $service);
    }

    public function testDiscoveredClientWithProfilingEnabled()

    {
        $container = $this->getContainer(true);

        $this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_client'));

        $service = $container->get('httplug.auto_discovery.auto_discovered_client');

        $this->assertInstanceOf(ProfileClient::class, $service);
        $this->assertInstanceOf(HttpClient::class, NSA::getProperty($service, 'client'));
    }

    public function testDiscoveredAsyncClientWithProfilingEnabled()

    {
        $container = $this->getContainer(true);

        $this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_async'));

        $service = $container->get('httplug.auto_discovery.auto_discovered_async');

        $this->assertInstanceOf(ProfileClient::class, $service);
        $this->assertInstanceOf(HttpAsyncClient::class, NSA::getProperty($service, 'client'));
    }

    /**
     * Test with httplug.discovery.client: "auto".
     */
    public function testDiscovery()
    {
        $container = $this->getContainer(true);

        $this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_client'));
        $this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_async'));
        $this->assertTrue($container->has('httplug.strategy'));

        $container->get('httplug.strategy');

        $httpClient = $container->get('httplug.auto_discovery.auto_discovered_client');
        $httpAsyncClient = $container->get('httplug.auto_discovery.auto_discovered_async');

        $this->assertInstanceOf(ProfileClient::class, $httpClient);
        $this->assertSame(HttpClientDiscovery::find(), $httpClient);
        $this->assertInstanceOf(ProfileClient::class, $httpAsyncClient);
        $this->assertSame(HttpAsyncClientDiscovery::find(), $httpAsyncClient);
    }

    /**
     * Test with httplug.discovery.client: null.
     */
    public function testDisabledDiscovery()
    {
        $container = $this->getContainer(true, 'discovery_disabled');

        $this->assertFalse($container->has('httplug.auto_discovery.auto_discovered_client'));
        $this->assertFalse($container->has('httplug.auto_discovery.auto_discovered_async'));
        $this->assertFalse($container->has('httplug.strategy'));
    }

    /**
     * Test with httplug.discovery.client: "httplug.client.acme".
     */
    public function testForcedDiscovery()
    {
        $container = $this->getContainer(true, 'discovery_forced');

        $this->assertFalse($container->has('httplug.auto_discovery.auto_discovered_client'));
        $this->assertFalse($container->has('httplug.auto_discovery.auto_discovered_async'));
        $this->assertTrue($container->has('httplug.strategy'));

        $container->get('httplug.strategy');

        $this->assertEquals($container->get('httplug.client.acme'), HttpClientDiscovery::find());
        $this->assertEquals($container->get('httplug.client.acme'), HttpAsyncClientDiscovery::find());
    }

    private function getContainer($debug, $environment = 'test')
    {
        static::bootKernel(['debug' => $debug, 'environment' => $environment]);

        return static::$kernel->getContainer();
    }

    protected function setUp()
    {
        parent::setUp();

        // Reset values
        $strategy = new ConfiguredClientsStrategy(null, null, null);

        HttpClientDiscovery::setStrategies([CommonClassesStrategy::class]);
        $strategy->onEvent(new Event());
    }
}


1		<?php
2
3		namespace Http\HttplugBundle\Tests\Functional;
4
5		use Http\Client\HttpAsyncClient;
6		use Http\Client\HttpClient;
7		use Http\Discovery\HttpAsyncClientDiscovery;
8		use Http\Discovery\HttpClientDiscovery;
9		use Http\Discovery\Strategy\CommonClassesStrategy;
10		use Http\HttplugBundle\Collector\ProfileClient;
11		use Http\HttplugBundle\Discovery\ConfiguredClientsStrategy;
12		use Nyholm\NSA;
13		use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
14		use Symfony\Component\EventDispatcher\Event;
15
16		class DiscoveredClientsTest extends WebTestCase
17		{
18	View Code Duplication	public function testDiscoveredClient()
		0 ignored issues – show Duplication introduced 2019-03-05 12:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
19		{
20		$container = $this->getContainer(false);
21
22		$this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_client'));
23
24		$service = $container->get('httplug.auto_discovery.auto_discovered_client');
25
26		$this->assertInstanceOf(HttpClient::class, $service);
27		}
28
29	View Code Duplication	public function testDiscoveredAsyncClient()
		0 ignored issues – show Duplication introduced 2019-03-05 12:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
30		{
31		$container = $this->getContainer(false);
32
33		$this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_async'));
34
35		$service = $container->get('httplug.auto_discovery.auto_discovered_async');
36
37		$this->assertInstanceOf(HttpAsyncClient::class, $service);
38		}
39
40	View Code Duplication	public function testDiscoveredClientWithProfilingEnabled()
		0 ignored issues – show Duplication introduced 2019-03-05 12:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
41		{
42		$container = $this->getContainer(true);
43
44		$this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_client'));
45
46		$service = $container->get('httplug.auto_discovery.auto_discovered_client');
47
48		$this->assertInstanceOf(ProfileClient::class, $service);
49		$this->assertInstanceOf(HttpClient::class, NSA::getProperty($service, 'client'));
50		}
51
52	View Code Duplication	public function testDiscoveredAsyncClientWithProfilingEnabled()
		0 ignored issues – show Duplication introduced 2019-03-05 12:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
53		{
54		$container = $this->getContainer(true);
55
56		$this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_async'));
57
58		$service = $container->get('httplug.auto_discovery.auto_discovered_async');
59
60		$this->assertInstanceOf(ProfileClient::class, $service);
61		$this->assertInstanceOf(HttpAsyncClient::class, NSA::getProperty($service, 'client'));
62		}
63
64		/**
65		* Test with httplug.discovery.client: "auto".
66		*/
67		public function testDiscovery()
68		{
69		$container = $this->getContainer(true);
70
71		$this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_client'));
72		$this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_async'));
73		$this->assertTrue($container->has('httplug.strategy'));
74
75		$container->get('httplug.strategy');
76
77		$httpClient = $container->get('httplug.auto_discovery.auto_discovered_client');
78		$httpAsyncClient = $container->get('httplug.auto_discovery.auto_discovered_async');
79
80		$this->assertInstanceOf(ProfileClient::class, $httpClient);
81		$this->assertSame(HttpClientDiscovery::find(), $httpClient);
82		$this->assertInstanceOf(ProfileClient::class, $httpAsyncClient);
83		$this->assertSame(HttpAsyncClientDiscovery::find(), $httpAsyncClient);
84		}
85
86		/**
87		* Test with httplug.discovery.client: null.
88		*/
89		public function testDisabledDiscovery()
90		{
91		$container = $this->getContainer(true, 'discovery_disabled');
92
93		$this->assertFalse($container->has('httplug.auto_discovery.auto_discovered_client'));
94		$this->assertFalse($container->has('httplug.auto_discovery.auto_discovered_async'));
95		$this->assertFalse($container->has('httplug.strategy'));
96		}
97
98		/**
99		* Test with httplug.discovery.client: "httplug.client.acme".
100		*/
101		public function testForcedDiscovery()
102		{
103		$container = $this->getContainer(true, 'discovery_forced');
104
105		$this->assertFalse($container->has('httplug.auto_discovery.auto_discovered_client'));
106		$this->assertFalse($container->has('httplug.auto_discovery.auto_discovered_async'));
107		$this->assertTrue($container->has('httplug.strategy'));
108
109		$container->get('httplug.strategy');
110
111		$this->assertEquals($container->get('httplug.client.acme'), HttpClientDiscovery::find());
112		$this->assertEquals($container->get('httplug.client.acme'), HttpAsyncClientDiscovery::find());
113		}
114
115		private function getContainer($debug, $environment = 'test')
116		{
117		static::bootKernel(['debug' => $debug, 'environment' => $environment]);
118
119		return static::$kernel->getContainer();
120		}
121
122		protected function setUp()
123		{
124		parent::setUp();
125
126		// Reset values
127		$strategy = new ConfiguredClientsStrategy(null, null, null);
		0 ignored issues – show Unused Code introduced 2019-03-05 12:20 UTC by Report Bug Copy Issue Report The call to `ConfiguredClientsStrategy::__construct()` has too many arguments starting with `null`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
128		HttpClientDiscovery::setStrategies([CommonClassesStrategy::class]);
129		$strategy->onEvent(new Event());
130		}
131		}
132

php-http / HttplugBundle

Push — master ( b587fb...d05392 )

DiscoveredClientsTest::testDiscovery() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like