Http\HttplugBundle\Tests\Functional\DiscoveredClientsTest

Complexity

Total Complexity

9

Size/Duplication

Total Lines	116
Duplicated Lines	36.21 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	testDiscoveredClient()	10	10	1
A	testDiscoveredAsyncClient()	10	10	1
A	testDiscoveredClientWithProfilingEnabled()	11	11	1
A	testDiscoveredAsyncClientWithProfilingEnabled()	11	11	1
A	testDiscovery()	0	18	1
A	testDisabledDiscovery()	0	8	1
A	testForcedDiscovery()	0	13	1
A	getContainer()	0	6	1
A	setUp()	0	9	1

<?php

namespace Http\HttplugBundle\Tests\Functional;

use Http\Client\HttpAsyncClient;
use Http\Client\HttpClient;
use Http\Discovery\HttpAsyncClientDiscovery;
use Http\Discovery\HttpClientDiscovery;
use Http\Discovery\Strategy\CommonClassesStrategy;
use Http\HttplugBundle\Collector\ProfileClient;
use Http\HttplugBundle\Discovery\ConfiguredClientsStrategy;
use Nyholm\NSA;
use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
use Symfony\Component\EventDispatcher\Event;

class DiscoveredClientsTest extends WebTestCase
{
    public function testDiscoveredClient()

This method seems to be duplicated in your project.

    {
        $container = $this->getContainer(false);

        $this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_client'));

        $service = $container->get('httplug.auto_discovery.auto_discovered_client');

        $this->assertInstanceOf(HttpClient::class, $service);
    }

    public function testDiscoveredAsyncClient()

This method seems to be duplicated in your project.

    {
        $container = $this->getContainer(false);

        $this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_async'));

        $service = $container->get('httplug.auto_discovery.auto_discovered_async');

        $this->assertInstanceOf(HttpAsyncClient::class, $service);
    }

    public function testDiscoveredClientWithProfilingEnabled()

This method seems to be duplicated in your project.

    {
        $container = $this->getContainer(true);

        $this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_client'));

        $service = $container->get('httplug.auto_discovery.auto_discovered_client');

        $this->assertInstanceOf(ProfileClient::class, $service);
        $this->assertInstanceOf(HttpClient::class, NSA::getProperty($service, 'client'));
    }

    public function testDiscoveredAsyncClientWithProfilingEnabled()

This method seems to be duplicated in your project.

    {
        $container = $this->getContainer(true);

        $this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_async'));

        $service = $container->get('httplug.auto_discovery.auto_discovered_async');

        $this->assertInstanceOf(ProfileClient::class, $service);
        $this->assertInstanceOf(HttpAsyncClient::class, NSA::getProperty($service, 'client'));
    }

    /**
     * Test with httplug.discovery.client: "auto".
     */
    public function testDiscovery()
    {
        $container = $this->getContainer(true);

        $this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_client'));
        $this->assertTrue($container->has('httplug.auto_discovery.auto_discovered_async'));
        $this->assertTrue($container->has('httplug.strategy'));

        $container->get('httplug.strategy');

        $httpClient = $container->get('httplug.auto_discovery.auto_discovered_client');
        $httpAsyncClient = $container->get('httplug.auto_discovery.auto_discovered_async');

        $this->assertInstanceOf(ProfileClient::class, $httpClient);
        $this->assertSame(HttpClientDiscovery::find(), $httpClient);
        $this->assertInstanceOf(ProfileClient::class, $httpAsyncClient);
        $this->assertSame(HttpAsyncClientDiscovery::find(), $httpAsyncClient);
    }

    /**
     * Test with httplug.discovery.client: null.
     */
    public function testDisabledDiscovery()
    {
        $container = $this->getContainer(true, 'discovery_disabled');

        $this->assertFalse($container->has('httplug.auto_discovery.auto_discovered_client'));
        $this->assertFalse($container->has('httplug.auto_discovery.auto_discovered_async'));
        $this->assertFalse($container->has('httplug.strategy'));
    }

    /**
     * Test with httplug.discovery.client: "httplug.client.acme".
     */
    public function testForcedDiscovery()
    {
        $container = $this->getContainer(true, 'discovery_forced');

        $this->assertFalse($container->has('httplug.auto_discovery.auto_discovered_client'));
        $this->assertFalse($container->has('httplug.auto_discovery.auto_discovered_async'));
        $this->assertTrue($container->has('httplug.strategy'));

        $container->get('httplug.strategy');

        $this->assertEquals($container->get('httplug.client.acme'), HttpClientDiscovery::find());
        $this->assertEquals($container->get('httplug.client.acme'), HttpAsyncClientDiscovery::find());
    }

    private function getContainer($debug, $environment = 'test')
    {
        static::bootKernel(['debug' => $debug, 'environment' => $environment]);

        return static::$kernel->getContainer();
    }

    protected function setUp()
    {
        parent::setUp();

        // Reset values
        $strategy = new ConfiguredClientsStrategy(null, null, null);

The call to ConfiguredClientsStrategy::__construct() has too many arguments starting with null.

        HttpClientDiscovery::setStrategies([CommonClassesStrategy::class]);
        $strategy->onEvent(new Event());

The class Symfony\Component\EventDispatcher\Event has been deprecated with message: since Symfony 4.3, use "Symfony\Contracts\EventDispatcher\Event" instead

    }
}