ProfileClientTest::testSendRequestTypeError() - Code Metrics - Inspection of "TypeError: Argument 1 passed to ProfileClient::col..." - php-http/HttplugBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1f28ec...721e5e )

by Tobias

created 2019-08-01 11:50 UTC

ProfileClientTest::testSendRequestTypeError() A

↳ Parent: ProfileClientTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
rs	9.7666
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Http\HttplugBundle\Tests\Unit\Collector;

use GuzzleHttp\Psr7\Request;
use GuzzleHttp\Psr7\Response;
use GuzzleHttp\Psr7\Uri;
use Http\Client\HttpAsyncClient;
use Http\Client\HttpClient;
use Http\HttplugBundle\Collector\Collector;
use Http\HttplugBundle\Collector\Formatter;
use Http\HttplugBundle\Collector\ProfileClient;
use Http\HttplugBundle\Collector\Stack;
use Http\Promise\FulfilledPromise;
use Http\Promise\Promise;
use Http\Promise\RejectedPromise;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\UriInterface;
use Symfony\Component\Stopwatch\Stopwatch;
use Symfony\Component\Stopwatch\StopwatchEvent;

class ProfileClientTest extends TestCase
{
    /**
     * @var Collector
     */
    private $collector;

    /**
     * @var Stack
     */
    private $activeStack;

    /**
     * @var HttpClient|MockObject
     */
    private $client;

    /**
     * @var RequestInterface
     */
    private $request;

    /**
     * @var Formatter|MockObject
     */
    private $formatter;

    /**
     * @var Stopwatch
     */
    private $stopwatch;

    /**
     * @var StopwatchEvent
     */
    private $stopwatchEvent;

    /**
     * @var ProfileClient
     */
    private $subject;

    /**
     * @var ResponseInterface
     */
    private $response;

    /**
     * @var Promise
     */
    private $fulfilledPromise;

    /**
     * @var \Exception
     */
    private $exception;

    /**
     * @var RejectedPromise
     */
    private $rejectedPromise;

    /**
     * @var UriInterface
     */
    private $uri;

    public function setUp(): void
    {
        $this->collector = $this->getMockBuilder(Collector::class)->disableOriginalConstructor()->getMock();
        $this->activeStack = new Stack('default', 'FormattedRequest');
        $this->client = $this->getMockBuilder(ClientInterface::class)->getMock();
        $this->uri = new Uri('https://example.com/target');
        $this->request = new Request('GET', $this->uri);
        $this->formatter = $this->getMockBuilder(Formatter::class)->disableOriginalConstructor()->getMock();
        $this->stopwatch = $this->getMockBuilder(Stopwatch::class)->disableOriginalConstructor()->getMock();
        $this->stopwatchEvent = $this->getMockBuilder(StopwatchEvent::class)->disableOriginalConstructor()->getMock();
        $this->subject = new ProfileClient($this->client, $this->collector, $this->formatter, $this->stopwatch);
        $this->response = new Response();
        $this->exception = new \Exception();
        $this->fulfilledPromise = new FulfilledPromise($this->response);
        $this->rejectedPromise = new RejectedPromise($this->exception);

        $this->collector->method('getActiveStack')->willReturn($this->activeStack);
        $this->formatter
            ->method('formatResponse')
            ->with($this->response)
            ->willReturn('FormattedResponse')
        ;

        $this->stopwatch
            ->method('start')
            ->willReturn($this->stopwatchEvent)
        ;

        $this->stopwatchEvent
            ->method('getDuration')
            ->willReturn(42)
        ;
    }

    public function testSendRequest(): void
    {
        $this->client

            ->expects($this->once())
            ->method('sendRequest')
            ->with($this->identicalTo($this->request))
            ->willReturn($this->response)
        ;

        $response = $this->subject->sendRequest($this->request);

        $this->assertEquals($this->response, $response);
        $this->assertEquals('GET', $this->activeStack->getRequestMethod());
        $this->assertEquals('/target', $this->activeStack->getRequestTarget());
        $this->assertEquals('example.com', $this->activeStack->getRequestHost());
        $this->assertEquals('https', $this->activeStack->getRequestScheme());
    }

    /**
     * @expectedException \Error
     * @expectedException "You set string to int prop"
     */
    public function testSendRequestTypeError()
    {
        $this->client

            ->expects($this->once())
            ->method('sendRequest')
            ->willReturnCallback(function () {
                throw new \Error('You set string to int prop');

            });
        $this->formatter

            ->expects($this->once())
            ->method('formatException')
            ->with($this->isInstanceOf(\Error::class));

        $this->subject->sendRequest($this->request);
    }

    public function testSendAsyncRequest(): void
    {
        $this->client

            ->expects($this->once())
            ->method('sendAsyncRequest')
            ->with($this->identicalTo($this->request))
            ->willReturn($this->fulfilledPromise)
        ;

        $this->collector

            ->expects($this->once())
            ->method('deactivateStack')
        ;

        $promise = $this->subject->sendAsyncRequest($this->request);

        $this->assertEquals($this->fulfilledPromise, $promise);
        $this->assertEquals('GET', $this->activeStack->getRequestMethod());
        $this->assertEquals('/target', $this->activeStack->getRequestTarget());
        $this->assertEquals('example.com', $this->activeStack->getRequestHost());
        $this->assertEquals('https', $this->activeStack->getRequestScheme());
    }

    public function testOnFulfilled(): void

    {
        $this->collector

            ->expects($this->once())
            ->method('activateStack')
            ->with($this->activeStack)
        ;

        $this->stopwatchEvent

            ->expects($this->once())
            ->method('stop')
        ;

        $this->client

            ->method('sendAsyncRequest')
            ->willReturn($this->fulfilledPromise)
        ;

        $this->subject->sendAsyncRequest($this->request);

        $this->assertEquals(42, $this->activeStack->getDuration());
        $this->assertEquals(200, $this->activeStack->getResponseCode());
        $this->assertEquals('FormattedResponse', $this->activeStack->getClientResponse());
    }

    public function testOnRejected(): void

    {
        $this->collector

            ->expects($this->once())
            ->method('activateStack')
            ->with($this->activeStack)
        ;

        $this->stopwatchEvent

            ->expects($this->once())
            ->method('stop')
        ;

        $this->client

            ->method('sendAsyncRequest')
            ->willReturn($this->rejectedPromise)
        ;

        $this->formatter

            ->method('formatException')
            ->with($this->exception)
            ->willReturn('FormattedException')
        ;

        $this->subject->sendAsyncRequest($this->request);

        $this->assertEquals(42, $this->activeStack->getDuration());
        $this->assertEquals('FormattedException', $this->activeStack->getClientException());
    }
}

interface ClientInterface extends HttpClient, HttpAsyncClient
{
}


1		<?php
2
3		namespace Http\HttplugBundle\Tests\Unit\Collector;
4
5		use GuzzleHttp\Psr7\Request;
6		use GuzzleHttp\Psr7\Response;
7		use GuzzleHttp\Psr7\Uri;
8		use Http\Client\HttpAsyncClient;
9		use Http\Client\HttpClient;
10		use Http\HttplugBundle\Collector\Collector;
11		use Http\HttplugBundle\Collector\Formatter;
12		use Http\HttplugBundle\Collector\ProfileClient;
13		use Http\HttplugBundle\Collector\Stack;
14		use Http\Promise\FulfilledPromise;
15		use Http\Promise\Promise;
16		use Http\Promise\RejectedPromise;
17		use PHPUnit\Framework\MockObject\MockObject;
18		use PHPUnit\Framework\TestCase;
19		use Psr\Http\Message\RequestInterface;
20		use Psr\Http\Message\ResponseInterface;
21		use Psr\Http\Message\UriInterface;
22		use Symfony\Component\Stopwatch\Stopwatch;
23		use Symfony\Component\Stopwatch\StopwatchEvent;
24
25		class ProfileClientTest extends TestCase
26		{
27		/**
28		* @var Collector
29		*/
30		private $collector;
31
32		/**
33		* @var Stack
34		*/
35		private $activeStack;
36
37		/**
38		* @var HttpClient\|MockObject
39		*/
40		private $client;
41
42		/**
43		* @var RequestInterface
44		*/
45		private $request;
46
47		/**
48		* @var Formatter\|MockObject
49		*/
50		private $formatter;
51
52		/**
53		* @var Stopwatch
54		*/
55		private $stopwatch;
56
57		/**
58		* @var StopwatchEvent
59		*/
60		private $stopwatchEvent;
61
62		/**
63		* @var ProfileClient
64		*/
65		private $subject;
66
67		/**
68		* @var ResponseInterface
69		*/
70		private $response;
71
72		/**
73		* @var Promise
74		*/
75		private $fulfilledPromise;
76
77		/**
78		* @var \Exception
79		*/
80		private $exception;
81
82		/**
83		* @var RejectedPromise
84		*/
85		private $rejectedPromise;
86
87		/**
88		* @var UriInterface
89		*/
90		private $uri;
91
92		public function setUp(): void
93		{
94		$this->collector = $this->getMockBuilder(Collector::class)->disableOriginalConstructor()->getMock();
95		$this->activeStack = new Stack('default', 'FormattedRequest');
96		$this->client = $this->getMockBuilder(ClientInterface::class)->getMock();
97		$this->uri = new Uri('https://example.com/target');
98		$this->request = new Request('GET', $this->uri);
99		$this->formatter = $this->getMockBuilder(Formatter::class)->disableOriginalConstructor()->getMock();
100		$this->stopwatch = $this->getMockBuilder(Stopwatch::class)->disableOriginalConstructor()->getMock();
101		$this->stopwatchEvent = $this->getMockBuilder(StopwatchEvent::class)->disableOriginalConstructor()->getMock();
102		$this->subject = new ProfileClient($this->client, $this->collector, $this->formatter, $this->stopwatch);
103		$this->response = new Response();
104		$this->exception = new \Exception();
105		$this->fulfilledPromise = new FulfilledPromise($this->response);
106		$this->rejectedPromise = new RejectedPromise($this->exception);
107
108		$this->collector->method('getActiveStack')->willReturn($this->activeStack);
109		$this->formatter
110		->method('formatResponse')
111		->with($this->response)
112		->willReturn('FormattedResponse')
113		;
114
115		$this->stopwatch
116		->method('start')
117		->willReturn($this->stopwatchEvent)
118		;
119
120		$this->stopwatchEvent
121		->method('getDuration')
122		->willReturn(42)
123		;
124		}
125
126		public function testSendRequest(): void
127		{
128		$this->client
		0 ignored issues – show Bug introduced 2019-03-05 12:20 UTC by Report Bug Copy Issue Report The method `expects()` does not seem to exist on `object<Http\Client\HttpClient>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
129		->expects($this->once())
130		->method('sendRequest')
131		->with($this->identicalTo($this->request))
132		->willReturn($this->response)
133		;
134
135		$response = $this->subject->sendRequest($this->request);
136
137		$this->assertEquals($this->response, $response);
138		$this->assertEquals('GET', $this->activeStack->getRequestMethod());
139		$this->assertEquals('/target', $this->activeStack->getRequestTarget());
140		$this->assertEquals('example.com', $this->activeStack->getRequestHost());
141		$this->assertEquals('https', $this->activeStack->getRequestScheme());
142		}
143
144		/**
145		* @expectedException \Error
146		* @expectedException "You set string to int prop"
147		*/
148		public function testSendRequestTypeError()
149		{
150		$this->client
		0 ignored issues – show Bug introduced 2019-03-05 12:20 UTC by Report Bug Copy Issue Report The method `expects()` does not seem to exist on `object<Http\Client\HttpClient>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
151		->expects($this->once())
152		->method('sendRequest')
153		->willReturnCallback(function () {
154		throw new \Error('You set string to int prop');
		0 ignored issues – show Unused Code introduced 2019-08-01 11:53 UTC by Report Bug Copy Issue Report The call to `Error::__construct()` has too many arguments starting with `'You set string to int prop'`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
155		});
156		$this->formatter
		0 ignored issues – show Bug introduced 2019-08-01 11:53 UTC by Report Bug Copy Issue Report The method `expects()` does not seem to exist on `object<Http\HttplugBundle\Collector\Formatter>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
157		->expects($this->once())
158		->method('formatException')
159		->with($this->isInstanceOf(\Error::class));
160
161		$this->subject->sendRequest($this->request);
162		}
163
164		public function testSendAsyncRequest(): void
165		{
166		$this->client
		0 ignored issues – show Bug introduced 2019-08-01 11:53 UTC by Report Bug Copy Issue Report The method `expects()` does not seem to exist on `object<Http\Client\HttpClient>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
167		->expects($this->once())
168		->method('sendAsyncRequest')
169		->with($this->identicalTo($this->request))
170		->willReturn($this->fulfilledPromise)
171		;
172
173		$this->collector
		0 ignored issues – show Bug introduced 2019-03-05 12:20 UTC by Report Bug Copy Issue Report The method `expects()` does not seem to exist on `object<Http\HttplugBundle\Collector\Collector>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
174		->expects($this->once())
175		->method('deactivateStack')
176		;
177
178		$promise = $this->subject->sendAsyncRequest($this->request);
179
180		$this->assertEquals($this->fulfilledPromise, $promise);
181		$this->assertEquals('GET', $this->activeStack->getRequestMethod());
182		$this->assertEquals('/target', $this->activeStack->getRequestTarget());
183		$this->assertEquals('example.com', $this->activeStack->getRequestHost());
184		$this->assertEquals('https', $this->activeStack->getRequestScheme());
185		}
186
187	View Code Duplication	public function testOnFulfilled(): void
		0 ignored issues – show Duplication introduced 2019-08-01 11:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
188		{
189		$this->collector
		0 ignored issues – show Bug introduced 2019-03-05 12:20 UTC by Report Bug Copy Issue Report The method `expects()` does not seem to exist on `object<Http\HttplugBundle\Collector\Collector>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
190		->expects($this->once())
191		->method('activateStack')
192		->with($this->activeStack)
193		;
194
195		$this->stopwatchEvent
		0 ignored issues – show Bug introduced 2019-03-05 12:20 UTC by Report Bug Copy Issue Report The method `expects()` does not seem to exist on `object<Symfony\Component...opwatch\StopwatchEvent>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
196		->expects($this->once())
197		->method('stop')
198		;
199
200		$this->client
		0 ignored issues – show Bug introduced 2019-03-05 12:20 UTC by Report Bug Copy Issue Report The method `method()` does not seem to exist on `object<Http\Client\HttpClient>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
201		->method('sendAsyncRequest')
202		->willReturn($this->fulfilledPromise)
203		;
204
205		$this->subject->sendAsyncRequest($this->request);
206
207		$this->assertEquals(42, $this->activeStack->getDuration());
208		$this->assertEquals(200, $this->activeStack->getResponseCode());
209		$this->assertEquals('FormattedResponse', $this->activeStack->getClientResponse());
210		}
211
212	View Code Duplication	public function testOnRejected(): void
		0 ignored issues – show Duplication introduced 2019-08-01 11:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
213		{
214		$this->collector
		0 ignored issues – show Bug introduced 2019-03-05 12:20 UTC by Report Bug Copy Issue Report The method `expects()` does not seem to exist on `object<Http\HttplugBundle\Collector\Collector>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
215		->expects($this->once())
216		->method('activateStack')
217		->with($this->activeStack)
218		;
219
220		$this->stopwatchEvent
		0 ignored issues – show Bug introduced 2019-03-05 12:20 UTC by Report Bug Copy Issue Report The method `expects()` does not seem to exist on `object<Symfony\Component...opwatch\StopwatchEvent>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
221		->expects($this->once())
222		->method('stop')
223		;
224
225		$this->client
		0 ignored issues – show Bug introduced 2019-03-05 12:20 UTC by Report Bug Copy Issue Report The method `method()` does not seem to exist on `object<Http\Client\HttpClient>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
226		->method('sendAsyncRequest')
227		->willReturn($this->rejectedPromise)
228		;
229
230		$this->formatter
		0 ignored issues – show Bug introduced 2019-08-01 11:53 UTC by Report Bug Copy Issue Report The method `method()` does not seem to exist on `object<Http\HttplugBundle\Collector\Formatter>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
231		->method('formatException')
232		->with($this->exception)
233		->willReturn('FormattedException')
234		;
235
236		$this->subject->sendAsyncRequest($this->request);
237
238		$this->assertEquals(42, $this->activeStack->getDuration());
239		$this->assertEquals('FormattedException', $this->activeStack->getClientException());
240		}
241		}
242
243		interface ClientInterface extends HttpClient, HttpAsyncClient
244		{
245		}
246

php-http / HttplugBundle

Push — master ( 1f28ec...721e5e )

ProfileClientTest::testSendRequestTypeError() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like