Person::getNames() - Code Metrics - Inspection of "improve xml and cda with various tags" - php-health/cda - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 85b767...9f6cfb )

by Julien

created 2017-02-06 22:19 UTC

Person::getNames() A

↳ Parent: Person::toDOMElement()

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php

/*
 * The MIT License
 *
 * Copyright 2016 Julien Fastré <[email protected]>.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */

namespace PHPHealth\CDA\RIM\Entity;

use PHPHealth\CDA\ElementInterface;
use PHPHealth\CDA\ClinicalDocument as CDA;
use PHPHealth\CDA\DataType\Quantity\DateAndTime\TimeStamp;
use PHPHealth\CDA\DataType\Collection\Set;
use PHPHealth\CDA\Elements\AdministrativeGenderCode;
use PHPHealth\CDA\DataType\Code\CodedValue;
use PHPHealth\CDA\Elements\BirthTime;

/**
 *
 *
 * @author Julien Fastré <[email protected]>
 */
abstract class Person extends LivingSubject
{
    public function __construct(
        Set $names = null,
        TimeStamp $birthtime = null,
        CodedValue $administrativeGenderCode = null
    ) {
        if ($names !== null) {
            $this->setNames($names);
        }
        if ($birthtime !== null) {
            $this->setBirthtime($birthtime);
        }
        if ($administrativeGenderCode !== null) {
            $this->setAdministrativeGenderCode($administrativeGenderCode);
        }
    }
    
    public function getDefaultClassCode()
    {
        return 'PSN';
    }

            
    public function toDOMElement(\DOMDocument $doc)
    {
        $el = parent::createElement($doc);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        //add names
        if ($this->getNames() !== null) {
            $this->getNames()->setValueToElement($el, $doc);
        }
        // add administrative gender code
        if ($this->getAdministrativeGenderCode() !== null) {
            $adm = new AdministrativeGenderCode($this->administrativeGenderCode);
            $el->appendChild($adm->toDOMElement($doc));
        }
        // add birthtime
        if ($this->getBirthtime() !== null) {
            $bir = new BirthTime($this->birthtime);
            $el->appendChild($bir->toDOMElement($doc));
        }
        
        return $el;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
}


1			<?php
2
3			/*
4			* The MIT License
5			*
6			* Copyright 2016 Julien Fastré <[email protected]>.
7			*
8			* Permission is hereby granted, free of charge, to any person obtaining a copy
9			* of this software and associated documentation files (the "Software"), to deal
10			* in the Software without restriction, including without limitation the rights
11			* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
12			* copies of the Software, and to permit persons to whom the Software is
13			* furnished to do so, subject to the following conditions:
14			*
15			* The above copyright notice and this permission notice shall be included in
16			* all copies or substantial portions of the Software.
17			*
18			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
19			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
20			* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
21			* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
22			* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
23			* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
24			* THE SOFTWARE.
25			*/
26
27			namespace PHPHealth\CDA\RIM\Entity;
28
29			use PHPHealth\CDA\ElementInterface;
30			use PHPHealth\CDA\ClinicalDocument as CDA;
31			use PHPHealth\CDA\DataType\Quantity\DateAndTime\TimeStamp;
32			use PHPHealth\CDA\DataType\Collection\Set;
33			use PHPHealth\CDA\Elements\AdministrativeGenderCode;
34			use PHPHealth\CDA\DataType\Code\CodedValue;
35			use PHPHealth\CDA\Elements\BirthTime;
36
37			/**
38			*
39			*
40			* @author Julien Fastré <[email protected]>
41			*/
42			abstract class Person extends LivingSubject
43			{
44			public function __construct(
45			Set $names = null,
46			TimeStamp $birthtime = null,
47			CodedValue $administrativeGenderCode = null
48			) {
49			if ($names !== null) {
50			$this->setNames($names);
51			}
52			if ($birthtime !== null) {
53			$this->setBirthtime($birthtime);
54			}
55			if ($administrativeGenderCode !== null) {
56			$this->setAdministrativeGenderCode($administrativeGenderCode);
57			}
58			}
59
60			public function getDefaultClassCode()
61			{
62			return 'PSN';
63			}
64
65
66			public function toDOMElement(\DOMDocument $doc)
67			{
68			$el = parent::createElement($doc);
			0 ignored issues – show Comprehensibility Bug introduced 2017-02-06 22:22 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`createElement()` instead of `toDOMElement()`). Are you sure this is correct? If so, you might want to change this to `$this->createElement()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
69			//add names
70			if ($this->getNames() !== null) {
71			$this->getNames()->setValueToElement($el, $doc);
72			}
73			// add administrative gender code
74			if ($this->getAdministrativeGenderCode() !== null) {
75			$adm = new AdministrativeGenderCode($this->administrativeGenderCode);
76			$el->appendChild($adm->toDOMElement($doc));
77			}
78			// add birthtime
79			if ($this->getBirthtime() !== null) {
80			$bir = new BirthTime($this->birthtime);
81			$el->appendChild($bir->toDOMElement($doc));
82			}
83
84			return $el;
			0 ignored issues – show Bug Best Practice introduced 2017-02-06 22:22 UTC by Report Bug Copy Issue Report The return type of `return $el;` (`PHPHealth\CDA\Elements\DOMElement`) is incompatible with the return type declared by the interface `PHPHealth\CDA\ElementInterface::toDOMElement` of type `DOMElement`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
85			}
86			}
87

php-health / cda

Push — master ( 85b767...9f6cfb )

Person::getNames() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like