PHPHealth\CDA\DataType\Collection\Interval\IntervalOfTime

Complexity

Total Complexity

6

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getLow()	0	4	1
A	getHigh()	0	4	1
A	setLow()	0	5	1
A	setHigh()	0	5	1
A	setValueToElement()	0	12	1

<?php
/*
 * The MIT License
 *
 * Copyright 2017 Julien Fastré <julien.fastre@champs-libres.coop>.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */
namespace PHPHealth\CDA\DataType\Collection\Interval;

use PHPHealth\CDA\ClinicalDocument as CDA;
use PHPHealth\CDA\DataType\Quantity\DateAndTime\TimeStamp;


/**
 * 
 *
 * @author Julien Fastré <julien.fastre@champs-libres.coop>
 */
class IntervalOfTime extends AbstractInterval
{
    /**
     *
     * @var TimeStamp
     */
    private $low;
    
    /**
     *
     * @var TimeStamp
     */
    private $high;
    
    function __construct(TimeStamp $low, TimeStamp $high)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->setHigh($high);
        $this->setLow($low);
    }

    
    function getLow(): TimeStamp

It is generally recommended to explicitly declare the visibility for methods.

    {
        return $this->low;
    }

    function getHigh(): TimeStamp

It is generally recommended to explicitly declare the visibility for methods.

    {
        return $this->high;
    }

    function setLow(TimeStamp $low)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->low = $low;
        return $this;
    }

    function setHigh(TimeStamp $high)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->high = $high;
        return $this;
    }

        
    public function setValueToElement(\DOMElement &$el, \DOMDocument $doc = null)
    {
        $low = $doc->createElement(CDA::NS_CDA.'low');

It seems like $doc is not always an object, but can also be of type null. Maybe add an additional type check?

        $this->low->setValueToElement($low, $doc);
        
        $high = $doc->createElement(CDA::NS_CDA.'high');
        $this->high->setValueToElement($high, $doc);
        
        $el->appendChild($low);
        $el->appendChild($high);
        $el->setAttribute('xsi:type', 'IVL_TS');
    }
}