ClientSecretPostAuthenticationMethod::authenticate() - Code Metrics - Inspection of "server" - php-guard/oauth-server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( c97e91...9a636e )

by Alexandre

created 2018-03-11 21:57 UTC

authenticate() A

↳ Parent: ClientSecretPostAuthenticationMethod

Complexity

Conditions	3
Paths	2

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	4
nc	2
nop	2
dl	0
loc	7
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * Created by PhpStorm.
 * User: GCC-MED
 * Date: 09/03/2018
 * Time: 16:59
 */

namespace OAuth2\ClientAuthentication;


use OAuth2\Roles\ClientInterface;
use OAuth2\Roles\Clients\ConfidentialClient;
use OAuth2\Storages\ClientStorageInterface;
use Psr\Http\Message\ServerRequestInterface;

class ClientSecretPostAuthenticationMethod implements ClientAuthenticationMethodInterface
{
    /**
     * @var ClientStorageInterface
     */
    private $clientStorage;

    public function __construct(ClientStorageInterface $clientStorage)
{
    $this->clientStorage = $clientStorage;
}

    function support(ServerRequestInterface $request, array $requestData): bool

    {
        return !empty($requestData['client_id']) && !empty($requestData['client_secret']);
    }

    function authenticate(ServerRequestInterface $request, array $requestData): ?ClientInterface

    {
        $client = $this->clientStorage->get($requestData['client_id']);
        if($client instanceof ConfidentialClient && $client->getPassword() == $requestData['client_secret']) {
            return $client;
        }
        return null;
    }
}

1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: GCC-MED
5			* Date: 09/03/2018
6			* Time: 16:59
7			*/
8
9			namespace OAuth2\ClientAuthentication;
10
11
12			use OAuth2\Roles\ClientInterface;
13			use OAuth2\Roles\Clients\ConfidentialClient;
14			use OAuth2\Storages\ClientStorageInterface;
15			use Psr\Http\Message\ServerRequestInterface;
16
17			class ClientSecretPostAuthenticationMethod implements ClientAuthenticationMethodInterface
18			{
19			/**
20			* @var ClientStorageInterface
21			*/
22			private $clientStorage;
23
24			public function __construct(ClientStorageInterface $clientStorage)
25			{
26			$this->clientStorage = $clientStorage;
27			}
28
29			function support(ServerRequestInterface $request, array $requestData): bool
			0 ignored issues – show Best Practice introduced 2018-03-11 21:58 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
30			{
31			return !empty($requestData['client_id']) && !empty($requestData['client_secret']);
32			}
33
34			function authenticate(ServerRequestInterface $request, array $requestData): ?ClientInterface
			0 ignored issues – show Best Practice introduced 2018-03-11 21:58 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
35			{
36			$client = $this->clientStorage->get($requestData['client_id']);
37			if($client instanceof ConfidentialClient && $client->getPassword() == $requestData['client_secret']) {
38			return $client;
39			}
40			return null;
41			}
42			}

php-guard / oauth-server

Push — master ( c97e91...9a636e )

authenticate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like