OAuth2\Extensions\OpenID\Flows\AuthorizationCodeFlow

Complexity

Total Complexity

6

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	createAuthorizationCode()	0	8	1
A	handleAuthorizationRequest()	0	13	3
A	saveAndGetResult()	0	4	1
A	__construct()	0	3	1

<?php
/**
 * Created by PhpStorm.
 * User: Alexandre
 * Date: 10/03/2018
 * Time: 17:40
 */

namespace OAuth2\Extensions\OpenID\Flows;


use OAuth2\Credentials\AuthorizationCodeInterface;
use OAuth2\Endpoints\AuthorizationEndpoint;
use OAuth2\Exceptions\OAuthException;
use OAuth2\ResponseTypes\ResponseTypeInterface;
use OAuth2\Storages\AuthorizationCodeStorageInterface;

class AuthorizationCodeFlow extends \OAuth2\Flows\AuthorizationCodeFlow
{
    public function __construct(AuthorizationCodeStorageInterface $authorizationCodeStorage)
    {
        parent::__construct($authorizationCodeStorage);

The call to OAuth2\Flows\AuthorizationCodeFlow::__construct() has too few arguments starting with accessTokenStorage.

    }

    /**
     * @param AuthorizationEndpoint $authorizationEndpoint
     * @param array $requestData
     * @return array
     * @throws OAuthException
     */
    function handleAuthorizationRequest(AuthorizationEndpoint $authorizationEndpoint, array $requestData): array

It is generally recommended to explicitly declare the visibility for methods.

    {
        $authorizationCode = $this->createAuthorizationCode($authorizationEndpoint);
        if (in_array('openid', $authorizationEndpoint->getScopes())) {
            if (empty($requestData['redirect_uri'])) {
                throw new OAuthException('invalid_request', 'The request is missing the required parameter redirect_uri.',
                    'https://tools.ietf.org/html/rfc6749#section-4.1');
            }


            $requestData['nonce'];
        }
        return $this->saveAndGetResult($authorizationCode);
    }

    protected function createAuthorizationCode(AuthorizationEndpoint $authorizationEndpoint)
    {
        return $this->authorizationCodeStorage->create(
            implode(' ', $authorizationEndpoint->getScopes()),
            $authorizationEndpoint->getClient()->getIdentifier(),
            $authorizationEndpoint->getResourceOwner()->getIdentifier(),
            $requestData['scope'] ?? null,

The variable $requestData seems to never exist and therefore isset should always be false.

            $requestData['redirect_uri'] ?? null
        );
    }

    protected function saveAndGetResult(AuthorizationCodeInterface $authorizationCode)
    {
        $this->authorizationCodeStorage->save($authorizationCode);
        return ['code' => $authorizationCode->getCode()];
    }

}