Server::__construct() - Code Metrics - Inspection of "scrutinizer" - php-guard/oauth-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7810d2...aebd05 )

by Alexandre

created 2018-01-23 09:16 UTC

Server::__construct() C

↳ Parent: Server

Complexity

Conditions	7
Paths	64

Size

Total Lines	51
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	56

Importance

Changes

Metric	Value
cc	7
eloc	30
nc	64
nop	8
dl	0
loc	51
ccs	0
cts	27
cp	0
crap	56
rs	6.9743
c	0
b	0
f	0

How to fix Long Method Many Parameters

<?php
/**
 * Created by PhpStorm.
 * User: Alexandre
 * Date: 07/01/2018
 * Time: 13:57
 */

namespace OAuth2;


use OAuth2\ClientAuthentication\Guard;
use OAuth2\Endpoints\AuthorizationEndpoint;
use OAuth2\Endpoints\TokenEndpoint;
use OAuth2\Providers\ResourceOwnerProviderInterface;
use OAuth2\Repositories\ClientAuthenticatorRepository;
use OAuth2\Repositories\ConfigurationRepository;
use OAuth2\Repositories\GrantTypeRepository;
use OAuth2\Repositories\ResponseTypeRepository;
use OAuth2\Repositories\StorageRepository;
use OAuth2\ScopePolicy\Manager;


class Server
{
    /**
     * @var ConfigurationRepository
     */
    protected $configurationRepository;
    /**
     * @var StorageRepository
     */
    protected $storageRepository;
    /**
     * @var ResponseTypeRepository
     */
    protected $responseTypeRepository;
    /**
     * @var GrantTypeRepository
     */
    protected $grantTypeRepository;
    /**
     * @var ClientAuthenticatorRepository
     */
    protected $clientAuthenticatorRepository;
    /**
     * @var AuthorizationEndpoint
     */
    protected $authorizationEndpoint;
    /**
     * @var TokenEndpoint
     */
    protected $tokenEndpoint;
    /**
     * @var Guard
     */
    protected $guard;
    /**
     * @var Manager
     */
    protected $scopePolicyManager;
    /**
     * @var ResourceOwnerProviderInterface
     */
    protected $resourceOwnerProvider;

    /**
     * Server constructor.
     * @param ResourceOwnerProviderInterface $resourceOwnerProvider
     * @param null|StorageRepository $storageRepository
     * @param null|ConfigurationRepository $configurationRepository
     * @param ResponseTypeRepository $responseTypeRepository
     * @param null|GrantTypeRepository $grantTypeRepository
     * @param null|ClientAuthenticatorRepository $clientAuthenticatorRepository
     * @param null|Guard $guard
     * @param null|Manager $scopePolicyManager
     * @throws \Exception
     */
    public function __construct(ResourceOwnerProviderInterface $resourceOwnerProvider,
                                StorageRepository $storageRepository,
                                ConfigurationRepository $configurationRepository = null,
                                ?ResponseTypeRepository $responseTypeRepository = null,
                                ?GrantTypeRepository $grantTypeRepository = null,
                                ?ClientAuthenticatorRepository $clientAuthenticatorRepository = null,
                                ?Guard $guard = null,
                                ?Manager $scopePolicyManager = null)
    {
        $this->resourceOwnerProvider = $resourceOwnerProvider;
        $this->storageRepository = $storageRepository;


        if (is_null($configurationRepository)) {
            $this->configurationRepository = new ConfigurationRepository();
        } else {
            $this->configurationRepository = $configurationRepository;
        }

        if (is_null($responseTypeRepository)) {
            $this->responseTypeRepository = new ResponseTypeRepository(
                ResponseTypeRepository::getDefaultResponseTypes($this->storageRepository));
        } else {
            $this->responseTypeRepository = $responseTypeRepository;
        }

        if (is_null($clientAuthenticatorRepository)) {
            $this->clientAuthenticatorRepository = new ClientAuthenticatorRepository(
                ClientAuthenticatorRepository::getDefaultAuthenticators(
                    $this->configurationRepository, $this->storageRepository));
        } else {
            $this->clientAuthenticatorRepository = $responseTypeRepository;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        }

        $this->guard = $guard ? $guard : new Guard($this);
//        var_dump($this->guard);die;

        $this->scopePolicyManager = $scopePolicyManager ? $scopePolicyManager : new Manager($this);

        if (is_null($grantTypeRepository)) {
            $this->grantTypeRepository = new GrantTypeRepository(
                GrantTypeRepository::getDefaultGrantTypes(
                    $this->configurationRepository,
                    $this->resourceOwnerProvider,
                    $this->scopePolicyManager,
                    $this->storageRepository));
        } else {
            $this->grantTypeRepository = $grantTypeRepository;
        }

        $this->authorizationEndpoint = new AuthorizationEndpoint($this);
        $this->tokenEndpoint = new TokenEndpoint($this);
    }

    /**
     * @return ConfigurationRepository
     */
    public function getConfigurationRepository(): ConfigurationRepository
    {
        return $this->configurationRepository;
    }

    /**
     * @return StorageRepository
     */
    public function getStorageRepository(): StorageRepository
    {
        return $this->storageRepository;
    }

    /**
     * @return ResponseTypeRepository
     */
    public function getResponseTypeRepository(): ResponseTypeRepository
    {
        return $this->responseTypeRepository;
    }

    /**
     * @return GrantTypeRepository
     */
    public function getGrantTypeRepository(): GrantTypeRepository
    {
        return $this->grantTypeRepository;
    }

    /**
     * @return ClientAuthenticatorRepository
     */
    public function getClientAuthenticatorRepository(): ClientAuthenticatorRepository
    {
        return $this->clientAuthenticatorRepository;
    }

    /**
     * @return AuthorizationEndpoint
     */
    public function getAuthorizationEndpoint(): AuthorizationEndpoint
    {
        return $this->authorizationEndpoint;
    }

    /**
     * @return TokenEndpoint
     */
    public function getTokenEndpoint(): TokenEndpoint
    {
        return $this->tokenEndpoint;
    }

    /**
     * @return Guard
     */
    public function getGuard(): Guard
    {
        return $this->guard;
    }

    /**
     * @return bool
     *
     * @see https://tools.ietf.org/html/rfc6749#section-3.1.2.1
     *
     *  Endpoint Request Confidentiality
     *
     *     The redirection endpoint SHOULD require the use of TLS as described
     * in Section 1.6 when the requested response type is "code" or "token",
     * or when the redirection request will result in the transmission of
     * sensitive credentials over an open network.  This specification does
     * not mandate the use of TLS because at the time of this writing,
     * requiring clients to deploy TLS is a significant hurdle for many
     * client developers.  If TLS is not available, the authorization server
     * SHOULD warn the resource owner about the insecure endpoint prior to
     * redirection (e.g., display a message during the authorization
     * request).
     *
     * Lack of transport-layer security can have a severe impact on the
     * security of the client and the protected resources it is authorized
     * to access.  The use of transport-layer security is particularly
     * critical when the authorization process is used as a form of
     * delegated end-user authentication by the client (e.g., third-party
     * sign-in service).
     */
    public function isSecure()
    {
        return isset($_SERVER['HTTPS']) && ('on' == strtolower($_SERVER['HTTPS']) || 1 == $_SERVER['HTTPS']);
    }

    /**
     * @return Manager
     */
    public function getScopePolicyManager(): Manager
    {
        return $this->scopePolicyManager;
    }

    /**
     * @return ResourceOwnerProviderInterface
     */
    public function getResourceOwnerProvider(): ResourceOwnerProviderInterface
    {
        return $this->resourceOwnerProvider;
    }
}

1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: Alexandre
5		* Date: 07/01/2018
6		* Time: 13:57
7		*/
8
9		namespace OAuth2;
10
11
12		use OAuth2\ClientAuthentication\Guard;
13		use OAuth2\Endpoints\AuthorizationEndpoint;
14		use OAuth2\Endpoints\TokenEndpoint;
15		use OAuth2\Providers\ResourceOwnerProviderInterface;
16		use OAuth2\Repositories\ClientAuthenticatorRepository;
17		use OAuth2\Repositories\ConfigurationRepository;
18		use OAuth2\Repositories\GrantTypeRepository;
19		use OAuth2\Repositories\ResponseTypeRepository;
20		use OAuth2\Repositories\StorageRepository;
21		use OAuth2\ScopePolicy\Manager;
22
23
24		class Server
25		{
26		/**
27		* @var ConfigurationRepository
28		*/
29		protected $configurationRepository;
30		/**
31		* @var StorageRepository
32		*/
33		protected $storageRepository;
34		/**
35		* @var ResponseTypeRepository
36		*/
37		protected $responseTypeRepository;
38		/**
39		* @var GrantTypeRepository
40		*/
41		protected $grantTypeRepository;
42		/**
43		* @var ClientAuthenticatorRepository
44		*/
45		protected $clientAuthenticatorRepository;
46		/**
47		* @var AuthorizationEndpoint
48		*/
49		protected $authorizationEndpoint;
50		/**
51		* @var TokenEndpoint
52		*/
53		protected $tokenEndpoint;
54		/**
55		* @var Guard
56		*/
57		protected $guard;
58		/**
59		* @var Manager
60		*/
61		protected $scopePolicyManager;
62		/**
63		* @var ResourceOwnerProviderInterface
64		*/
65		protected $resourceOwnerProvider;
66
67		/**
68		* Server constructor.
69		* @param ResourceOwnerProviderInterface $resourceOwnerProvider
70		* @param null\|StorageRepository $storageRepository
71		* @param null\|ConfigurationRepository $configurationRepository
72		* @param ResponseTypeRepository $responseTypeRepository
73		* @param null\|GrantTypeRepository $grantTypeRepository
74		* @param null\|ClientAuthenticatorRepository $clientAuthenticatorRepository
75		* @param null\|Guard $guard
76		* @param null\|Manager $scopePolicyManager
77		* @throws \Exception
78		*/
79		public function __construct(ResourceOwnerProviderInterface $resourceOwnerProvider,
80		StorageRepository $storageRepository,
81		ConfigurationRepository $configurationRepository = null,
82		?ResponseTypeRepository $responseTypeRepository = null,
83		?GrantTypeRepository $grantTypeRepository = null,
84		?ClientAuthenticatorRepository $clientAuthenticatorRepository = null,
85		?Guard $guard = null,
86		?Manager $scopePolicyManager = null)
87		{
88		$this->resourceOwnerProvider = $resourceOwnerProvider;
89		$this->storageRepository = $storageRepository;
90
91
92		if (is_null($configurationRepository)) {
93		$this->configurationRepository = new ConfigurationRepository();
94		} else {
95		$this->configurationRepository = $configurationRepository;
96		}
97
98		if (is_null($responseTypeRepository)) {
99		$this->responseTypeRepository = new ResponseTypeRepository(
100		ResponseTypeRepository::getDefaultResponseTypes($this->storageRepository));
101		} else {
102		$this->responseTypeRepository = $responseTypeRepository;
103		}
104
105		if (is_null($clientAuthenticatorRepository)) {
106		$this->clientAuthenticatorRepository = new ClientAuthenticatorRepository(
107		ClientAuthenticatorRepository::getDefaultAuthenticators(
108		$this->configurationRepository, $this->storageRepository));
109		} else {
110		$this->clientAuthenticatorRepository = $responseTypeRepository;
		0 ignored issues – show Documentation Bug introduced 2018-01-23 09:18 UTC by Report Bug Copy Issue Report It seems like `$responseTypeRepository` can also be of type `OAuth2\Repositories\ResponseTypeRepository`. However, the property `$clientAuthenticatorRepository` is declared as type `OAuth2\Repositories\ClientAuthenticatorRepository`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
111		}
112
113		$this->guard = $guard ? $guard : new Guard($this);
114		// var_dump($this->guard);die;
		0 ignored issues – show Unused Code Comprehensibility introduced 2018-01-19 16:33 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
115		$this->scopePolicyManager = $scopePolicyManager ? $scopePolicyManager : new Manager($this);
116
117		if (is_null($grantTypeRepository)) {
118		$this->grantTypeRepository = new GrantTypeRepository(
119		GrantTypeRepository::getDefaultGrantTypes(
120		$this->configurationRepository,
121		$this->resourceOwnerProvider,
122		$this->scopePolicyManager,
123		$this->storageRepository));
124		} else {
125		$this->grantTypeRepository = $grantTypeRepository;
126		}
127
128		$this->authorizationEndpoint = new AuthorizationEndpoint($this);
129		$this->tokenEndpoint = new TokenEndpoint($this);
130		}
131
132		/**
133		* @return ConfigurationRepository
134		*/
135	4	public function getConfigurationRepository(): ConfigurationRepository
136		{
137	4	return $this->configurationRepository;
138		}
139
140		/**
141		* @return StorageRepository
142		*/
143	4	public function getStorageRepository(): StorageRepository
144		{
145	4	return $this->storageRepository;
146		}
147
148		/**
149		* @return ResponseTypeRepository
150		*/
151	4	public function getResponseTypeRepository(): ResponseTypeRepository
152		{
153	4	return $this->responseTypeRepository;
154		}
155
156		/**
157		* @return GrantTypeRepository
158		*/
159	1	public function getGrantTypeRepository(): GrantTypeRepository
160		{
161	1	return $this->grantTypeRepository;
162		}
163
164		/**
165		* @return ClientAuthenticatorRepository
166		*/
167	1	public function getClientAuthenticatorRepository(): ClientAuthenticatorRepository
168		{
169	1	return $this->clientAuthenticatorRepository;
170		}
171
172		/**
173		* @return AuthorizationEndpoint
174		*/
175	4	public function getAuthorizationEndpoint(): AuthorizationEndpoint
176		{
177	4	return $this->authorizationEndpoint;
178		}
179
180		/**
181		* @return TokenEndpoint
182		*/
183	1	public function getTokenEndpoint(): TokenEndpoint
184		{
185	1	return $this->tokenEndpoint;
186		}
187
188		/**
189		* @return Guard
190		*/
191	1	public function getGuard(): Guard
192		{
193	1	return $this->guard;
194		}
195
196		/**
197		* @return bool
198		*
199		* @see https://tools.ietf.org/html/rfc6749#section-3.1.2.1
200		*
201		* Endpoint Request Confidentiality
202		*
203		* The redirection endpoint SHOULD require the use of TLS as described
204		* in Section 1.6 when the requested response type is "code" or "token",
205		* or when the redirection request will result in the transmission of
206		* sensitive credentials over an open network. This specification does
207		* not mandate the use of TLS because at the time of this writing,
208		* requiring clients to deploy TLS is a significant hurdle for many
209		* client developers. If TLS is not available, the authorization server
210		* SHOULD warn the resource owner about the insecure endpoint prior to
211		* redirection (e.g., display a message during the authorization
212		* request).
213		*
214		* Lack of transport-layer security can have a severe impact on the
215		* security of the client and the protected resources it is authorized
216		* to access. The use of transport-layer security is particularly
217		* critical when the authorization process is used as a form of
218		* delegated end-user authentication by the client (e.g., third-party
219		* sign-in service).
220		*/
221	1	public function isSecure()
222		{
223	1	return isset($_SERVER['HTTPS']) && ('on' == strtolower($_SERVER['HTTPS']) \|\| 1 == $_SERVER['HTTPS']);
224		}
225
226		/**
227		* @return Manager
228		*/
229	3	public function getScopePolicyManager(): Manager
230		{
231	3	return $this->scopePolicyManager;
232		}
233
234		/**
235		* @return ResourceOwnerProviderInterface
236		*/
237		public function getResourceOwnerProvider(): ResourceOwnerProviderInterface
238		{
239		return $this->resourceOwnerProvider;
240		}
241		}

php-guard / oauth-server

Push — master ( 7810d2...aebd05 )

Server::__construct() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Many Parameters

Long Method

Many Parameters

Duplication Side-by-Side

Filter issues like