FormEncodedBodyParameter::support() - Code Metrics - Inspection of "Merge remote-tracking branch 'origin/master'" - php-guard/oauth-server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 8278f2...2a258c )

by Alexandre

created 2018-06-02 18:18 UTC

FormEncodedBodyParameter::support() A

↳ Parent: FormEncodedBodyParameter

Complexity

Conditions	1
Paths	1

Size

Total Lines	2
Code Lines	0

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	0
nc	1
nop	1
dl	0
loc	2
rs	10
c	0
b	0
f	0

<?php
/**
 * Created by PhpStorm.
 * User: Alexandre
 * Date: 27/05/2018
 * Time: 18:13
 */

namespace OAuth2\Roles\ResourceServer\BearerAuthenticationMethods;
use Psr\Http\Message\ServerRequestInterface;

/**
 * Class FormEncodedBodyParameter
 * @package OAuth2\Roles\ResourceServer\BearerAuthenticationMethods
 *
 * @see https://tools.ietf.org/html/rfc6750#section-2.2
 * When sending the access token in the HTTP request entity-body, the
 * client adds the access token to the request-body using the
 * "access_token" parameter.  The client MUST NOT use this method unless
 * all of the following conditions are met:
 *
 * o  The HTTP request entity-header includes the "Content-Type" header
 * field set to "application/x-www-form-urlencoded".
 *
 * o  The entity-body follows the encoding requirements of the
 * "application/x-www-form-urlencoded" content-type as defined by
 * HTML 4.01 [W3C.REC-html401-19991224].
 *
 * o  The HTTP request entity-body is single-part.
 *
 * o  The content to be encoded in the entity-body MUST consist entirely
 * of ASCII [USASCII] characters.
 *
 * o  The HTTP request method is one for which the request-body has
 * defined semantics.  In particular, this means that the "GET"
 * method MUST NOT be used.
 *
 * The entity-body MAY include other request-specific parameters, in
 * which case the "access_token" parameter MUST be properly separated
 * from the request-specific parameters using "&" character(s) (ASCII
 * code 38).
 *
 * For example, the client makes the following HTTP request using
 * transport-layer security:
 *
 * POST /resource HTTP/1.1
 * Host: server.example.com
 * Content-Type: application/x-www-form-urlencoded
 *
 * access_token=mF_9.B5f-4.1JqM
 *
 * The "application/x-www-form-urlencoded" method SHOULD NOT be used
 * except in application contexts where participating browsers do not
 * have access to the "Authorization" request header field.  Resource
 * servers MAY support this method.
 */
class FormEncodedBodyParameter implements BearerAuthenticationMethodInterface
{
    public function support(ServerRequestInterface $request): bool
    {

    }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}

    public function authenticate(ServerRequestInterface $request): ?string
    {

    }
}

1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: Alexandre
5			* Date: 27/05/2018
6			* Time: 18:13
7			*/
8
9			namespace OAuth2\Roles\ResourceServer\BearerAuthenticationMethods;
10			use Psr\Http\Message\ServerRequestInterface;
11
12			/**
13			* Class FormEncodedBodyParameter
14			* @package OAuth2\Roles\ResourceServer\BearerAuthenticationMethods
15			*
16			* @see https://tools.ietf.org/html/rfc6750#section-2.2
17			* When sending the access token in the HTTP request entity-body, the
18			* client adds the access token to the request-body using the
19			* "access_token" parameter. The client MUST NOT use this method unless
20			* all of the following conditions are met:
21			*
22			* o The HTTP request entity-header includes the "Content-Type" header
23			* field set to "application/x-www-form-urlencoded".
24			*
25			* o The entity-body follows the encoding requirements of the
26			* "application/x-www-form-urlencoded" content-type as defined by
27			* HTML 4.01 [W3C.REC-html401-19991224].
28			*
29			* o The HTTP request entity-body is single-part.
30			*
31			* o The content to be encoded in the entity-body MUST consist entirely
32			* of ASCII [USASCII] characters.
33			*
34			* o The HTTP request method is one for which the request-body has
35			* defined semantics. In particular, this means that the "GET"
36			* method MUST NOT be used.
37			*
38			* The entity-body MAY include other request-specific parameters, in
39			* which case the "access_token" parameter MUST be properly separated
40			* from the request-specific parameters using "&" character(s) (ASCII
41			* code 38).
42			*
43			* For example, the client makes the following HTTP request using
44			* transport-layer security:
45			*
46			* POST /resource HTTP/1.1
47			* Host: server.example.com
48			* Content-Type: application/x-www-form-urlencoded
49			*
50			* access_token=mF_9.B5f-4.1JqM
51			*
52			* The "application/x-www-form-urlencoded" method SHOULD NOT be used
53			* except in application contexts where participating browsers do not
54			* have access to the "Authorization" request header field. Resource
55			* servers MAY support this method.
56			*/
57			class FormEncodedBodyParameter implements BearerAuthenticationMethodInterface
58			{
59			public function support(ServerRequestInterface $request): bool
60			{
61
62			}
			0 ignored issues – show Bug Best Practice introduced 2018-06-02 18:21 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `boolean`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
63
64			public function authenticate(ServerRequestInterface $request): ?string
65			{
66
67			}
68			}

php-guard / oauth-server

Push — master ( 8278f2...2a258c )

FormEncodedBodyParameter::support() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like