OAuth2\OpenID\Server

Complexity

Total Complexity

2

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	14	1
A	getAuthorizationEndpoint()	0	4	1

<?php
/**
 * Created by PhpStorm.
 * User: Alexandre
 * Date: 23/01/2018
 * Time: 00:10
 */

namespace OAuth2\OpenID;


use OAuth2\ClientAuthentication\Guard;
use OAuth2\OpenID\Endpoints\AuthorizationEndpoint;
use OAuth2\Providers\ResourceOwnerProviderInterface;
use OAuth2\Repositories\ClientAuthenticatorRepository;
use OAuth2\Repositories\ConfigurationRepository;
use OAuth2\Repositories\GrantTypeRepository;
use OAuth2\Repositories\ResponseTypeRepository;
use OAuth2\Repositories\StorageRepository;
use OAuth2\ScopePolicy\Manager;

class Server extends \OAuth2\Server
{
    /**
     * Server constructor.
     * @param ResourceOwnerProviderInterface $resourceOwnerProvider
     * @param null|StorageRepository $storageRepository
     * @param null|ConfigurationRepository $configurationRepository
     * @param null|ResponseTypeRepository $responseTypeRepository
     * @param null|GrantTypeRepository $grantTypeRepository
     * @param null|ClientAuthenticatorRepository $clientAuthenticatorRepository
     * @param null|Guard $guard
     * @param null|Manager $scopePolicyManager
     * @throws \Exception
     */
    public function __construct(ResourceOwnerProviderInterface $resourceOwnerProvider,
                                ?StorageRepository $storageRepository,
                                ?ConfigurationRepository $configurationRepository = null,
                                ?ResponseTypeRepository $responseTypeRepository = null,
                                ?GrantTypeRepository $grantTypeRepository = null,
                                ?ClientAuthenticatorRepository $clientAuthenticatorRepository = null,
                                ?Guard $guard = null,
                                ?Manager $scopePolicyManager = null)
    {
        parent::__construct($resourceOwnerProvider, $storageRepository, $configurationRepository,

It seems like $storageRepository defined by parameter $storageRepository on line 37 can be null; however, OAuth2\Server::__construct() does not accept null, maybe add an additional type check?

            $responseTypeRepository, $grantTypeRepository, $clientAuthenticatorRepository, $guard, $scopePolicyManager);

        $this->authorizationEndpoint = new AuthorizationEndpoint($this);
    }

    /**
     * @return \OAuth2\OpenID\Endpoints\AuthorizationEndpoint
     */
    public function getAuthorizationEndpoint(): \OAuth2\Endpoints\AuthorizationEndpoint
    {
        return $this->authorizationEndpoint;
    }
}