Guard::authenticate() - Code Metrics - Inspection of "refactor" - php-guard/oauth-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6e52f0...d9a404 )

by Alexandre

created 2018-03-04 18:01 UTC

Guard::authenticate() C

↳ Parent: Guard

Complexity

Conditions	12
Paths	13

Size

Total Lines	35
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	12
eloc	20
nc	13
nop	1
dl	0
loc	35
rs	5.1612
c	0
b	0
f	0

How to fix Complexity

<?php
/**
 * Created by PhpStorm.
 * User: Alexandre
 * Date: 07/01/2018
 * Time: 14:19
 */

namespace OAuth2OLD\ClientAuthentication;


use OAuth2OLD\ClientAuthentication\Authenticators\ClientAuthenticatorInterface;
use OAuth2OLD\Config;
use OAuth2OLD\Exceptions\OAuthException;
use OAuth2OLD\Roles\ClientInterface;
use OAuth2OLD\Server;
use Psr\Http\Message\ServerRequestInterface;

class Guard
{
    private $client;
    private $error;
    /**
     * @var Server
     */
    private $server;
    private $enforceTLS;

    /**
     * Guard constructor.
     * @param Server $server
     * @throws \Exception
     */
    public function __construct(Server $server)
    {
        $this->client = null;
        $this->error = null;
        $this->server = $server;
        $this->enforceTLS = $server->getConfigurationRepository()->getConfig(Config::ENFORCE_TLS);
    }

    /**
     * @param ServerRequestInterface $request
     * @return bool
     * @throws OAuthException
     * @throws \Exception
     * @implementation if you use other authenticators, override this method to decide
     * what authenticator the guard should use for current client
     */
    public function authenticate(ServerRequestInterface $request): bool
    {
        $clientAuthenticatorSupported = null;
        /**
         * @var ClientAuthenticatorInterface $clientAuthenticator
         */
        foreach ($this->server->getClientAuthenticatorRepository()->getClientAuthenticators() as $clientAuthenticator) {
            if ($clientAuthenticator->support($request)) {
                if ($clientAuthenticatorSupported) {
                    throw new OAuthException('invalid_client', 'Multiple authentication methods used',
                        'https://tools.ietf.org/html/rfc6749#section-5.2');
                }
                $clientAuthenticatorSupported = $clientAuthenticator;
            }
        }

        if (!$clientAuthenticatorSupported) {
            return false;
        }

        try {
            $this->client = $clientAuthenticatorSupported->authenticate($request);
        } catch (\Exception $e) {
            throw new OAuthException('invalid_client', $e->getMessage(),
                'https://tools.ietf.org/html/rfc6749#section-5.2');
        }

        if (($this->enforceTLS === true && !$this->server->isSecure()) ||
            (is_null($this->enforceTLS) && $clientAuthenticatorSupported->isPasswordAuthentication() &&
                !$this->server->isSecure() && $this->client->isTLSSupported())) {
            throw new OAuthException('access_denied', 'Require the use of TLS',
                'https://tools.ietf.org/html/rfc6749#section-3.1.2.1');
        }

        return true;
    }

    /**
     * @return null|ClientInterface
     */
    public function getClient(): ?ClientInterface
    {
        return $this->client;
    }

    /**
     * @return null|string
     */
    public function getError(): ?string
    {
        return $this->error;
    }
}

1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: Alexandre
5			* Date: 07/01/2018
6			* Time: 14:19
7			*/
8
9			namespace OAuth2OLD\ClientAuthentication;
10
11
12			use OAuth2OLD\ClientAuthentication\Authenticators\ClientAuthenticatorInterface;
13			use OAuth2OLD\Config;
14			use OAuth2OLD\Exceptions\OAuthException;
15			use OAuth2OLD\Roles\ClientInterface;
16			use OAuth2OLD\Server;
17			use Psr\Http\Message\ServerRequestInterface;
18
19			class Guard
20			{
21			private $client;
22			private $error;
23			/**
24			* @var Server
25			*/
26			private $server;
27			private $enforceTLS;
28
29			/**
30			* Guard constructor.
31			* @param Server $server
32			* @throws \Exception
33			*/
34			public function __construct(Server $server)
35			{
36			$this->client = null;
37			$this->error = null;
38			$this->server = $server;
39			$this->enforceTLS = $server->getConfigurationRepository()->getConfig(Config::ENFORCE_TLS);
40			}
41
42			/**
43			* @param ServerRequestInterface $request
44			* @return bool
45			* @throws OAuthException
46			* @throws \Exception
47			* @implementation if you use other authenticators, override this method to decide
48			* what authenticator the guard should use for current client
49			*/
50			public function authenticate(ServerRequestInterface $request): bool
51			{
52			$clientAuthenticatorSupported = null;
53			/**
54			* @var ClientAuthenticatorInterface $clientAuthenticator
55			*/
56			foreach ($this->server->getClientAuthenticatorRepository()->getClientAuthenticators() as $clientAuthenticator) {
57			if ($clientAuthenticator->support($request)) {
58			if ($clientAuthenticatorSupported) {
59			throw new OAuthException('invalid_client', 'Multiple authentication methods used',
60			'https://tools.ietf.org/html/rfc6749#section-5.2');
61			}
62			$clientAuthenticatorSupported = $clientAuthenticator;
63			}
64			}
65
66			if (!$clientAuthenticatorSupported) {
67			return false;
68			}
69
70			try {
71			$this->client = $clientAuthenticatorSupported->authenticate($request);
72			} catch (\Exception $e) {
73			throw new OAuthException('invalid_client', $e->getMessage(),
74			'https://tools.ietf.org/html/rfc6749#section-5.2');
75			}
76
77			if (($this->enforceTLS === true && !$this->server->isSecure()) \|\|
78			(is_null($this->enforceTLS) && $clientAuthenticatorSupported->isPasswordAuthentication() &&
79			!$this->server->isSecure() && $this->client->isTLSSupported())) {
80			throw new OAuthException('access_denied', 'Require the use of TLS',
81			'https://tools.ietf.org/html/rfc6749#section-3.1.2.1');
82			}
83
84			return true;
85			}
86
87			/**
88			* @return null\|ClientInterface
89			*/
90			public function getClient(): ?ClientInterface
91			{
92			return $this->client;
93			}
94
95			/**
96			* @return null\|string
97			*/
98			public function getError(): ?string
99			{
100			return $this->error;
101			}
102			}

php-guard / oauth-server

Push — master ( 6e52f0...d9a404 )

Guard::authenticate() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like