PhpEarth\Stats\Collection\UserCollection

Complexity

Total Complexity

5

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getTopUsers()	0	18	4
A	sortUsers()	0	3	1

<?php

namespace PhpEarth\Stats\Collection;

use PhpEarth\Stats\Collection;

/**
 * Class UserCollection.
 */
class UserCollection extends Collection
{
    /**
     * @var array
     */
    private $topUsers = [];

    /**
     * Returns top active members of the given period.
     *
     * @param string|null $limit
     * @param array $ignoredUsers
     *
     * @return mixed
     */
    public function getTopUsers($limit = null, array $ignoredUsers = [])
    {
        if (sizeof($this->topUsers) == 0) {
            $users = $this->data;
            usort($users, [$this, 'sortUsers']);
            $users = array_reverse($users, true);

            $this->topUsers = $users;
        }

        $topUsers = [];
        foreach ($this->topUsers as $user) {
            if (!in_array($user->getName(), $ignoredUsers)) {
                $topUsers[] = $user;
            }
        }

        return array_slice($topUsers, 0, $limit);

It seems like $limit can also be of type string; however, parameter $length of array_slice() does only seem to accept integer, maybe add an additional type check?

    }

    /**
     * For calling with usort($myArray, [$this, 'sortUsers']);.
     *
     * @param $a
     * @param $b
     *
     * @return mixed
     */
    private function sortUsers($a, $b)
    {
        return $a->getPointsCount() - $b->getPointsCount();
    }
}