Sequence - Code Metrics - Inspection of "Refactor Sequence::rotate, Set::xor" - php-ds/polyfill - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7482d8...b6686e )

by Rudi

created 2016-03-04 22:15 UTC

Sequence C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	393
Duplicated Lines	9.16 %

Coupling/Cohesion

Components	1
Dependencies	0

Metric	Value
wmc	66
lcom	1
cbo	0
dl	36
loc	393
rs	5.7474

34 Methods

Rating	Name	Duplication	Size	Complexity
A	set()	0	5	1
A	shift()	11	11	2
A	slice()	0	8	2
A	sort()	0	12	2
A	unshift()	0	7	2
A	checkRange()	0	6	3
A	getIterator()	0	6	2
A	clear()	0	5	1
A	offsetSet()	0	8	2
A	offsetGet()	0	5	1
A	offsetUnset()	0	7	4
A	offsetExists()	0	8	3
A	toArray()	0	4	1
A	merge()	0	7	1
A	count()	0	4	1
A	contains()	14	14	4
A	filter()	0	8	2
A	find()	0	4	1
A	first()	0	8	2
A	get()	0	6	1
A	insert()	0	8	3
A	join()	0	4	1
A	last()	0	8	2
A	map()	0	4	1
A	pop()	11	11	2
A	push()	0	7	2
A	pushAll()	0	8	3
A	reduce()	0	4	1
A	remove()	0	9	1
A	reverse()	0	5	1
A	__construct()	0	8	4
A	reverseRange()	0	12	2
A	normalizeRotations()	0	8	2
A	rotate()	0	15	3

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like Sequence often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use Sequence, and based on these observations, apply Extract Interface, too.

<?php
namespace Ds\Traits;

use Error;
use OutOfRangeException;
use Traversable;
use UnderflowException;

/**
 * Sequence
 *
 * @package Ds\Traits
 */
trait Sequence
{
    /**
     * @var array
     */
    private $internal = [];

    /**
     * @inheritDoc
     */
    public function __construct($values = null)
    {
        if (is_array($values) || $values instanceof Traversable) {
            $this->pushAll($values);
        } elseif (is_integer($values)) {
            $this->allocate($values);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
    }

    /**
     * @inheritdoc
     */
    public function toArray(): array
    {
        return $this->internal;
    }

    /**
     * @inheritdoc
     */
    public function merge($values): \Ds\Sequence
    {
        $merged = $this->copy();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $merged->pushAll($values);

        return $merged;
    }

    /**
     * @inheritdoc
     */
    public function count(): int
    {
        return count($this->internal);
    }

    /**
     * @inheritDoc
     */
    public function contains(...$values): bool

    {
        if ( ! $values) {

            return false;
        }

        foreach ($values as $value) {
            if ($this->find($value) === false) {
                return false;
            }
        }

        return true;
    }

    /**
     * @inheritDoc
     */
    public function filter(callable $callback = null): \Ds\Sequence
    {
        if ($callback) {
            return new self(array_filter($this->internal, $callback));
        }

        return new self(array_filter($this->internal));
    }

    /**
     * @inheritDoc
     */
    public function find($value)
    {
        return array_search($value, $this->internal, true);
    }

    /**
     * @inheritDoc
     */
    public function first()
    {
        if (empty($this->internal)) {
            throw new UnderflowException();
        }

        return $this->internal[0];
    }

    /**
     * @inheritDoc
     */
    public function get(int $index)
    {
        $this->checkRange($index);

        return $this->internal[$index];
    }

    /**
     * @inheritDoc
     */
    public function insert(int $index, ...$values)
    {
        if ($index < 0 || $index > count($this->internal)) {
            throw new OutOfRangeException();
        }

        array_splice($this->internal, $index, 0, $values);
    }

    /**
     * @inheritDoc
     */
    public function join(string $glue = null): string
    {
        return implode($glue, $this->internal);
    }

    /**
     * @inheritDoc
     */
    public function last()
    {
        if ($this->isEmpty()) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            throw new UnderflowException();
        }

        return end($this->internal);
    }

    /**
     * @inheritDoc
     */
    public function map(callable $callback): \Ds\Sequence
    {
        return new self(array_map($callback, $this->internal));
    }

    /**
     * @inheritDoc
     */
    public function pop()

    {
        if ($this->isEmpty()) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            throw new UnderflowException();
        }

        $value = array_pop($this->internal);
        $this->adjustCapacity();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return $value;
    }

    /**
     * @inheritDoc
     */
    public function push(...$values)
    {
        if ($values) {

            array_push($this->internal, ...$values);
            $this->adjustCapacity();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
    }

    /**
     * @inheritDoc
     */
    public function pushAll($values)
    {
        if ( ! is_array($values) && ! $values instanceof Traversable) {
            throw new Error();
        }

        $this->push(...$values);
    }

    /**
     * @inheritDoc
     */
    public function reduce(callable $callback, $initial = null)
    {
        return array_reduce($this->internal, $callback, $initial);
    }

    /**
     * @inheritDoc
     */
    public function remove(int $index)
    {
        $this->checkRange($index);

        $value = array_splice($this->internal, $index, 1, null)[0];
        $this->adjustCapacity();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return $value;
    }

    /**
     * @inheritDoc
     */
    public function reverse(): \Ds\Sequence
    {
        return new self(array_reverse($this->internal));

    }

    private function reverseRange(int $a, int $b)
    {
        $swap = function(&$a, &$b) {
            $t = $a;
            $a = $b;
            $b = $t;
        };

        while (--$b > $a) {
            $swap($this->internal[$a++], $this->internal[$b--]);
        }
    }

    private function normalizeRotations(int $rotations, int $count)
    {
        if ($rotations < 0) {
            return $count - (abs($rotations) % $count);
        }

        return $rotations % $count;
    }

    /**
     * @inheritDoc
     */
    public function rotate(int $rotations)
    {
        if ($this->isEmpty()) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            return;
        }

        $n = count($this);
        $r = $this->normalizeRotations($rotations, $n);

        if ($r > 0) {
            $this->reverseRange(0,  $r);
            $this->reverseRange($r, $n);
            $this->reverseRange(0,  $n);
        }
    }

    /**
     * @inheritDoc
     */
    public function set(int $index, $value)
    {
        $this->checkRange($index);
        $this->internal[$index] = $value;
    }

    /**
     * @inheritDoc
     */
    public function shift()

    {
        if ($this->isEmpty()) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            throw new UnderflowException();
        }

        $value = array_shift($this->internal);
        $this->adjustCapacity();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return $value;
    }

    /**
     * @inheritDoc
     */
    public function slice(int $offset, int $length = null): \Ds\Sequence
    {
        if (func_num_args() === 1) {
            return new self(array_slice($this->internal, $offset));
        }

        return new self(array_slice($this->internal, $offset, $length));
    }

    /**
     * @inheritDoc
     */
    public function sort(callable $comparator = null): \Ds\Sequence
    {
        $internal = $this->internal;

        if ($comparator) {
            usort($internal, $comparator);
        } else {
            sort($internal);
        }

        return new self($internal);
    }

    /**
     * @inheritDoc
     */
    public function unshift(...$values)
    {
        if ($values) {

            array_unshift($this->internal, ...$values);
            $this->adjustCapacity();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
    }

    /**
     * Check Range
     *
     * @param int $index
     */
    private function checkRange(int $index)
    {
        if ($index < 0 || $index >= count($this->internal)) {
            throw new OutOfRangeException();
        }
    }

    /**
     * Get Iterator
     */
    public function getIterator()
    {
        foreach ($this->internal as $value) {
            yield $value;
        }
    }

    /**
     *
     */
    public function clear()
    {
        $this->internal = [];
        $this->capacity = self::MIN_CAPACITY;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * @inheritdoc
     */
    public function offsetSet($offset, $value)
    {
        if ($offset === null) {
            $this->push($value);
        } else {
            $this->set($offset, $value);
        }
    }

    /**
     * @inheritdoc
     */
    public function &offsetGet($offset)
    {
        $this->checkRange($offset);
        return $this->internal[$offset];
    }

    /**
     * @inheritdoc
     */
    public function offsetUnset($offset)
    {
        // Unset should be quiet, so we shouldn't allow 'remove' to throw.
        if (is_integer($offset) && $offset >= 0 && $offset < count($this)) {
            $this->remove($offset);
        }
    }

    /**
     * @inheritdoc
     */
    public function offsetExists($offset)
    {
        if ($offset < 0 || $offset >= count($this)) {
            return false;
        }

        return $this->get($offset) !== null;
    }
}


1		<?php
2		namespace Ds\Traits;
3
4		use Error;
5		use OutOfRangeException;
6		use Traversable;
7		use UnderflowException;
8
9		/**
10		* Sequence
11		*
12		* @package Ds\Traits
13		*/
14		trait Sequence
15		{
16		/**
17		* @var array
18		*/
19		private $internal = [];
20
21		/**
22		* @inheritDoc
23		*/
24		public function __construct($values = null)
25		{
26		if (is_array($values) \|\| $values instanceof Traversable) {
27		$this->pushAll($values);
28		} elseif (is_integer($values)) {
29		$this->allocate($values);
		0 ignored issues – show Bug introduced 2016-03-01 00:43 UTC by Report Bug Copy Issue Report It seems like `allocate()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
30		}
31		}
32
33		/**
34		* @inheritdoc
35		*/
36		public function toArray(): array
37		{
38		return $this->internal;
39		}
40
41		/**
42		* @inheritdoc
43		*/
44		public function merge($values): \Ds\Sequence
45		{
46		$merged = $this->copy();
		0 ignored issues – show Bug introduced 2016-03-01 00:43 UTC by Report Bug Copy Issue Report It seems like `copy()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
47		$merged->pushAll($values);
48
49		return $merged;
50		}
51
52		/**
53		* @inheritdoc
54		*/
55		public function count(): int
56		{
57		return count($this->internal);
58		}
59
60		/**
61		* @inheritDoc
62		*/
63	View Code Duplication	public function contains(...$values): bool
		0 ignored issues – show Duplication introduced 2016-03-01 00:43 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
64		{
65		if ( ! $values) {
		0 ignored issues – show Bug Best Practice introduced 2016-03-01 00:43 UTC by Report Bug Copy Issue Report The expression `$values` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
66		return false;
67		}
68
69		foreach ($values as $value) {
70		if ($this->find($value) === false) {
71		return false;
72		}
73		}
74
75		return true;
76		}
77
78		/**
79		* @inheritDoc
80		*/
81		public function filter(callable $callback = null): \Ds\Sequence
82		{
83		if ($callback) {
84		return new self(array_filter($this->internal, $callback));
85		}
86
87		return new self(array_filter($this->internal));
88		}
89
90		/**
91		* @inheritDoc
92		*/
93		public function find($value)
94		{
95		return array_search($value, $this->internal, true);
96		}
97
98		/**
99		* @inheritDoc
100		*/
101		public function first()
102		{
103		if (empty($this->internal)) {
104		throw new UnderflowException();
105		}
106
107		return $this->internal[0];
108		}
109
110		/**
111		* @inheritDoc
112		*/
113		public function get(int $index)
114		{
115		$this->checkRange($index);
116
117		return $this->internal[$index];
118		}
119
120		/**
121		* @inheritDoc
122		*/
123		public function insert(int $index, ...$values)
124		{
125		if ($index < 0 \|\| $index > count($this->internal)) {
126		throw new OutOfRangeException();
127		}
128
129		array_splice($this->internal, $index, 0, $values);
130		}
131
132		/**
133		* @inheritDoc
134		*/
135		public function join(string $glue = null): string
136		{
137		return implode($glue, $this->internal);
138		}
139
140		/**
141		* @inheritDoc
142		*/
143		public function last()
144		{
145		if ($this->isEmpty()) {
		0 ignored issues – show Bug introduced 2016-03-01 00:43 UTC by Report Bug Copy Issue Report It seems like `isEmpty()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
146		throw new UnderflowException();
147		}
148
149		return end($this->internal);
150		}
151
152		/**
153		* @inheritDoc
154		*/
155		public function map(callable $callback): \Ds\Sequence
156		{
157		return new self(array_map($callback, $this->internal));
158		}
159
160		/**
161		* @inheritDoc
162		*/
163	View Code Duplication	public function pop()
		0 ignored issues – show Duplication introduced 2016-03-01 00:43 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
164		{
165		if ($this->isEmpty()) {
		0 ignored issues – show Bug introduced 2016-03-01 00:43 UTC by Report Bug Copy Issue Report It seems like `isEmpty()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
166		throw new UnderflowException();
167		}
168
169		$value = array_pop($this->internal);
170		$this->adjustCapacity();
		0 ignored issues – show Bug introduced 2016-03-01 00:43 UTC by Report Bug Copy Issue Report It seems like `adjustCapacity()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
171
172		return $value;
173		}
174
175		/**
176		* @inheritDoc
177		*/
178		public function push(...$values)
179		{
180		if ($values) {
		0 ignored issues – show Bug Best Practice introduced 2016-03-01 00:43 UTC by Report Bug Copy Issue Report The expression `$values` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
181		array_push($this->internal, ...$values);
182		$this->adjustCapacity();
		0 ignored issues – show Bug introduced 2016-03-01 00:43 UTC by Report Bug Copy Issue Report It seems like `adjustCapacity()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
183		}
184		}
185
186		/**
187		* @inheritDoc
188		*/
189		public function pushAll($values)
190		{
191		if ( ! is_array($values) && ! $values instanceof Traversable) {
192		throw new Error();
193		}
194
195		$this->push(...$values);
196		}
197
198		/**
199		* @inheritDoc
200		*/
201		public function reduce(callable $callback, $initial = null)
202		{
203		return array_reduce($this->internal, $callback, $initial);
204		}
205
206		/**
207		* @inheritDoc
208		*/
209		public function remove(int $index)
210		{
211		$this->checkRange($index);
212
213		$value = array_splice($this->internal, $index, 1, null)[0];
214		$this->adjustCapacity();
		0 ignored issues – show Bug introduced 2016-03-01 00:43 UTC by Report Bug Copy Issue Report It seems like `adjustCapacity()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
215
216		return $value;
217		}
218
219		/**
220		* @inheritDoc
221		*/
222		public function reverse(): \Ds\Sequence
223		{
224		return new self(array_reverse($this->internal));
225
226		}
227
228		private function reverseRange(int $a, int $b)
229		{
230		$swap = function(&$a, &$b) {
231		$t = $a;
232		$a = $b;
233		$b = $t;
234		};
235
236		while (--$b > $a) {
237		$swap($this->internal[$a++], $this->internal[$b--]);
238		}
239		}
240
241		private function normalizeRotations(int $rotations, int $count)
242		{
243		if ($rotations < 0) {
244		return $count - (abs($rotations) % $count);
245		}
246
247		return $rotations % $count;
248		}
249
250		/**
251		* @inheritDoc
252		*/
253		public function rotate(int $rotations)
254		{
255		if ($this->isEmpty()) {
		0 ignored issues – show Bug introduced 2016-03-01 00:43 UTC by Report Bug Copy Issue Report It seems like `isEmpty()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
256		return;
257		}
258
259		$n = count($this);
260		$r = $this->normalizeRotations($rotations, $n);
261
262		if ($r > 0) {
263		$this->reverseRange(0, $r);
264		$this->reverseRange($r, $n);
265		$this->reverseRange(0, $n);
266		}
267		}
268
269		/**
270		* @inheritDoc
271		*/
272		public function set(int $index, $value)
273		{
274		$this->checkRange($index);
275		$this->internal[$index] = $value;
276		}
277
278		/**
279		* @inheritDoc
280		*/
281	View Code Duplication	public function shift()
		0 ignored issues – show Duplication introduced 2016-03-01 00:43 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
282		{
283		if ($this->isEmpty()) {
		0 ignored issues – show Bug introduced 2016-03-01 00:43 UTC by Report Bug Copy Issue Report It seems like `isEmpty()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
284		throw new UnderflowException();
285		}
286
287		$value = array_shift($this->internal);
288		$this->adjustCapacity();
		0 ignored issues – show Bug introduced 2016-03-01 00:43 UTC by Report Bug Copy Issue Report It seems like `adjustCapacity()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
289
290		return $value;
291		}
292
293		/**
294		* @inheritDoc
295		*/
296		public function slice(int $offset, int $length = null): \Ds\Sequence
297		{
298		if (func_num_args() === 1) {
299		return new self(array_slice($this->internal, $offset));
300		}
301
302		return new self(array_slice($this->internal, $offset, $length));
303		}
304
305		/**
306		* @inheritDoc
307		*/
308		public function sort(callable $comparator = null): \Ds\Sequence
309		{
310		$internal = $this->internal;
311
312		if ($comparator) {
313		usort($internal, $comparator);
314		} else {
315		sort($internal);
316		}
317
318		return new self($internal);
319		}
320
321		/**
322		* @inheritDoc
323		*/
324		public function unshift(...$values)
325		{
326		if ($values) {
		0 ignored issues – show Bug Best Practice introduced 2016-03-01 00:43 UTC by Report Bug Copy Issue Report The expression `$values` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
327		array_unshift($this->internal, ...$values);
328		$this->adjustCapacity();
		0 ignored issues – show Bug introduced 2016-03-01 00:43 UTC by Report Bug Copy Issue Report It seems like `adjustCapacity()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
329		}
330		}
331
332		/**
333		* Check Range
334		*
335		* @param int $index
336		*/
337		private function checkRange(int $index)
338		{
339		if ($index < 0 \|\| $index >= count($this->internal)) {
340		throw new OutOfRangeException();
341		}
342		}
343
344		/**
345		* Get Iterator
346		*/
347		public function getIterator()
348		{
349		foreach ($this->internal as $value) {
350		yield $value;
351		}
352		}
353
354		/**
355		*
356		*/
357		public function clear()
358		{
359		$this->internal = [];
360		$this->capacity = self::MIN_CAPACITY;
		0 ignored issues – show Bug introduced 2016-03-01 00:43 UTC by Report Bug Copy Issue Report The property `capacity` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
361		}
362
363		/**
364		* @inheritdoc
365		*/
366		public function offsetSet($offset, $value)
367		{
368		if ($offset === null) {
369		$this->push($value);
370		} else {
371		$this->set($offset, $value);
372		}
373		}
374
375		/**
376		* @inheritdoc
377		*/
378		public function &offsetGet($offset)
379		{
380		$this->checkRange($offset);
381		return $this->internal[$offset];
382		}
383
384		/**
385		* @inheritdoc
386		*/
387		public function offsetUnset($offset)
388		{
389		// Unset should be quiet, so we shouldn't allow 'remove' to throw.
390		if (is_integer($offset) && $offset >= 0 && $offset < count($this)) {
391		$this->remove($offset);
392		}
393		}
394
395		/**
396		* @inheritdoc
397		*/
398		public function offsetExists($offset)
399		{
400		if ($offset < 0 \|\| $offset >= count($this)) {
401		return false;
402		}
403
404		return $this->get($offset) !== null;
405		}
406		}
407

php-ds / polyfill