Ds\Traits\Collection

Complexity

Total Complexity

5

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	isEmpty()	0	4	1
A	jsonSerialize()	0	4	1
A	copy()	0	4	1
	toArray()	0	1	?
A	__debugInfo()	0	4	1
A	__toString()	0	4	1

<?php
namespace Ds\Traits;

/**
 * Collection
 *
 * @package Ds\Traits
 */
trait Collection
{
    /**
     * Returns whether the collection is empty.
     *
     * This should be equivalent to a count of zero, but is not required.
     * Implementations should define what empty means in their own context.
     *
     * @return bool
     */
    public function isEmpty(): bool
    {
        return count($this) === 0;
    }

    /**
     * Json Serialize
     *
     * @return string

Should the return type not be array? Also, consider making the array more specific, something like array<String>, or String[].

     */
    public function jsonSerialize()
    {
        return $this->toArray();
    }

    /**
     * Creates a copy of the collection.
     *
     * @return self

Should the return type not be \Ds\Collection?

     */
    public function copy(): \Ds\Collection
    {
        return new self($this);

The call to Collection::__construct() has too many arguments starting with $this.

    }

    /**
     * Returns an array representation of the collection.
     *
     * The format of the returned array is implementation-dependent.
     * Some implementations may throw an exception if an array representation
     * could not be created.
     *
     * @return array
     */
    abstract public function toArray(): array;

    /**
     * Debug Info
     */
    public function __debugInfo()
    {
        return $this->toArray();
    }

    /**
     * To String
     */
    public function __toString()
    {
        return 'object(' . get_class($this) . ')';
    }
}