Issues in InheritCheckerAspect.php (master) - Issues in master - php-deal/framework - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Aspect/InheritCheckerAspect.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace PhpDeal\Aspect;

use Doctrine\Common\Annotations\Reader;
use Go\Aop\Aspect;
use Go\Aop\Intercept\MethodInvocation;
use Go\Aop\Support\AnnotatedReflectionMethod;
use Go\Lang\Annotation\Around;
use PhpDeal\Annotation\Ensure;
use PhpDeal\Annotation\Invariant;
use PhpDeal\Annotation\Verify;
use PhpDeal\Contract\Fetcher\Parent\InvariantFetcher;
use PhpDeal\Contract\Fetcher\Parent\MethodConditionFetcher;
use PhpDeal\Exception\ContractViolation;
use ReflectionClass;
use ReflectionMethod;

class InheritCheckerAspect extends AbstractContractAspect implements Aspect
{
    /**
     * @var MethodConditionFetcher
     */
    private $methodConditionFetcher;

    /** @var InvariantFetcher */
    private $invariantFetcher;

    public function __construct(Reader $reader)
    {
        parent::__construct($reader);
        $this->methodConditionFetcher = new MethodConditionFetcher([
            Ensure::class,
            Verify::class,
            Invariant::class
        ], $reader);
        $this->invariantFetcher = new InvariantFetcher([Invariant::class], $reader);
    }

    /**
     * Verifies inherit contracts for the method
     *
     * @Around("@execution(PhpDeal\Annotation\Inherit)")
     * @param MethodInvocation $invocation
     *
     * @throws ContractViolation
     * @throws \ReflectionException
     * @return mixed
     */
    public function inheritMethodContracts(MethodInvocation $invocation)
    {
        $object = $invocation->getThis();
        $args   = $this->fetchMethodArguments($invocation);
        $class  = $invocation->getMethod()->getDeclaringClass();
        if (\is_object($object) && $class->isCloneable()) {
            $args['__old'] = clone $object;
        }

        $result = $invocation->proceed();
        $args['__result'] = $result;
        $allContracts = $this->fetchMethodContracts($invocation);

        $this->ensureContracts($invocation, $allContracts, $object, $class->name, $args);

        return $result;
    }

    /**
     * @Around("@within(PhpDeal\Annotation\Inherit) && execution(public **->*(*))")
     * @param MethodInvocation $invocation
     * @return mixed
     * @throws \ReflectionException
     */
    public function inheritClassContracts(MethodInvocation $invocation)
    {
        $object = $invocation->getThis();
        $args   = $this->fetchMethodArguments($invocation);
        $class  = $invocation->getMethod()->getDeclaringClass();
        if (\is_object($object) && $class->isCloneable()) {
            $args['__old'] = clone $object;
        }

        $result = $invocation->proceed();
        $args['__result'] = $result;

        $allContracts = $this->fetchClassContracts($class);
        $this->ensureContracts($invocation, $allContracts, $object, $class->name, $args);

        return $result;
    }

    /**
     * @param MethodInvocation $invocation
     * @return array
     * @throws \ReflectionException
     */
    private function fetchMethodContracts(MethodInvocation $invocation): array
    {
        $allContracts = $this->fetchParentsMethodContracts($invocation);
        /** @var ReflectionMethod&AnnotatedReflectionMethod $reflectionMethod */

        $reflectionMethod = $invocation->getMethod();

        foreach ($reflectionMethod->getAnnotations() as $annotation) {
            $annotationClass = \get_class($annotation);

            if (\in_array($annotationClass, [Ensure::class, Verify::class, Invariant::class], true)) {
                $allContracts[] = $annotation;
            }
        }

        return \array_unique($allContracts);
    }

    /**
     * @param MethodInvocation $invocation
     * @return array
     * @throws \ReflectionException
     */
    private function fetchParentsMethodContracts(MethodInvocation $invocation): array
    {
        return $this->methodConditionFetcher->getConditions(
            $invocation->getMethod()->getDeclaringClass(),
            $invocation->getMethod()->name
        );
    }

    /**
     * @param ReflectionClass $class
     * @return array
     */
    private function fetchClassContracts(ReflectionClass $class): array
    {
        $allContracts = $this->invariantFetcher->getConditions($class);
        foreach ($this->reader->getClassAnnotations($class) as $annotation) {
            if ($annotation instanceof Invariant) {
                $allContracts[] = $annotation;
            }
        }

        return \array_unique($allContracts);
    }
}


1		<?php
2
3		namespace PhpDeal\Aspect;
4
5		use Doctrine\Common\Annotations\Reader;
6		use Go\Aop\Aspect;
7		use Go\Aop\Intercept\MethodInvocation;
8		use Go\Aop\Support\AnnotatedReflectionMethod;
9		use Go\Lang\Annotation\Around;
10		use PhpDeal\Annotation\Ensure;
11		use PhpDeal\Annotation\Invariant;
12		use PhpDeal\Annotation\Verify;
13		use PhpDeal\Contract\Fetcher\Parent\InvariantFetcher;
14		use PhpDeal\Contract\Fetcher\Parent\MethodConditionFetcher;
15		use PhpDeal\Exception\ContractViolation;
16		use ReflectionClass;
17		use ReflectionMethod;
18
19		class InheritCheckerAspect extends AbstractContractAspect implements Aspect
20		{
21		/**
22		* @var MethodConditionFetcher
23		*/
24		private $methodConditionFetcher;
25
26		/** @var InvariantFetcher */
27		private $invariantFetcher;
28
29		public function __construct(Reader $reader)
30		{
31		parent::__construct($reader);
32		$this->methodConditionFetcher = new MethodConditionFetcher([
33		Ensure::class,
34		Verify::class,
35		Invariant::class
36		], $reader);
37		$this->invariantFetcher = new InvariantFetcher([Invariant::class], $reader);
38		}
39
40		/**
41		* Verifies inherit contracts for the method
42		*
43		* @Around("@execution(PhpDeal\Annotation\Inherit)")
44		* @param MethodInvocation $invocation
45		*
46		* @throws ContractViolation
47		* @throws \ReflectionException
48		* @return mixed
49		*/
50	2	public function inheritMethodContracts(MethodInvocation $invocation)
51		{
52	2	$object = $invocation->getThis();
53	2	$args = $this->fetchMethodArguments($invocation);
54	2	$class = $invocation->getMethod()->getDeclaringClass();
55	2	if (\is_object($object) && $class->isCloneable()) {
56	2	$args['__old'] = clone $object;
57		}
58
59	2	$result = $invocation->proceed();
60	2	$args['__result'] = $result;
61	2	$allContracts = $this->fetchMethodContracts($invocation);
62
63	2	$this->ensureContracts($invocation, $allContracts, $object, $class->name, $args);
64
65	1	return $result;
66		}
67
68		/**
69		* @Around("@within(PhpDeal\Annotation\Inherit) && execution(public *->(*))")
70		* @param MethodInvocation $invocation
71		* @return mixed
72		* @throws \ReflectionException
73		*/
74		public function inheritClassContracts(MethodInvocation $invocation)
75		{
76		$object = $invocation->getThis();
77		$args = $this->fetchMethodArguments($invocation);
78		$class = $invocation->getMethod()->getDeclaringClass();
79		if (\is_object($object) && $class->isCloneable()) {
80		$args['__old'] = clone $object;
81		}
82
83		$result = $invocation->proceed();
84		$args['__result'] = $result;
85
86		$allContracts = $this->fetchClassContracts($class);
87		$this->ensureContracts($invocation, $allContracts, $object, $class->name, $args);
88
89		return $result;
90		}
91
92		/**
93		* @param MethodInvocation $invocation
94		* @return array
95		* @throws \ReflectionException
96		*/
97	2	private function fetchMethodContracts(MethodInvocation $invocation): array
98		{
99	2	$allContracts = $this->fetchParentsMethodContracts($invocation);
100		/** @var ReflectionMethod&AnnotatedReflectionMethod $reflectionMethod */
		0 ignored issues – show Documentation introduced 2020-04-29 22:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this The doc-type `ReflectionMethod&AnnotatedReflectionMethod` could not be parsed: Unknown type name "ReflectionMethod&AnnotatedReflectionMethod" at position 0. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
101	2	$reflectionMethod = $invocation->getMethod();
102
103	2	foreach ($reflectionMethod->getAnnotations() as $annotation) {
104	2	$annotationClass = \get_class($annotation);
105
106	2	if (\in_array($annotationClass, [Ensure::class, Verify::class, Invariant::class], true)) {
107		$allContracts[] = $annotation;
108		}
109		}
110
111	2	return \array_unique($allContracts);
112		}
113
114		/**
115		* @param MethodInvocation $invocation
116		* @return array
117		* @throws \ReflectionException
118		*/
119	2	private function fetchParentsMethodContracts(MethodInvocation $invocation): array
120		{
121	2	return $this->methodConditionFetcher->getConditions(
122	2	$invocation->getMethod()->getDeclaringClass(),
123	2	$invocation->getMethod()->name
124		);
125		}
126
127		/**
128		* @param ReflectionClass $class
129		* @return array
130		*/
131		private function fetchClassContracts(ReflectionClass $class): array
132		{
133		$allContracts = $this->invariantFetcher->getConditions($class);
134		foreach ($this->reader->getClassAnnotations($class) as $annotation) {
135		if ($annotation instanceof Invariant) {
136		$allContracts[] = $annotation;
137		}
138		}
139
140		return \array_unique($allContracts);
141		}
142		}
143

php-deal / framework

Issues (4)

Security Analysis no request data

src/Aspect/InheritCheckerAspect.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like