PhpDeal\Contract\PostconditionContract

Complexity

Total Complexity

6

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	check()	0	17	2
A	fetchAllContracts()	0	11	3
A	fetchParentsContracts()	0	8	1

<?php
/**
 * PHP Deal framework
 *
 * @copyright Copyright 2014, Lisachenko Alexander <lisachenko.it@gmail.com>
 *
 * This source file is subject to the license that is bundled
 * with this source code in the file LICENSE.
 */

namespace PhpDeal\Contract;

use Go\Aop\Intercept\MethodInvocation;
use PhpDeal\Contract\Fetcher\ParentClass\MethodConditionFetcher;
use PhpDeal\Exception\ContractViolation;
use PhpDeal\Annotation\Ensure;

class PostconditionContract extends Contract
{
    /**
     * @param MethodInvocation $invocation
     * @throws ContractViolation
     * @return mixed
     */
    public function check(MethodInvocation $invocation)
    {
        $object = $invocation->getThis();
        $args   = $this->getMethodArguments($invocation);
        $class  = $invocation->getMethod()->getDeclaringClass();
        if ($class->isCloneable()) {
            $args['__old'] = clone $object;
        }

        $result = $invocation->proceed();
        $args['__result'] = $result;
        $allContracts = $this->makeContractsUnique($this->fetchAllContracts($invocation));

        $this->fulfillContracts($allContracts, $object, $class->name, $args, $invocation);

It seems like $object defined by $invocation->getThis() on line 27 can also be of type string; however, PhpDeal\Contract\Contract::fulfillContracts() does only seem to accept object, maybe add an additional type check?

        return $result;
    }

    /**
     * @param MethodInvocation $invocation
     * @return array
     */
    private function fetchAllContracts(MethodInvocation $invocation)
    {
        $allContracts = $this->fetchParentsContracts($invocation);
        foreach ($invocation->getMethod()->getAnnotations() as $annotation) {
            if ($annotation instanceof Ensure) {
                $allContracts[] = $annotation;
            }
        }

        return $allContracts;
    }

    /**
     * @param MethodInvocation $invocation
     * @return array
     */
    private function fetchParentsContracts(MethodInvocation $invocation)
    {
        return (new MethodConditionFetcher(Ensure::class))->getConditions(
            $invocation->getMethod()->getDeclaringClass(),
            $this->reader,

It seems like $this->reader can be null; however, getConditions() does not accept null, maybe add an additional type check?

            $invocation->getMethod()->getName()

Consider using $invocation->getMethod()->name. There is an issue with getName() and APC-enabled PHP versions.

        );
    }
}