Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
14 | View Code Duplication | abstract class AbstractEvent implements Serializable |
|
|
|||
15 | { |
||
16 | use PopulatePropertiesTrait; |
||
17 | |||
18 | /** |
||
19 | * Get the aggregate root from which is the event is triggered. |
||
20 | * |
||
21 | * @var AbstractAggregateRoot |
||
22 | */ |
||
23 | public $aggregateRoot; |
||
24 | |||
25 | /** |
||
26 | * @var Author |
||
27 | */ |
||
28 | public $author; |
||
29 | |||
30 | /** |
||
31 | * @var DateTime |
||
32 | */ |
||
33 | public $date; |
||
34 | |||
35 | /** |
||
36 | * @param array $data The list of properties values. The key represent the property name. |
||
37 | */ |
||
38 | public function __construct(array $data = []) |
||
46 | } |
||
47 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.