ProxyFactory::checkProxyDirectory() - Code Metrics - Inspection of "Support for simple cache (#75)" - php-cache/cache-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3a0f53...56ae52 )

by Tobias

created 2017-07-30 21:16 UTC

ProxyFactory::checkProxyDirectory() A

↳ Parent: ProxyFactory

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	6
rs	9.4285
cc	2
eloc	3
nc	2
nop	0

<?php

/*
 * This file is part of php-cache\cache-bundle package.
 *
 * (c) 2015-2015 Aaron Scherer <[email protected]>, Tobias Nyholm <[email protected]>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Cache\CacheBundle\DataCollector;

/**
 * Generate proxies over your cache pool. This should only be used in development.
 *
 * @author Tobias Nyholm <[email protected]>
 */
class ProxyFactory
{
    /**
     * @type string
     */
    private $proxyDirectory;

    /**
     * @param string $proxyDirectory
     */
    public function __construct($proxyDirectory)
    {
        $this->proxyDirectory = $proxyDirectory;
    }

    /**
     * Create a proxy that handles data collecting better.
     *
     * @param string $class
     * @param string &$proxyFile where we store the proxy class
     *
     * @return string the name of a much much better class
     */
    public function createProxy($class, &$proxyFile = null)
    {
        $proxyClass = $this->getProxyClass($class);
        $class      = '\\'.rtrim($class, '\\');
        $proxyFile  = $this->proxyDirectory.'/'.$proxyClass.'.php';

        if (class_exists($proxyClass)) {
            return $proxyClass;
        }

        $content = file_get_contents(dirname(__DIR__).'/Resources/proxy/template.php');
        $content = str_replace('__TPL_CLASS__', $proxyClass, $content);
        $content = str_replace('__TPL_EXTENDS__', $class, $content);

        $this->checkProxyDirectory();
        file_put_contents($proxyFile, $content);
        require $proxyFile;

        return $proxyClass;
    }

    private function checkProxyDirectory()
    {
        if (!is_dir($this->proxyDirectory)) {
            @mkdir($this->proxyDirectory, 0777, true);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        }
    }

    private function getProxyClass($namespace)
    {
        return 'php_cache_proxy_'.str_replace('\\', '_', $namespace);
    }
}


1			<?php
2
3			/*
4			* This file is part of php-cache\cache-bundle package.
5			*
6			* (c) 2015-2015 Aaron Scherer <[email protected]>, Tobias Nyholm <[email protected]>
7			*
8			* This source file is subject to the MIT license that is bundled
9			* with this source code in the file LICENSE.
10			*/
11
12			namespace Cache\CacheBundle\DataCollector;
13
14			/**
15			* Generate proxies over your cache pool. This should only be used in development.
16			*
17			* @author Tobias Nyholm <[email protected]>
18			*/
19			class ProxyFactory
20			{
21			/**
22			* @type string
23			*/
24			private $proxyDirectory;
25
26			/**
27			* @param string $proxyDirectory
28			*/
29			public function __construct($proxyDirectory)
30			{
31			$this->proxyDirectory = $proxyDirectory;
32			}
33
34			/**
35			* Create a proxy that handles data collecting better.
36			*
37			* @param string $class
38			* @param string &$proxyFile where we store the proxy class
39			*
40			* @return string the name of a much much better class
41			*/
42			public function createProxy($class, &$proxyFile = null)
43			{
44			$proxyClass = $this->getProxyClass($class);
45			$class = '\\'.rtrim($class, '\\');
46			$proxyFile = $this->proxyDirectory.'/'.$proxyClass.'.php';
47
48			if (class_exists($proxyClass)) {
49			return $proxyClass;
50			}
51
52			$content = file_get_contents(dirname(__DIR__).'/Resources/proxy/template.php');
53			$content = str_replace('__TPL_CLASS__', $proxyClass, $content);
54			$content = str_replace('__TPL_EXTENDS__', $class, $content);
55
56			$this->checkProxyDirectory();
57			file_put_contents($proxyFile, $content);
58			require $proxyFile;
59
60			return $proxyClass;
61			}
62
63			private function checkProxyDirectory()
64			{
65			if (!is_dir($this->proxyDirectory)) {
66			@mkdir($this->proxyDirectory, 0777, true);
			0 ignored issues – show Security Best Practice introduced 2017-07-30 21:37 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
67			}
68			}
69
70			private function getProxyClass($namespace)
71			{
72			return 'php_cache_proxy_'.str_replace('\\', '_', $namespace);
73			}
74			}
75

php-cache / cache-bundle

Push — master ( 3a0f53...56ae52 )

ProxyFactory::checkProxyDirectory() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like