Client::conditions() - Code Metrics - Inspection of "Sync client and conditions example" - php-api-clients/weather-underground - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c53f04...81ef41 )

by Cees-Jan

created 2017-02-05 17:17 UTC

Client::conditions() A

↳ Parent: Client

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	7
ccs	0
cts	0
cp	0
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	1
crap	2

<?php declare(strict_types=1);

namespace ApiClients\Client\WeatherUnderground;

use ApiClients\Client\WeatherUnderground\Resource\ConditionInterface;
use ApiClients\Client\WeatherUnderground\Resource\UserInterface;
use React\EventLoop\Factory;
use React\EventLoop\LoopInterface;
use function Clue\React\Block\await;

final class Client
{
    /**
     * @var LoopInterface
     */
    private $loop;

    /**
     * @var AsyncClient
     */
    private $client;

    public function __construct(string $token)
    {
        $this->loop = Factory::create();
        $this->client = AsyncClient::create($this->loop, $token);

    }

    public function conditions(string $location): ConditionInterface
    {
        return await(
            $this->client->conditions($location),
            $this->loop
        );
    }
}


1			<?php declare(strict_types=1);
2
3			namespace ApiClients\Client\WeatherUnderground;
4
5			use ApiClients\Client\WeatherUnderground\Resource\ConditionInterface;
6			use ApiClients\Client\WeatherUnderground\Resource\UserInterface;
7			use React\EventLoop\Factory;
8			use React\EventLoop\LoopInterface;
9			use function Clue\React\Block\await;
10
11			final class Client
12			{
13			/**
14			* @var LoopInterface
15			*/
16			private $loop;
17
18			/**
19			* @var AsyncClient
20			*/
21			private $client;
22
23			public function __construct(string $token)
24			{
25			$this->loop = Factory::create();
26			$this->client = AsyncClient::create($this->loop, $token);
			0 ignored issues – show Documentation Bug introduced 2017-02-05 17:26 UTC by Report Bug Copy Issue Report It seems like `\ApiClients\Client\Weath...te($this->loop, $token)` of type `object<self>` is incompatible with the declared type `object<ApiClients\Client...nderground\AsyncClient>` of property `$client`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
27			}
28
29			public function conditions(string $location): ConditionInterface
30			{
31			return await(
32			$this->client->conditions($location),
33			$this->loop
34			);
35			}
36			}
37

php-api-clients / weather-underground

GitHub Access Token became invalid

Push — master ( c53f04...81ef41 )

Client::conditions() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like