Profile::putProfile() - Code Metrics - Inspection of "Merge pull request #4 from php-api-clients/feature..." - php-api-clients/twitter - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 61a149...5b9c21 )

by Cees-Jan

created 2016-12-11 15:52 UTC

Profile::putProfile() A

↳ Parent: Profile

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
dl	0
loc	12
ccs	0
cts	10
cp	0
rs	9.4285
c	2
b	0
f	0
cc	1
eloc	8
nc	1
nop	0
crap	2

<?php declare(strict_types=1);

namespace ApiClients\Client\Twitter\Resource\Sync;

use ApiClients\Client\Twitter\Resource\Async\Profile as AsyncProfile;
use ApiClients\Foundation\Hydrator\CommandBus\Command\BuildAsyncFromSyncCommand;
use ApiClients\Client\Twitter\Resource\Profile as BaseProfile;
use ApiClients\Client\Twitter\Resource\ProfileInterface;
use ApiClients\Foundation\Hydrator\CommandBus\Command\BuildSyncFromAsyncCommand;

class Profile extends BaseProfile
{
    public function putProfile(): Profile
    {
        return $this->wait(
            $this->handleCommand(
                new BuildAsyncFromSyncCommand(self::HYDRATE_CLASS, $this)
            )->then(function (AsyncProfile $profile) {
                return $profile->putProfile();
            })->then(function (Profile $profile) {
                return $this->handleCommand(new BuildSyncFromAsyncCommand(self::HYDRATE_CLASS, $profile));
            })
        );
    }

    public function refresh() : Profile
    {
        return $this->wait(
            $this->handleCommand(
                new BuildAsyncFromSyncCommand(self::HYDRATE_CLASS, $this)
            )->then(function (ProfileInterface $profile) {
                return $profile->refresh();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            })
        );
    }
}


GitHub Access Token became invalid

Push — master ( 61a149...5b9c21 )

Profile::putProfile() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

1			<?php declare(strict_types=1);
2
3			namespace ApiClients\Client\Twitter\Resource\Sync;
4
5			use ApiClients\Client\Twitter\Resource\Async\Profile as AsyncProfile;
6			use ApiClients\Foundation\Hydrator\CommandBus\Command\BuildAsyncFromSyncCommand;
7			use ApiClients\Client\Twitter\Resource\Profile as BaseProfile;
8			use ApiClients\Client\Twitter\Resource\ProfileInterface;
9			use ApiClients\Foundation\Hydrator\CommandBus\Command\BuildSyncFromAsyncCommand;
10
11			class Profile extends BaseProfile
12			{
13			public function putProfile(): Profile
14			{
15			return $this->wait(
16			$this->handleCommand(
17			new BuildAsyncFromSyncCommand(self::HYDRATE_CLASS, $this)
18			)->then(function (AsyncProfile $profile) {
19			return $profile->putProfile();
20			})->then(function (Profile $profile) {
21			return $this->handleCommand(new BuildSyncFromAsyncCommand(self::HYDRATE_CLASS, $profile));
22			})
23			);
24			}
25
26			public function refresh() : Profile
27			{
28			return $this->wait(
29			$this->handleCommand(
30			new BuildAsyncFromSyncCommand(self::HYDRATE_CLASS, $this)
31			)->then(function (ProfileInterface $profile) {
32			return $profile->refresh();
			0 ignored issues – show Bug introduced 2016-12-10 21:20 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `ApiClients\Client\Twitte...source\ProfileInterface` as the method `refresh()` does only exist in the following implementations of said interface: `ApiClients\Client\Twitter\Resource\Async\Profile`, `ApiClients\Client\Twitter\Resource\Sync\Profile`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
33			})
34			);
35			}
36			}
37

php-api-clients / twitter

GitHub Access Token became invalid

Push — master ( 61a149...5b9c21 )

Profile::putProfile() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like