UserHandler - Code Metrics - Inspection of "Move duplicated logic from clients and resources i..." - php-api-clients/travis - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Cees-Jan

created 2016-12-19 21:33 UTC

UserHandler A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	40
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	2
lcom	1
cbo	5
dl	40
loc	40
ccs	12
cts	12
cp	1
rs	10
c	1
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	5	5	1
A	handle()	11	11	1

How to fix Duplicated Code

<?php declare(strict_types=1);

namespace ApiClients\Client\Travis\CommandBus\Handler;

use ApiClients\Client\Travis\CommandBus\Command\UserCommand;
use ApiClients\Client\Travis\Resource\UserInterface;
use ApiClients\Foundation\Hydrator\Hydrator;
use ApiClients\Foundation\Transport\Service\RequestService;
use Psr\Http\Message\ResponseInterface;
use React\Promise\PromiseInterface;
use RingCentral\Psr7\Request;
use function React\Promise\resolve;
use function WyriHaximus\React\futureFunctionPromise;

final class UserHandler

{
    /**
     * @var RequestService
     */
    private $requestService;

    /**
     * @var Hydrator
     */
    private $hydrator;

    /**
     * @param RequestService $requestService
     * @param Hydrator $hydrator
     */
    public function __construct(RequestService $requestService, Hydrator $hydrator)
    {
        $this->requestService = $requestService;
        $this->hydrator = $hydrator;
    }

    /**
     * Fetch the given repository and hydrate it
     *
     * @param UserCommand $command
     * @return PromiseInterface
     */
    public function handle(UserCommand $command): PromiseInterface

    {
        return $this->requestService->handle(
            new Request('GET', 'users')
        )->then(function (ResponseInterface $response) {
            return resolve($this->hydrator->hydrate(
                UserInterface::HYDRATE_CLASS,
                $response->getBody()->getJson()['user']
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ));
        });
    }
}


GitHub Access Token became invalid

Pull Request — master (#1)

UserHandler A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

1			<?php declare(strict_types=1);
2
3			namespace ApiClients\Client\Travis\CommandBus\Handler;
4
5			use ApiClients\Client\Travis\CommandBus\Command\UserCommand;
6			use ApiClients\Client\Travis\Resource\UserInterface;
7			use ApiClients\Foundation\Hydrator\Hydrator;
8			use ApiClients\Foundation\Transport\Service\RequestService;
9			use Psr\Http\Message\ResponseInterface;
10			use React\Promise\PromiseInterface;
11			use RingCentral\Psr7\Request;
12			use function React\Promise\resolve;
13			use function WyriHaximus\React\futureFunctionPromise;
14
15		View Code Duplication	final class UserHandler
			0 ignored issues – show Duplication introduced 2016-12-19 21:36 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
16			{
17			/**
18			* @var RequestService
19			*/
20			private $requestService;
21
22			/**
23			* @var Hydrator
24			*/
25			private $hydrator;
26
27			/**
28			* @param RequestService $requestService
29			* @param Hydrator $hydrator
30			*/
31	1		public function __construct(RequestService $requestService, Hydrator $hydrator)
32			{
33	1		$this->requestService = $requestService;
34	1		$this->hydrator = $hydrator;
35	1		}
36
37			/**
38			* Fetch the given repository and hydrate it
39			*
40			* @param UserCommand $command
41			* @return PromiseInterface
42			*/
43	1		public function handle(UserCommand $command): PromiseInterface
			0 ignored issues – show Unused Code introduced 2016-12-19 21:36 UTC by Report Bug Copy Issue Report The parameter `$command` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
44			{
45	1		return $this->requestService->handle(
46	1		new Request('GET', 'users')
47	1		)->then(function (ResponseInterface $response) {
48	1		return resolve($this->hydrator->hydrate(
49	1		UserInterface::HYDRATE_CLASS,
50	1		$response->getBody()->getJson()['user']
			0 ignored issues – show Bug introduced 2016-12-19 21:36 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Http\Message\StreamInterface` as the method `getJson()` does only exist in the following implementations of said interface: `ApiClients\Foundation\Transport\JsonStream`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
51			));
52	1		});
53			}
54			}
55

php-api-clients / travis

GitHub Access Token became invalid

Pull Request — master (#1)

UserHandler A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Duplication Side-by-Side

Filter issues like