CommitsHandler::handle() - Code Metrics - Inspection of "Move duplicated logic from clients and resources i..." - php-api-clients/travis - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Cees-Jan

created 2016-12-25 12:49 UTC

CommitsHandler::handle() A

↳ Parent: CommitsHandler

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	5
cts	5
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	1
crap	1

<?php declare(strict_types=1);

namespace ApiClients\Client\Travis\CommandBus\Handler;

use ApiClients\Client\Travis\CommandBus\Command\CommitsCommand;
use ApiClients\Client\Travis\Resource\CommitInterface;
use ApiClients\Tools\Services\Client\FetchAndHydrateService;
use ApiClients\Tools\Services\Client\FetchAndIterateService;
use React\Promise\PromiseInterface;
use function React\Promise\resolve;
use function WyriHaximus\React\futureFunctionPromise;

final class CommitsHandler
{
    /**
     * @var FetchAndHydrateService
     */
    private $service;

    /**
     * @param FetchAndIterateService $service
     */
    public function __construct(FetchAndIterateService $service)
    {
        $this->service = $service;

    }

    /**
     * Fetch the given repository and hydrate it
     *
     * @param CommitsCommand $command
     * @return PromiseInterface
     */
    public function handle(CommitsCommand $command): PromiseInterface
    {
        return $this->service->handle(
            'repos/' . $command->getRepository() . '/builds',
            'commits',
            CommitInterface::HYDRATE_CLASS
        );
    }
}


1		<?php declare(strict_types=1);
2
3		namespace ApiClients\Client\Travis\CommandBus\Handler;
4
5		use ApiClients\Client\Travis\CommandBus\Command\CommitsCommand;
6		use ApiClients\Client\Travis\Resource\CommitInterface;
7		use ApiClients\Tools\Services\Client\FetchAndHydrateService;
8		use ApiClients\Tools\Services\Client\FetchAndIterateService;
9		use React\Promise\PromiseInterface;
10		use function React\Promise\resolve;
11		use function WyriHaximus\React\futureFunctionPromise;
12
13		final class CommitsHandler
14		{
15		/**
16		* @var FetchAndHydrateService
17		*/
18		private $service;
19
20		/**
21		* @param FetchAndIterateService $service
22		*/
23	1	public function __construct(FetchAndIterateService $service)
24		{
25	1	$this->service = $service;
		0 ignored issues – show Documentation Bug introduced 2016-12-22 18:22 UTC by Report Bug Copy Issue Report It seems like `$service` of type `object<ApiClients\Tools\...FetchAndIterateService>` is incompatible with the declared type `object<ApiClients\Tools\...FetchAndHydrateService>` of property `$service`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
26	1	}
27
28		/**
29		* Fetch the given repository and hydrate it
30		*
31		* @param CommitsCommand $command
32		* @return PromiseInterface
33		*/
34	1	public function handle(CommitsCommand $command): PromiseInterface
35		{
36	1	return $this->service->handle(
37	1	'repos/' . $command->getRepository() . '/builds',
38	1	'commits',
39	1	CommitInterface::HYDRATE_CLASS
40		);
41		}
42		}
43

php-api-clients / travis

GitHub Access Token became invalid

Pull Request — master (#1)

CommitsHandler::handle() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like