Client::repositories() - Code Metrics - Inspection of "Merge pull request #3 from php-api-clients/feature..." - php-api-clients/travis - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a9556a...775799 )

by Cees-Jan

created 2016-12-26 19:55 UTC

Client::repositories() A

↳ Parent: Client

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	9
ccs	0
cts	8
cp	0
rs	9.6666
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	0
crap	2

<?php
declare(strict_types=1);

namespace ApiClients\Client\Travis;

use ApiClients\Foundation\Factory;
use React\EventLoop\Factory as LoopFactory;
use React\EventLoop\LoopInterface;
use Rx\React\Promise;
use ApiClients\Client\Travis\Resource\RepositoryInterface;
use ApiClients\Client\Travis\Resource\SSHKeyInterface;
use ApiClients\Client\Travis\Resource\UserInterface;
use function Clue\React\Block\await;
use function React\Promise\resolve;

class Client
{
    /**
     * @var LoopInterface
     */
    protected $loop;

    /**
     * @var AsyncClient
     */
    protected $client;

    /**
     * @param string $token
     */
    public function __construct(string $token = '')
    {
        $this->loop = LoopFactory::create();
        $this->options = ApiSettings::getOptions($token, 'Sync');
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->client = new AsyncClient($this->loop, $token, Factory::create($this->loop, $this->options));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @param string $repository
     * @return RepositoryInterface
     */
    public function repository(string $repository): RepositoryInterface
    {
        return await(
            $this->client->repository($repository),
            $this->loop
        );
    }

    /**
     * @return UserInterface
     */
    public function user(): UserInterface
    {
        return await(
            $this->client->user(),
            $this->loop
        );
    }

    /**
     * @param int $id
     * @return SSHKeyInterface
     */
    public function sshKey(int $id): SSHKeyInterface
    {
        return await(
            $this->client->sshKey($id),
            $this->loop
        );
    }

    /**
     * @return array
     */
    public function hooks(): array
    {
        return await(
            Promise::fromObservable(
                $this->client->hooks()->toArray()
            ),
            $this->loop
        );
    }

    /**
     * @return array
     */
    public function repositories(): array
    {
        return await(
            Promise::fromObservable(
                $this->client->repositories()->toArray()
            ),
            $this->loop
        );
    }

    /**
     * @return array
     */
    public function accounts(): array
    {
        return await(
            Promise::fromObservable(
                $this->client->accounts()->toArray()
            ),
            $this->loop
        );
    }

    /**
     * @return array
     */
    public function broadcasts(): array
    {
        return await(
            Promise::fromObservable(
                $this->client->broadcasts()->toArray()
            ),
            $this->loop
        );
    }
}


1			<?php
2			declare(strict_types=1);
3
4			namespace ApiClients\Client\Travis;
5
6			use ApiClients\Foundation\Factory;
7			use React\EventLoop\Factory as LoopFactory;
8			use React\EventLoop\LoopInterface;
9			use Rx\React\Promise;
10			use ApiClients\Client\Travis\Resource\RepositoryInterface;
11			use ApiClients\Client\Travis\Resource\SSHKeyInterface;
12			use ApiClients\Client\Travis\Resource\UserInterface;
13			use function Clue\React\Block\await;
14			use function React\Promise\resolve;
15
16			class Client
17			{
18			/**
19			* @var LoopInterface
20			*/
21			protected $loop;
22
23			/**
24			* @var AsyncClient
25			*/
26			protected $client;
27
28			/**
29			* @param string $token
30			*/
31			public function __construct(string $token = '')
32			{
33			$this->loop = LoopFactory::create();
34			$this->options = ApiSettings::getOptions($token, 'Sync');
			0 ignored issues – show Bug introduced 2016-12-04 10:43 UTC by Report Bug Copy Issue Report The property `options` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
35			$this->client = new AsyncClient($this->loop, $token, Factory::create($this->loop, $this->options));
			0 ignored issues – show Documentation introduced 2016-12-26 09:35 UTC by Report Bug Copy Issue Report `\ApiClients\Foundation\F...->loop, $this->options)` is of type `object<ApiClients\Foundation\Client>`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
36			}
37
38			/**
39			* @param string $repository
40			* @return RepositoryInterface
41			*/
42			public function repository(string $repository): RepositoryInterface
43			{
44			return await(
45			$this->client->repository($repository),
46			$this->loop
47			);
48			}
49
50			/**
51			* @return UserInterface
52			*/
53			public function user(): UserInterface
54			{
55			return await(
56			$this->client->user(),
57			$this->loop
58			);
59			}
60
61			/**
62			* @param int $id
63			* @return SSHKeyInterface
64			*/
65			public function sshKey(int $id): SSHKeyInterface
66			{
67			return await(
68			$this->client->sshKey($id),
69			$this->loop
70			);
71			}
72
73			/**
74			* @return array
75			*/
76			public function hooks(): array
77			{
78			return await(
79			Promise::fromObservable(
80			$this->client->hooks()->toArray()
81			),
82			$this->loop
83			);
84			}
85
86			/**
87			* @return array
88			*/
89			public function repositories(): array
90			{
91			return await(
92			Promise::fromObservable(
93			$this->client->repositories()->toArray()
94			),
95			$this->loop
96			);
97			}
98
99			/**
100			* @return array
101			*/
102			public function accounts(): array
103			{
104			return await(
105			Promise::fromObservable(
106			$this->client->accounts()->toArray()
107			),
108			$this->loop
109			);
110			}
111
112			/**
113			* @return array
114			*/
115			public function broadcasts(): array
116			{
117			return await(
118			Promise::fromObservable(
119			$this->client->broadcasts()->toArray()
120			),
121			$this->loop
122			);
123			}
124			}
125

php-api-clients / travis

GitHub Access Token became invalid

Push — master ( a9556a...775799 )

Client::repositories() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like