GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Completed
Pull Request — master (#1)
by Cees-Jan
06:08 queued 02:53
created

RepositoryHandler   A

Complexity

Total Complexity 2

Size/Duplication

Total Lines 40
Duplicated Lines 0 %

Coupling/Cohesion

Components 1
Dependencies 6

Test Coverage

Coverage 100%

Importance

Changes 0
Metric Value
wmc 2
lcom 1
cbo 6
dl 0
loc 40
ccs 12
cts 12
cp 1
rs 10
c 0
b 0
f 0

2 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 5 1
A handle() 0 11 1
1
<?php declare(strict_types=1);
2
3
namespace ApiClients\Client\Travis\CommandBus\Handler;
4
5
use ApiClients\Client\Travis\CommandBus\Command\RepositoryCommand;
6
use ApiClients\Client\Travis\Resource\RepositoryInterface;
7
use ApiClients\Foundation\Hydrator\Hydrator;
8
use ApiClients\Foundation\Transport\Service\RequestService;
9
use Psr\Http\Message\ResponseInterface;
10
use React\Promise\PromiseInterface;
11
use RingCentral\Psr7\Request;
12
use function React\Promise\resolve;
13
use function WyriHaximus\React\futureFunctionPromise;
14
15
final class RepositoryHandler
16
{
17
    /**
18
     * @var RequestService
19
     */
20
    private $requestService;
21
22
    /**
23
     * @var Hydrator
24
     */
25
    private $hydrator;
26
27
    /**
28
     * @param RequestService $requestService
29
     * @param Hydrator $hydrator
30
     */
31 1
    public function __construct(RequestService $requestService, Hydrator $hydrator)
32
    {
33 1
        $this->requestService = $requestService;
34 1
        $this->hydrator = $hydrator;
35 1
    }
36
37
    /**
38
     * Fetch the given repository and hydrate it
39
     *
40
     * @param RepositoryCommand $command
41
     * @return PromiseInterface
42
     */
43 1
    public function handle(RepositoryCommand $command): PromiseInterface
44
    {
45 1
        return $this->requestService->handle(
46 1
            new Request('GET', 'repos/' . $command->getRepository())
47 1
        )->then(function (ResponseInterface $response) {
48 1
            return resolve($this->hydrator->hydrate(
49 1
                RepositoryInterface::HYDRATE_CLASS,
50 1
                $response->getBody()->getJson()['repo']
0 ignored issues
show
Bug introduced by
It seems like you code against a concrete implementation and not the interface Psr\Http\Message\StreamInterface as the method getJson() does only exist in the following implementations of said interface: ApiClients\Foundation\Transport\JsonStream.

Let’s take a look at an example:

interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the interface:

    interface User
    {
        /** @return string */
        public function getPassword();
    
        /** @return string */
        public function getDisplayName();
    }
    
Loading history...
51
            ));
52 1
        });
53
    }
54
}
55