Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php declare(strict_types=1); |
||
8 | View Code Duplication | abstract class EmptyJob implements JobInterface, EmptyResourceInterface |
|
|
|||
9 | { |
||
10 | /** |
||
11 | * @return int |
||
12 | */ |
||
13 | 2 | public function id() : int |
|
17 | |||
18 | /** |
||
19 | * @return int |
||
20 | */ |
||
21 | 2 | public function buildId() : int |
|
25 | |||
26 | /** |
||
27 | * @return int |
||
28 | */ |
||
29 | 2 | public function repositoryId() : int |
|
33 | |||
34 | /** |
||
35 | * @return int |
||
36 | */ |
||
37 | 2 | public function commitId() : int |
|
41 | |||
42 | /** |
||
43 | * @return int |
||
44 | */ |
||
45 | 2 | public function logId() : int |
|
49 | |||
50 | /** |
||
51 | * @return string |
||
52 | */ |
||
53 | 2 | public function number() : string |
|
57 | |||
58 | /** |
||
59 | * @return array |
||
60 | */ |
||
61 | 2 | public function config() : array |
|
65 | |||
66 | /** |
||
67 | * @return string |
||
68 | */ |
||
69 | 2 | public function state() : string |
|
73 | |||
74 | /** |
||
75 | * @return DateTimeInterface |
||
76 | */ |
||
77 | 2 | public function startedAt() : DateTimeInterface |
|
81 | |||
82 | /** |
||
83 | * @return DateTimeInterface |
||
84 | */ |
||
85 | 2 | public function finishedAt() : DateTimeInterface |
|
89 | |||
90 | /** |
||
91 | * @return string |
||
92 | */ |
||
93 | 2 | public function queue() : string |
|
97 | |||
98 | /** |
||
99 | * @return bool |
||
100 | */ |
||
101 | 2 | public function allowFailure() : bool |
|
105 | |||
106 | /** |
||
107 | * @return array |
||
108 | */ |
||
109 | 2 | public function annotationIds() : array |
|
113 | } |
||
114 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.